Updated: [rhinstaller/blivet/pulls/138 master] Allow partitioning of md arrays whose members are all disks
by dashea
The motivation here is to enable hardware vendors to use regular md arrays for fwraid without the need for mdmonitor. The difficulty is that there will be nothing to distinguish these fwraid arrays from any other user-created array whose members are disks.
Existing arrays whose members/parents are all partitionable will be partitionable.
Existing arrays whose members/parents are all disks will be treated as disks.
It shouldn't be possible to delete such arrays in anaconda. They should be treated like fwraid arrays. It will be possible to delete them in blivet by scheduling an `ActionDestroyFormat`/`ActionDestroyDevice` action pair, but calling `DeviceTree.recursiveRemove` on them will not destroy the array.
--
To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/138
8 years, 11 months
[rhel7-branch][PATCH] Do not mix two lists of fields when applying changes in text mode (#1231149)
by Vratislav Podzimek
These two lists have things on different positions so we cannot use a single
index for both. So while iterating over visible_fields, we should use the index
in combination with visible_fields.
Signed-off-by: Vratislav Podzimek <vpodzime(a)redhat.com>
---
pyanaconda/ui/tui/spokes/__init__.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/pyanaconda/ui/tui/spokes/__init__.py b/pyanaconda/ui/tui/spokes/__init__.py
index ff5c88c..79292bc 100644
--- a/pyanaconda/ui/tui/spokes/__init__.py
+++ b/pyanaconda/ui/tui/spokes/__init__.py
@@ -301,9 +301,9 @@ class EditTUISpoke(NormalTUISpoke):
try:
idx = int(key) - 1
if idx >= 0 and idx < len(self.visible_fields):
- if self.edit_fields[idx].aux == self.CHECK:
+ if self.visible_fields[idx].aux == self.CHECK:
setdeepattr(self.args, self.visible_fields[idx].attribute,
- not getdeepattr(self.args, self.edit_fields[idx][1]))
+ not getdeepattr(self.args, self.visible_fields[idx][1]))
self.app.redraw()
self.apply()
else:
--
2.1.0
8 years, 11 months
Re: [rhinstaller/blivet/pulls/156 master] LVM cache detection, manipulation and reporting
by dashea
> @@ -847,6 +859,28 @@ def removeInternalLV(self, int_lv):
> self.name)
> raise ValueError(msg)
>
> + @property
> + def cached(self):
> + return bool(self.cache)
> +
> + @property
> + def cache(self):
> + if self.exists and not self._cache:
> + # check if we have a cache pool internal LV
> + pool = None
> + for lv in self._internal_lvs:
> + if isinstance(lv, LVMCachePoolLogicalVolumeDevice):
> + pool = lv
> +
> + self._cache = LVMCache(self, size=pool.size, exists=True)
> +
> + return self._cache
This always creates an `LVMCache`, no? So then the `cached` property above will always be True for existing LVs. I think it just needs an `if pool is not None:` guarding the assignment to `self._cache`.
--
To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/156#discussion_r33150879
8 years, 11 months