[PATCH] Only pad for md metadata if pvs use multiple disks.
by David Lehman
---
blivet/partitioning.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/blivet/partitioning.py b/blivet/partitioning.py
index ed001f7..9d5f08f 100644
--- a/blivet/partitioning.py
+++ b/blivet/partitioning.py
@@ -1661,7 +1661,7 @@ class VGChunk(Chunk):
# on RAID (see the devicefactory.LVMFactory._get_total_space method)
if not req.device.exists and req.device.vg.pvs:
max_raid_disks = max(len(pv.disks) for pv in req.device.vg.pvs)
- if max_raid_disks:
+ if max_raid_disks > 1:
self.pool -= 5 * max_raid_disks
super(VGChunk, self).addRequest(req)
--
1.9.3
9 years, 8 months
[anaconda][master/rhel7-branch] kickstart: catch more storage exns
by David Lehman
This is a slightly expanded approach to handling general storage errors
when parsing kickstart. Patch 1 catches and re-raises exceptions raised
when instantiating devices as KickstartValueError so the exception
contains the line number. Patch 2 is the original patch I sent, and
just catches any StorageError or ValueError that makes it up to
parseKickstart so we can exit gracefully instead of showing a traceback.
9 years, 8 months
[PATCH lorax] Don't remove /usr/share/doc/anaconda.
by Chris Lumens
That's where the help is stored.
---
share/runtime-cleanup.tmpl | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/share/runtime-cleanup.tmpl b/share/runtime-cleanup.tmpl
index f8107ca..37cfc2b 100644
--- a/share/runtime-cleanup.tmpl
+++ b/share/runtime-cleanup.tmpl
@@ -62,7 +62,7 @@ removepkg xorg-x11-server-common yum-utils firewalld
## other removals
remove /boot /home /media /opt /srv /tmp/*
remove /usr/etc /usr/games /usr/local /usr/tmp
-remove /usr/share/doc /usr/share/info /usr/share/man /usr/share/gnome
+remove /usr/share/info /usr/share/man /usr/share/gnome
remove /usr/share/mime/application /usr/share/mime/audio /usr/share/mime/image
remove /usr/share/mime/inode /usr/share/mime/message /usr/share/mime/model
remove /usr/share/mime/multipart /usr/share/mime/packages /usr/share/mime/text
@@ -329,6 +329,9 @@ removefrom ${product.name}-logos /etc/*
removefrom ${product.name}-logos /usr/share/icons/{Bluecurve,oxygen}/*
removefrom ${product.name}-logos /usr/share/{firstboot,gnome-screensaver,kde4,pixmaps}/*
+## Remove everything from /usr/share/doc except for anaconda's help files.
+runcmd find ${root}/usr/share/doc -depth -mindepth 1 -path ${root}/usr/share/doc/anaconda -prune -o -type d -print0 | xargs 0 rm -r
+
## cleanup_python_files()
runcmd find ${root} -name "*.pyo" -type f -delete
runcmd find ${root} -name "*.pyc" -type f -exec ln -sf /dev/null {} \;
--
1.9.3
9 years, 8 months
[PATCH] Remove the border on the layout testing box.
by Chris Lumens
This results in a very thin grey area between the white layout testing box and
the black border of that box. It's ugly.
---
pyanaconda/ui/gui/spokes/keyboard.glade | 1 -
1 file changed, 1 deletion(-)
diff --git a/pyanaconda/ui/gui/spokes/keyboard.glade b/pyanaconda/ui/gui/spokes/keyboard.glade
index 149b2c8..0f4d9cb 100644
--- a/pyanaconda/ui/gui/spokes/keyboard.glade
+++ b/pyanaconda/ui/gui/spokes/keyboard.glade
@@ -311,7 +311,6 @@
<object class="GtkTextView" id="layoutTextView">
<property name="visible">True</property>
<property name="can_focus">True</property>
- <property name="border_width">6</property>
<property name="buffer">layoutTestBuffer</property>
<property name="accepts_tab">False</property>
</object>
--
1.9.3
9 years, 8 months
[PATCH lorax] Stop removing libXt from the installation media.
by Chris Lumens
It's needed by yelp, which is how anaconda displays help.
---
share/runtime-cleanup.tmpl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/share/runtime-cleanup.tmpl b/share/runtime-cleanup.tmpl
index d144a51..f8107ca 100644
--- a/share/runtime-cleanup.tmpl
+++ b/share/runtime-cleanup.tmpl
@@ -50,7 +50,7 @@ removefrom isomd5sum --allbut /usr/bin/checkisomd5
## various other things we remove to save space
removepkg avahi-autoipd coreutils-libs dash db4-utils diffutils file
removepkg genisoimage gnome-python2 info iptables
-removepkg jasper-libs libXt libXxf86misc
+removepkg jasper-libs libXxf86misc
removepkg libasyncns libhbaapi libhbalinux
removepkg libmcpp libpcap libtiff libutempter linux-atm-libs
removepkg lvm2-libs m4 mailx makebootfat mcpp
--
1.9.3
9 years, 8 months
[PATCH blivet] disable LVM metadata backup during image installs (#1066004)
by Will Woods
Hey all,
This patchset should make blivet (and therefore anaconda) suppress the
creation of LVM metadata backup/archive files during image installs.
The first patch refactors devicelibs.lvm so that every call to the LVM
binary goes through _getConfigArgs().
The second patch adds an 'autobackup' attribute, which disables metadata
backup by having _getConfigArgs() add 'backup {backup=0 archive=0}' to the
LVM config (via --config) if 'autobackup' is False. (It also adds a test for
this to the existing LVM unit tests.)
The last patch makes Platform.update_from_flags() set autobackup=False if
flags.image_install is set. We *could* set autobackup=False from inside
anaconda, but update_from_flags() gets called from storageInitialize(),
which is called by any anaconda process that uses blivet, so I'm pretty sure
that will correctly disable autobackups during anaconda image installs.
The total diffstat is as follows:
blivet/devicelibs/lvm.py | 98 +++++++++++++++++----------------------
blivet/platform.py | 3 ++
tests/devicelibs_test/lvm_test.py | 21 +++++++++
3 files changed, 66 insertions(+), 56 deletions(-)
'make test' shows no new failures after adding this code.
Thanks for your time and consideration,
-w
9 years, 8 months
[rhel7-branch 0/8] Port some patches from master to enable --make-tar
by Brian C. Lane
Most of these are backports from master, slightly modified to fit rhel7. The
--no-recursion patch actually needs to go TO master. Otherwise you get a really
large tar file including the files multiple times.
With these changes you can use a simplified kickstart (eg. using --nocore and
leaving out the kernel) to create a tar file like this:
livemedia-creator --make-tar --no-virt --ks ./rhel7-docker.ks --image-name rhel7.1-docker.tar.bz2 --compression bzip2
Import it into docker:
cat /var/tmp/rhel7.1-docker.tar.bz2 | docker import - rhel7-test
And run it:
docker run -ti rhel7-test /usr/bin/bash
(you need to have docker, lorx and anaconda-tui installed on the build system)
I've also created a pull request for this on github as an experiment. You can
review the patches at:
https://github.com/bcl/lorax/pull/1
Brian C. Lane (8):
livemedia-creator: Make --make-fsimage work with virt-install
(#1144140)
livemedia-creator: Copy fsimage if hardlink fails (#1144140)
livemedia-creator: Check fsimage kickstart for single partition
(#1144140)
livemedia-creator: Add support for making tarfiles (#1144140)
livemedia-creator: Add --no-recursion to mktar (#1144140)
RHEL7 doesn't include pigz or pbzip2 (#1144140)
livemedia-creator: Use RHEL7 version of kickstart (#1144140)
livemedia-creator: Make sure ROOT_PATH exists (#1144140)
README.livemedia-creator | 15 +++++
docs/livemedia-creator.1 | 27 ++++++++-
src/pylorax/imgutils.py | 52 ++++++++++++-----
src/sbin/livemedia-creator | 135 ++++++++++++++++++++++++++++++++++-----------
4 files changed, 179 insertions(+), 50 deletions(-)
--
1.9.3
9 years, 8 months
[master/rhel7-branch] s390x: Apply disk selection before dasdfmt to preserve data. (#1078892)
by Samantha N. Bueno
After running dasdfmt on any DASDs requiring it, some key information
(selected disks) was getting lost. So, apply disk selection before running
dasdfmt in order to preserve it.
Resolves: rhbz#1078892
---
pyanaconda/ui/gui/spokes/storage.py | 3 +++
1 file changed, 3 insertions(+)
diff --git a/pyanaconda/ui/gui/spokes/storage.py b/pyanaconda/ui/gui/spokes/storage.py
index d597173..d2ec6fe 100644
--- a/pyanaconda/ui/gui/spokes/storage.py
+++ b/pyanaconda/ui/gui/spokes/storage.py
@@ -809,6 +809,9 @@ class StorageSpoke(NormalSpoke, StorageChecker):
# check for unformatted DASDs and launch dasdfmt if any discovered
dasds = make_unformatted_dasd_list(self.selected_disks)
if len(dasds) > 0:
+ # We want to apply current selection before running dasdfmt to
+ # prevent this information from being lost afterward
+ applyDiskSelection(self.storage, self.data, self.selected_disks)
dialog = DasdFormatDialog(self.data, self.storage, dasds)
ignoreEscape(dialog.window)
rc = self.run_lightbox_dialog(dialog)
--
1.9.3
9 years, 8 months
[PATCH] Explain what the IPMI constants mean.
by Chris Lumens
---
pyanaconda/constants.py | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/pyanaconda/constants.py b/pyanaconda/constants.py
index e70ae1e..4adf04a 100644
--- a/pyanaconda/constants.py
+++ b/pyanaconda/constants.py
@@ -163,7 +163,7 @@ import logging
LOGLVL_LOCK = logging.DEBUG-1
# Constants for reporting status to IPMI. These are from the IPMI spec v2 rev1.1, page 512.
-IPMI_STARTED = 0x7
-IPMI_FINISHED = 0x8
-IPMI_ABORTED = 0x9
-IPMI_FAILED = 0xA
+IPMI_STARTED = 0x7 # installation started
+IPMI_FINISHED = 0x8 # installation finished successfully
+IPMI_ABORTED = 0x9 # installation finished unsuccessfully, due to some non-exn error
+IPMI_FAILED = 0xA # installation hit an exception
--
1.9.3
9 years, 8 months