[PATCH] rpmostreepayload: Drop selinux-ensure-labeled call
by Colin Walters
>From 38ba61b555bc26a0622a0879dbf1e5e77fe6e73a Mon Sep 17 00:00:00 2001
From: Colin Walters <walters(a)verbum.org>
Date: Mon, 7 Jul 2014 18:31:45 -0400
Subject: [PATCH] rpmostreepayload: Drop selinux-ensure-labeled call
I originally developed this command for the custom disk image
generation code in rpm-ostree-toolbox. That tool uses libguestfs, and
we perform SELinux labeling using *host* tools. We may not even have
a SELinux policy loaded on the host system. The guestfs appliance has
no policy loaded, so we had to inject setxattr calls to ensure labels.
In contrast, Anaconda requires install ~= target, and boots with a
loaded policy in permissive mode. Any stray files we create will at
least be labeled in some form.
This matters for the new /ostree directory; it needs to at least have
labels, and the loaded Anaconda policy accomplishes that.
This call was hence always a no-op because created files were always
labeled.
The actual *reason* I am now dropping this call though is because
it was traversing over the mounted /proc filesystem, which could
cause an installation to error out if a process exited =(
So let's just not do that.
---
pyanaconda/packaging/rpmostreepayload.py | 8 --------
1 file changed, 8 deletions(-)
diff --git a/pyanaconda/packaging/rpmostreepayload.py
b/pyanaconda/packaging/rpmostreepayload.py
index 7bc4ad9..5c024f1 100644
--- a/pyanaconda/packaging/rpmostreepayload.py
+++ b/pyanaconda/packaging/rpmostreepayload.py
@@ -235,11 +235,3 @@ class RPMOSTreePayload(ArchivePayload):
set_kargs_args.extend(self.storage.bootloader.boot_args)
set_kargs_args.append("root=" +
self.storage.rootDevice.fstabSpec)
self._safeExecWithRedirect("ostree", set_kargs_args)
-
- # This command iterates over all files we might have created
- # and ensures they're labeled. It's like running
- # chroot(iutil.getTargetPhysicalRoot()) + fixfiles, except
- # with a better name and semantics.
- self._safeExecWithRedirect("ostree",
- ["admin", "--sysroot=" + iutil.getTargetPhysicalRoot(),
- "instutil", "selinux-ensure-labeled",
iutil.getTargetPhysicalRoot(), ""])
--
1.8.3.1
9 years, 11 months
[PATCH - lorax] Allow doing non-URL installs if using virt.
by Chris Lumens
In this case, we don't need to pass a repo parameter to anaconda. It's running
in a VM and knows how to deal with a kickstart file.
---
src/sbin/livemedia-creator | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/sbin/livemedia-creator b/src/sbin/livemedia-creator
index 88ca723..f055273 100755
--- a/src/sbin/livemedia-creator
+++ b/src/sbin/livemedia-creator
@@ -1102,7 +1102,7 @@ def main():
# Make the disk or filesystem image
if not opts.disk_image and not opts.fs_image:
errors = []
- if ks.handler.method.method != "url":
+ if ks.handler.method.method != "url" and opts.no_virt:
errors.append("Only url install method is currently supported. Please "
"fix your kickstart file." )
--
1.9.3
9 years, 11 months
[PATCH] DNFPayload: do not add group 'core' twice.
by Ales Kozumplik
From: Ales Kozumplik <ales(a)redhat.com>
Related: rhbz#1116839
---
pyanaconda/packaging/dnfpayload.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/pyanaconda/packaging/dnfpayload.py b/pyanaconda/packaging/dnfpayload.py
index d7d3142..a5cd3d6 100644
--- a/pyanaconda/packaging/dnfpayload.py
+++ b/pyanaconda/packaging/dnfpayload.py
@@ -220,6 +220,8 @@ class DNFPayload(packaging.PackagePayload):
self._miss(e)
for group in self.data.packages.groupList:
+ if group.name == 'core':
+ continue
try:
default = group.include in (GROUP_ALL,
GROUP_DEFAULT)
--
1.9.3
9 years, 11 months
[blivet:master 0/4] Post python3 compatibility changes fixup
by Anne Mulhern
None of these are very major, so should be easy acks.
mulhern (4):
Add a simple test of generateBackupPassphrase() result format
Use range instead of xrange in generateBackupPassphrase()
Disable redefined-builtin warning.
Use add_metaclass instead of with_metaclass.
blivet/devicelibs/crypto.py | 11 ++++-------
blivet/devicelibs/raid.py | 8 +++++---
blivet/devices.py | 8 +++++---
blivet/formats/fs.py | 2 +-
blivet/formats/fslabel.py | 5 +++--
blivet/formats/fslabeling.py | 5 +++--
tests/devicelibs_test/crypto_test.py | 6 ++++++
tests/formats_test/fslabeling.py | 5 +++--
tests/size_test.py | 2 +-
9 files changed, 31 insertions(+), 21 deletions(-)
--
1.9.3
9 years, 11 months
[PATCH 0/2] Make the class graph into a class tree
by David Shea
There's more that could be done but this is at least a start.
David Shea (2):
Unravel the Hub and Spoke classes.
Remove the window property from UIObject.
pyanaconda/ui/common.py | 60 ++++++++++++++++++------------------
pyanaconda/ui/gui/hubs/__init__.py | 2 +-
pyanaconda/ui/gui/spokes/__init__.py | 52 +++++--------------------------
pyanaconda/ui/tui/hubs/__init__.py | 2 +-
pyanaconda/ui/tui/simpleline/base.py | 7 +----
pyanaconda/ui/tui/spokes/__init__.py | 2 +-
6 files changed, 41 insertions(+), 84 deletions(-)
--
2.0.0
9 years, 11 months
Pylint errors from blivet Python 3 compatibility patch set
by Anne Mulhern
Hi all,
They're were about 300 generated by the patch set.
I think they are mostly related to the compatibility tricks messing up pylint analyses;
consequently many will probably turn out to be duplicates.
I'm investigating them and plan to post a patch set as soon as I can, so we can go back
to being pylint clean in blivet.
- mulhern
9 years, 11 months
[anaconda][master][PATCH] Use the enlightbox context manager for the add network device dialog
by Martin Kolman
The old way no longer works and causes an exception to be raised.
Signed-off-by: Martin Kolman <mkolman(a)redhat.com>
---
pyanaconda/ui/gui/spokes/network.py | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/pyanaconda/ui/gui/spokes/network.py b/pyanaconda/ui/gui/spokes/network.py
index adb81e1..49cd897 100644
--- a/pyanaconda/ui/gui/spokes/network.py
+++ b/pyanaconda/ui/gui/spokes/network.py
@@ -596,9 +596,8 @@ class NetworkControlBox(GObject.GObject):
def on_add_device_clicked(self, *args):
dialog = self.builder.get_object("add_device_dialog")
- if self.spoke:
- dialog.set_transient_for(self.spoke.window)
- rc = dialog.run()
+ with self.spoke.main_window.enlightbox(dialog):
+ rc = dialog.run()
dialog.hide()
if rc == 1:
ai = self.builder.get_object("combobox_add_device").get_active_iter()
--
1.9.3
9 years, 11 months
[blivet:master 0/2] Removing udev_ prefix from udev methods patches
by Anne Mulhern
The only reason to import udev in blivet.formats.__init__.py is for the
methods that are removed in "Remove all references". Importing udev,
rather than names from udev, causes
pylint errors that cannot be dismissed with the disable= annotations.
Trying to figure out what was going on caused me to notice that these methods
should probably just go away. I still dunno what was up w/ pylint.
mulhern (2):
Remove all references to DeviceFormat.majorminor
Remove udev_ prefix from udev methods.
blivet/__init__.py | 2 +-
blivet/deviceaction.py | 10 +-
blivet/devices.py | 57 +++++----
blivet/devicetree.py | 298 ++++++++++++++++++++++----------------------
blivet/fcoe.py | 4 +-
blivet/formats/__init__.py | 44 -------
blivet/formats/disklabel.py | 4 +-
blivet/formats/fs.py | 4 +-
blivet/iscsi.py | 4 +-
blivet/udev.py | 274 ++++++++++++++++++++--------------------
blivet/zfcp.py | 8 +-
tests/devicetree_test.py | 4 +-
tests/udev_test.py | 36 +++---
13 files changed, 352 insertions(+), 397 deletions(-)
--
1.9.3
9 years, 11 months
[blivet:master 00/11] rhbz#1070095 related patches (v3)
by Anne Mulhern
I realized that I had been mistaken about somethings, and I noticed a few
other things that ought to be fixed up.
First two patches are just testing.
The next two are just documentation.
The next two are just using udev_device_get_md_*() methods according to
their spec.
The next two are a very minor bug fix and some accompanying stuff.
The final three are the bug fix.
Canoncalize... is unchanged, the rest are changed a bit.
mulhern (11):
Add test for raid level descriptor None.
Add a few small tests for mdexamine
Document udev_device_get_uuid() method.
Add documentation to udev_device_get_md_*() methods.
Do not convert the result of udev_device_get_md_devices() to int.
Check for md_level of None
Change use of METADATA to MD_METADATA.
Add a udev_device_get_md_metadata() method to udev and use it.
Canonicalize mdadm generated UUIDS (#1070095)
Add new method udev_device_get_md_device_uuid() method (#1070095)
Attempt to reset the uuid of the mdraid member device (#1070095)
blivet/devicelibs/mdraid.py | 9 ++++
blivet/devicetree.py | 24 ++++++---
blivet/udev.py | 75 ++++++++++++++++++++++++++-
tests/devicelibs_test/mdraid_test.py | 98 +++++++++++++++++++++++++++++++++++-
tests/devicelibs_test/raid_test.py | 1 +
5 files changed, 198 insertions(+), 9 deletions(-)
--
1.9.3
9 years, 11 months