[PATCH 0/4] Custom storage dialog tweaks
by David Shea
The first one is so that I can get some sensible diffs after changing things in
glade. Thanks, glade. >:-[
David Shea (4):
Opened up custom_storage_helpers.glade and hit Save
Add the disk TreeViews directly to the scrolled windows
Make the configure mount point dialog taller. (#924182)
Enable rubber-banding in the disk tree views
.../ui/gui/spokes/lib/custom_storage_helpers.glade | 927 ++++++++++-----------
1 file changed, 453 insertions(+), 474 deletions(-)
--
2.0.0
9 years, 11 months
[anaconda][master][PATCH] Improving the Anaconda CLI help - second batch
by Martin Kolman
The help texts come mostly from the boot options wiki page, with various corrections
and tweaks. I've also added an uppercase metavar for each option that takes an
argument and used the metavar in the help text.
Yet again : corrections and improvement ideas are welcome! :)
BTW, it looks like we have yet again some outdated information in the wiki page -
I've already fixed some minor details but I'd eventually like to do a more comprehensive
"correction sweep". Also some better structuring & an overview table would be nice. :)
Martin Kolman (1):
Add help texts for more Anaconda CLI options
anaconda | 53 ++++++++++++++----------
data/anaconda_options.txt | 100 ++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 133 insertions(+), 20 deletions(-)
--
1.9.3
9 years, 11 months
[blivet:master 0/8] #1090009 related patches
by Anne Mulhern
The first two are minor cleanups.
Omit special check...is a decision, I may be wrong there.
Rename devicetree_test...there was a lot more in which I tried to actually
construct some useful devicetree unit tests, but this is all that remains
(http://www.topatoco.com/merchant.mvc?Screen=PROD&Store_Code=TO&Product_Co...). It's kind of optional at this point.
Factor out commonalities...busy, but not subtle.
Remove preferLeaves...the alternative is to have them all take preferLeaves,
and factor that out into a separate method, but from the commit messages
preferLeaves seems to have been pretty ad-hoc.
The two last are simple, and address half the problem in the bug, the problem
of discovering the array even if it is missing some devices. The other half,
what to do when the array is still unusable, has yet to be addressed, but
I'm hoping for some feedback, before I go farther.
Oh, and I can't actually test this on anaconda, due to some strangeness that
is causing the udev info to be fragmentary so that the name and the uuid of
the array device are both unobtainable and so lookup does not occur at all.
I've farmed the testing out to the original reporter.
There is an accompanying anaconda patch, coming right up.
mulhern (8):
Move down or remove assignment to device in add* methods.
Remove unused 'slaves' variable.
Omit special check for md devices in addUdevDevice().
Rename devicetree_test file to something somewhat more appropriate.
Factor out commonalities among getDevice[s|]By* methods.
Remove preferLeaves parameter from getDeviceByPath()
Add a flag to control whether a raid array may be run when degraded
(#1090009)
When adding an md array, allow adding incomplete arrays (#1090009)
blivet/devicetree.py | 334 +++++++++++++++++-------------------------
blivet/flags.py | 2 +
tests/devicetree_test.py | 283 -----------------------------------
tests/devicetreestate_test.py | 283 +++++++++++++++++++++++++++++++++++
4 files changed, 416 insertions(+), 486 deletions(-)
delete mode 100644 tests/devicetree_test.py
create mode 100644 tests/devicetreestate_test.py
--
1.9.3
9 years, 11 months
[PATCH 0/2] one more viewport patch and a test
by David Shea
David Shea (2):
Add a check for GtkScrollables contained in GtkViewports
Remove the viewport from the addon repo tree view
pyanaconda/ui/gui/spokes/source.glade | 58 +++++++++++---------------
tests/glade/viewport/check_viewport.py | 76 ++++++++++++++++++++++++++++++++++
2 files changed, 101 insertions(+), 33 deletions(-)
create mode 100755 tests/glade/viewport/check_viewport.py
--
2.0.0
9 years, 11 months
[anaconda][master][PATCH] Remove the targetarch Anaconda option
by Martin Kolman
It apparently does not do anything in particular.
Signed-off-by: Martin Kolman <mkolman(a)redhat.com>
---
anaconda | 2 --
pyanaconda/flags.py | 4 ----
2 files changed, 6 deletions(-)
diff --git a/anaconda b/anaconda
index c48a995..3117395 100755
--- a/anaconda
+++ b/anaconda
@@ -275,7 +275,6 @@ def parseArguments(argv=None, boot_cmdline=None):
ap.add_argument("--ks", dest="ksfile", action="store_const", const="/run/install/ks.cfg")
ap.add_argument("--kickstart", dest="ksfile")
ap.add_argument("--rescue", dest="rescue", action="store_true", default=False)
- ap.add_argument("--targetarch", "rpmarch", dest="targetArch", type=str)
ap.add_argument("--armplatform", dest="armPlatform", type=str)
ap.add_argument("--multilib", dest="multiLib", action="store_true", default=False)
@@ -880,7 +879,6 @@ if __name__ == "__main__":
# set flags
flags.noverifyssl = opts.noverifyssl
- flags.targetarch = opts.targetArch
flags.armPlatform = opts.armPlatform
flags.extlinux = opts.extlinux
flags.dnf = opts.dnf
diff --git a/pyanaconda/flags.py b/pyanaconda/flags.py
index 1a43c59..20e3255 100644
--- a/pyanaconda/flags.py
+++ b/pyanaconda/flags.py
@@ -52,7 +52,6 @@ class Flags(object):
self.dmraid = True
self.selinux = SELINUX_DEFAULT
self.debug = False
- self.targetarch = None
self.armPlatform = None
self.preexisting_x11 = False
self.noverifyssl = False
@@ -81,9 +80,6 @@ class Flags(object):
"gpt", "dnf"):
self.set_cmdline_bool(f)
- if "rpmarch" in self.cmdline:
- self.targetarch = self.cmdline.get("rpmarch")
-
if not selinux.is_selinux_enabled():
self.selinux = 0
--
1.9.3
9 years, 11 months
[PATCH 0/2] A couple of patches for help text testing
by David Shea
David Shea (2):
Allow the location of anaconda_options.txt to be overridden
Add anaconda_options.txt to makeupdates
anaconda | 4 +++-
pyanaconda/anaconda_argparse.py | 2 --
scripts/makeupdates | 2 ++
3 files changed, 5 insertions(+), 3 deletions(-)
--
2.0.0
9 years, 11 months
[blivet:master 00/11] #1109195 related patches (v3)
by Anne Mulhern
Everything is the same except "If btrfs creation fails..."
I can only come up with three reasonable strategies for dealing with the
possibility that the specified options are causing the failure of volume
creation. These strategies are all based on the belief that the only way
of finding out what btrfs considers wrong with the options is to parse the
error output, something that really ought not to be attempted.
The first is just give up immediately, which is a good, simple strategy.
I'm happy to go with that. I thought it might be better to be more forgiving,
hence...
The second strategy is to try just once more, accepting the defaults,
which is what the first patch did. There were some objections to that patch,
hence...
The third strategy is to try out combinations of the specified options,
giving up after all have failed. That's the second and current revised patches.
This strategy could be time-consuming, but I'm betting that if mkfs.btrfs
has a problem with the specified options it will terminate quickly.
I can't think of any other strategies which don't require making dubious
and uncheckable predictions about btrfs's behavior.
mulhern (11):
Remove some extra imports.
Update BTRFS initializer comments for level type.
Explicitly accept a string as well as a RAIDLevel object.
Move skipUnless decorator to the top level class of skipped classes.
Add num_blocks parameter to makeLoopDev().
Use correct parameters in __init__() in subclasses of
unittest.TestCase.
Make DevicelibsTestCase devices configurable.
Add a test for a btrfs error associated with small devices (#1109195)
Accept None for btrfs raid levels (#1109195)
If btrfs creation fails, try with fewer specified options (#1109195)
Move DevicelibsTestCase up to the top level of the testing directory.
blivet/devicelibs/btrfs.py | 12 +++--
blivet/devices.py | 73 ++++++++++++++++---------
tests/devicelibs_test/baseclass.py | 77 --------------------------
tests/devicelibs_test/btrfs_test.py | 53 +++++++++++-------
tests/devicelibs_test/crypto_test.py | 29 +++++-----
tests/devicelibs_test/lvm_test.py | 24 ++++-----
tests/devicelibs_test/mdraid_test.py | 21 +++-----
tests/devicelibs_test/swap_test.py | 10 ++--
tests/devices_test.py | 4 --
tests/devicetree_test.py | 2 -
tests/formats_test/fslabeling.py | 46 +++++-----------
tests/formats_test/labeling_test.py | 18 ++-----
tests/formats_test/selinux_test.py | 17 +++---
tests/imagebackedtestcase.py | 1 +
tests/loopbackedtestcase.py | 102 +++++++++++++++++++++++++++++++++++
tests/partitioning_test.py | 2 -
16 files changed, 254 insertions(+), 237 deletions(-)
delete mode 100644 tests/devicelibs_test/baseclass.py
create mode 100644 tests/loopbackedtestcase.py
--
1.9.3
9 years, 11 months
[blivet:master 00/11] #1109195 related patches (v2)
by Anne Mulhern
All are mostly the same or changed according to suggestions except
If btrfs creation fails, try with fewer...
which was previously
Fall back to accepting defaults...
and which has changed considerably.
mulhern (11):
Remove some extra imports.
Update BTRFS initializer comments for level type.
Explicitly accept a string as well as a RAIDLevel object.
Move skipUnless decorator to the top level class of skipped classes.
Add num_blocks parameter to makeLoopDev().
Use correct parameters in __init__() in subclasses of
unittest.TestCase.
Make DevicelibsTestCase devices configurable.
Add a test for a btrfs error associated with small devices (#1109195)
Accept None for btrfs raid levels (#1109195)
If btrfs creation fails, try with fewer specified options (#1109195)
Move DevicelibsTestCase up to the top level of the testing directory.
blivet/devicelibs/btrfs.py | 12 +++--
blivet/devices.py | 61 ++++++++++++---------
tests/devicelibs_test/baseclass.py | 77 --------------------------
tests/devicelibs_test/btrfs_test.py | 53 +++++++++++-------
tests/devicelibs_test/crypto_test.py | 29 +++++-----
tests/devicelibs_test/lvm_test.py | 24 ++++-----
tests/devicelibs_test/mdraid_test.py | 21 +++-----
tests/devicelibs_test/swap_test.py | 10 ++--
tests/devices_test.py | 4 --
tests/devicetree_test.py | 2 -
tests/formats_test/fslabeling.py | 46 +++++-----------
tests/formats_test/labeling_test.py | 18 ++-----
tests/formats_test/selinux_test.py | 17 +++---
tests/imagebackedtestcase.py | 1 +
tests/loopbackedtestcase.py | 102 +++++++++++++++++++++++++++++++++++
tests/partitioning_test.py | 2 -
16 files changed, 242 insertions(+), 237 deletions(-)
delete mode 100644 tests/devicelibs_test/baseclass.py
create mode 100644 tests/loopbackedtestcase.py
--
1.9.3
9 years, 11 months
[lorax] Keep virtio_console harder.
by David Shea
Kernel modules in F21 are compressed, so sometimes the file we want to
keep is virtio_console.ko.xz
---
share/runtime-cleanup.tmpl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/share/runtime-cleanup.tmpl b/share/runtime-cleanup.tmpl
index 3cc1c20..c7d345e 100644
--- a/share/runtime-cleanup.tmpl
+++ b/share/runtime-cleanup.tmpl
@@ -92,7 +92,7 @@ arch/x86/kvm
%endfor
remove lib/modules/*/{build,source,*.map}
## Need to keep virtio_console.ko in drivers/char
-runcmd chroot ${root} find /lib/modules -regex ".*/kernel/drivers/char/.*" \! -name virtio_console.ko -delete
+runcmd chroot ${root} find /lib/modules -regex ".*/kernel/drivers/char/.*" \! -name virtio_console.ko\* -delete
## NOTE: depmod gets re-run after cleanup finishes
## remove unused themes, theme engines, icons, etc.
--
2.0.0
9 years, 11 months
[PATCHES 0/3] clearpart --disklabel=gpt support
by Brian C. Lane
This set touches pykickstart, blivet and anaconda to add a new switch to
clearpart (yeah, I know). This is the cleanest way to do this. I had originally
wanted to add parameters to --initlabel but that would have required surgery on
the older classes in pykickstart and been a bit of a mess.
With these changes you don't need to add gpt to the kernel cmdline, you can
pass clearpart --initlabel --disklabel=gpt in the kickstart and it will set gpt
as the default disklabel. If a specified disklabel isn't supported on the
current platform it will raise a KickstartValueError when anaconda parses the
kickstart before showing the GUI.
9 years, 11 months