[master] Moving code outside the _save_right_side method
by Vratislav Podzimek
Vratislav Podzimek (4):
Make the code changing an existing device more compact
Refactor code for reverting device reformat into a function
Refactor out the code for bounding size into a function
Refactor out the code for handling device size change into a function
pyanaconda/ui/gui/spokes/custom.py | 139 +++++++++++++++++++------------------
1 file changed, 72 insertions(+), 67 deletions(-)
--
1.9.0
10 years, 1 month
[master][PATCH] Use dir_tree_map for the cleanPStore function
by Vratislav Podzimek
Signed-off-by: Vratislav Podzimek <vpodzime(a)redhat.com>
---
anaconda | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/anaconda b/anaconda
index 88a3690..983135f 100755
--- a/anaconda
+++ b/anaconda
@@ -740,12 +740,8 @@ def cleanPStore():
# is sufficient free space on the flash part. On some machines this will
# take effect immediately, which is the best case. Unfortunately on some,
# an intervening reboot is needed."""
- try:
- for root, _dirs, files in os.walk("/sys/fs/pstore"):
- for f in files:
- os.unlink("%s/%s" % (root,f))
- except OSError:
- pass
+ from pyanaconda.iutil import dir_tree_map
+ dir_tree_map(os.unlink, files=True, dirs=False)
if __name__ == "__main__":
print "Starting installer, one moment..."
--
1.9.0
10 years, 1 month
[PATCH 0/6] Add filesystem image and tarfile creation to livemedia-creator
by Brian C. Lane
--make-fsimage was only working with --no-virt mode, this adds support for it
to virt-install mode as well which makes it easier to use with different
releases than the host system.
With the addition of the kickstart liveimg tarfile support and all the talk of
docker, lxc, etc. having a tarfile of the root filesystem is also useful, so
this also adds support for that in both virt-install and no-virt modes.
Brian C. Lane (6):
livemedia-creator: Make --make-fsimage work with virt-install
livemedia-creator: Update documentation to reflect new options
livemedia-creator: Output all the errors at once
livemedia-creator: Check fsimage kickstart for single partition
livemedia-creator: Allow disk sizes to be < 1GiB
livemedia-creator: Add support for making tarfiles
README.livemedia-creator | 34 ++++++-
docs/livemedia-creator.1 | 37 +++++++-
src/pylorax/imgutils.py | 49 +++++++---
src/sbin/livemedia-creator | 228 +++++++++++++++++++++++++++++----------------
4 files changed, 247 insertions(+), 101 deletions(-)
--
1.9.0
10 years, 1 month
Extracted patches for users.py
by Colin Walters
Tested these by doing a traditional rawhide install.
[PATCH 1/2] users: Deduplicate code to fork()+chroot()
This is in preparation for a patch to do it for the password setting,
which blew up in the OSTree patchset. I'm not sure why this
apparently isn't broken in the traditional path.
---
pyanaconda/users.py | 101
+++++++++++++++++++++-------------------------------
1 file changed, 40 insertions(+), 61 deletions(-)
[PATCH 2/2] users: Add root= keyword argument to
set{User,Root}Password
I'm honestly not sure why this isn't broken with the current install
path. Every other method has the fork()/chroot() dance around it, so
we should do it here too.
---
pyanaconda/users.py | 29 +++++++++++++++++------------
1 file changed, 17 insertions(+), 12 deletions(-)
10 years, 1 month
[PATCH rhel7-branch] network: adapt to NM fixing virtual device disconnection (#1084953)
by Radek Vykydal
NM fixed handling of disconnected virtual devices in bug #1078720
so the device-removed event is emited correctly and the device is
in DISCONNECTED state now. We need to handle this state.
Resolves: rhbz#1084953
---
pyanaconda/ui/gui/spokes/network.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pyanaconda/ui/gui/spokes/network.py b/pyanaconda/ui/gui/spokes/network.py
index d5e85a7..665cfcf 100644
--- a/pyanaconda/ui/gui/spokes/network.py
+++ b/pyanaconda/ui/gui/spokes/network.py
@@ -100,7 +100,7 @@ def localized_string_of_device_state(device, state):
else:
str = _("Unavailable")
elif state == NetworkManager.DeviceState.DISCONNECTED:
- if (device.get_device_type() == NetworkManager.DeviceType.ETHERNET
+ if (device and device.get_device_type() == NetworkManager.DeviceType.ETHERNET
and not device.get_carrier()):
str = _("Cable unplugged")
else:
--
1.7.11.7
10 years, 1 month
[master] Another set of little tweaks for the Custom spoke
by Vratislav Podzimek
Fixing things that looked weird to me.
Vratislav Podzimek (5):
Don't overload selectorFromDevice function
Refactor mountpoint configuration validation out from _save_right_side
Remove and unused variable in Custom spoke
Use generator instead of list for auxiliary old_disk_names variable
Make size properties refreshing reused code
pyanaconda/ui/gui/spokes/custom.py | 89 ++++++++++++++++---------------
pyanaconda/ui/gui/spokes/lib/accordion.py | 25 ++++-----
2 files changed, 60 insertions(+), 54 deletions(-)
--
1.9.0
10 years, 1 month
[anaconda/blivet] make the generic exception handler actually generic
by David Shea
Using the cb method in errorHandler was something of a gamble re: required
arguments, unless you knew exactly which exception handler would be called,
which made it kind of pointless to have a generic frontend for them. This fixes
that, and also changes the yum/dnf required package handling so that it displays
a fatal error instead of throwing a fatal exception.
There's also a blivet change for the spots where it used the anaconda error handler.
David Shea (2):
Fix issues with the errorHandler callback arguments
Display a message for missing required packages and groups (#1064565)
anaconda.spec.in | 2 +-
pyanaconda/errors.py | 143 +++++++++++++++++--------------------
pyanaconda/image.py | 10 +--
pyanaconda/kickstart.py | 2 +-
pyanaconda/packaging/__init__.py | 11 ++-
pyanaconda/packaging/dnfpayload.py | 18 +++--
pyanaconda/packaging/yumpayload.py | 32 ++++-----
7 files changed, 108 insertions(+), 110 deletions(-)
--
1.9.0
10 years, 1 month
[master] Only block the password/user spokes if data was given in kickstart
by Vratislav Podzimek
If a kickstart file without rootpw/user commands is used and root password or
user data is entered in the UI we don't want to block the spokes.
Signed-off-by: Vratislav Podzimek <vpodzime(a)redhat.com>
---
pyanaconda/ui/gui/spokes/password.py | 3 ++-
pyanaconda/ui/gui/spokes/user.py | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/pyanaconda/ui/gui/spokes/password.py b/pyanaconda/ui/gui/spokes/password.py
index bedefb5..50d0136 100644
--- a/pyanaconda/ui/gui/spokes/password.py
+++ b/pyanaconda/ui/gui/spokes/password.py
@@ -145,7 +145,8 @@ class PasswordSpoke(FirstbootSpokeMixIn, NormalSpoke, GUISpokeInputCheckHandler)
@property
def sensitive(self):
- return not (self.completed and flags.automatedInstall)
+ return not (self.completed and flags.automatedInstall
+ and self.data.rootpw.seen)
def _checkPasswordEmpty(self, inputcheck):
"""Check whether a password has been specified at all."""
diff --git a/pyanaconda/ui/gui/spokes/user.py b/pyanaconda/ui/gui/spokes/user.py
index 9cfcfa2..62f6024 100644
--- a/pyanaconda/ui/gui/spokes/user.py
+++ b/pyanaconda/ui/gui/spokes/user.py
@@ -398,7 +398,8 @@ class UserSpoke(FirstbootSpokeMixIn, NormalSpoke, GUISpokeInputCheckHandler):
@property
def sensitive(self):
- return not (self.completed and flags.automatedInstall)
+ return not (self.completed and flags.automatedInstall
+ and self.data.user.seen)
@property
def completed(self):
--
1.9.0
10 years, 1 month
[master] Some more changes for the custom spoke
by Vratislav Podzimek
Vratislav Podzimek (5):
LVM Thin Provisioning supports the same RAID levels as plain LVM
No RAID level (RAID level None) is a valid choice for LVM(ThP)
Use cannonical RAID level names when populating RAID stores
Uppercase global constants in the Custom spoke
Have mountpoint descriptions defined in a dictionary
pyanaconda/storage_utils.py | 2 +
pyanaconda/ui/gui/spokes/custom.py | 79 ++++++++++------------
.../ui/gui/spokes/lib/custom_storage_helpers.py | 13 ++--
3 files changed, 46 insertions(+), 48 deletions(-)
--
1.9.0
10 years, 1 month