[blivet:rhel7/master 0/3] Fix up remaining tests that must be run as root (v3)
by Anne Mulhern
Make crypt tests runnable, Make lvm tests runnable --- the same except for
comments.
Teardown RAID device --- the same.
Previous patch about lvm version is gone.
mulhern (3):
Make crypt tests runnable.
Make lvm tests runnable.
Teardown RAID device once testing is over
tests/devicelibs_test/crypto_test.py | 159 ++++++++++++++++++++++++++---------
tests/devicelibs_test/lvm_test.py | 151 +++++++++++++++++++++------------
tests/devicelibs_test/mdraid_test.py | 21 ++++-
3 files changed, 234 insertions(+), 97 deletions(-)
--
1.8.3.1
10 years, 1 month
[master][PATCH] Pass Size(0) instead of 0 to the ContainerDialog if no size is given
by Vratislav Podzimek
Signed-off-by: Vratislav Podzimek <vpodzime(a)redhat.com>
---
pyanaconda/ui/gui/spokes/custom.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pyanaconda/ui/gui/spokes/custom.py b/pyanaconda/ui/gui/spokes/custom.py
index 42ec171..4187c5c 100644
--- a/pyanaconda/ui/gui/spokes/custom.py
+++ b/pyanaconda/ui/gui/spokes/custom.py
@@ -1854,7 +1854,7 @@ class CustomPartitioningSpoke(NormalSpoke, StorageChecker):
self._populate_raid(selectedRaidLevel(self._raidLevelCombo))
def run_container_editor(self, container=None, name=None):
- size = 0
+ size = Size(0)
size_policy = self._device_container_size
if container:
container_name = container.name
--
1.8.5.3
10 years, 1 month
[master][PATCH] Use an alternative image if logo is missing
by Martin Kolman
Currently the /usr/share/anaconda/pixmaps/logo.png image is missing and
this results in GTK continuously spamming TTY1 with errors.
This patch makes Anaconda check if the logo image is there during GUI startup.
If the logo is missing, an alternative image will be used.
By default it will use the Anaconda fedora header image:
http://m4rtink.fedorapeople.org/anaconda/screenshots/logo/anaconda_logo_a...
If this image is also not available (it comes from fedora-logos which
I guess might not be always installed), it will use a sad smiley icon from GTK:
http://m4rtink.fedorapeople.org/anaconda/screenshots/logo/anaconda_logo_s...
The sad smiley icon should always be there as the Anaconda GUI uses various
other GTK icons so the corresponding package should be always installed.
The say smiley icon might also work like a good motivation for people to fix their
installation composes.
Martin Kolman (1):
Use an alternative image if logo is missing
anaconda | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
--
1.8.5.3
10 years, 1 month
[PATCH] Run the pykickstart version test on the commands in parse-dracut
by David Shea
---
tests/kickstart_tests/version_test.py | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/tests/kickstart_tests/version_test.py b/tests/kickstart_tests/version_test.py
index c3650f8..4816547 100644
--- a/tests/kickstart_tests/version_test.py
+++ b/tests/kickstart_tests/version_test.py
@@ -18,6 +18,7 @@
# Author: Chris Lumens <clumens(a)redhat.com>
from mock import Mock
import unittest
+import os
class BaseTestCase(unittest.TestCase):
def setUp(self):
@@ -50,3 +51,21 @@ class DataVersionTestCase(BaseTestCase):
# it does command objects.
pykickstartClass = eval("self.handler.%s" % dataName)
self.assertIsInstance(dataObj(), pykickstartClass)
+
+# Copy the commands tests but with the command map from dracut/parse-kickstart
+class DracutCommandVersionTestCase(CommandVersionTestCase):
+ def setUp(self):
+ CommandVersionTestCase.setUp(self)
+
+ # top_srcdir should have been set by nosetests.sh. If it wasn't, the KeyError
+ # will fail the test.
+ parse_kickstart_path = os.path.join(os.environ['top_srcdir'], 'dracut', 'parse-kickstart')
+
+ # Use imp to pretend that hyphens are ok for module names
+ import imp
+
+ with open(parse_kickstart_path) as parse_kickstart_file:
+ parse_module = imp.load_module('parse_kickstart', parse_kickstart_file,
+ parse_kickstart_path, ('', 'r', imp.PY_SOURCE))
+
+ self._commandMap = parse_module.dracutCmds
--
1.9.0
10 years, 1 month
[blivet:master 0/3] Suppressing some unused variable warnings
by Anne Mulhern
By prepending the unused variable names with an underscore.
We only do this if we believe that the variables are legitimately unused.
It's better than adding a pylint ignore annotation because it is much
more specific and easier to read.
mulhern (3):
Suppress some unused variable warnings
Suppress some unused variable warnings.
Suppress unused variable warnings for index in range
blivet/__init__.py | 13 +++++++------
blivet/devices.py | 11 +++++++----
blivet/devicetree.py | 3 ++-
blivet/fcoe.py | 2 +-
blivet/formats/fs.py | 2 +-
blivet/iscsi.py | 2 +-
blivet/tsort.py | 2 +-
blivet/util.py | 4 ++--
examples/common.py | 4 ++--
scripts/makeupdates | 2 +-
tests/devicelibs_test/baseclass.py | 2 +-
tests/devicelibs_test/lvm_test.py | 2 +-
tests/formats_test/labeling_test.py | 12 ++++++------
13 files changed, 33 insertions(+), 28 deletions(-)
--
1.8.3.1
10 years, 1 month
[master][PATCH] Don't do yum lock logging when using updates.img
by Vratislav Podzimek
The commit d42a7caa turned on debug logging when using updates.img. However,
that also turns on yum lock logging which is kind of a flood for the
packaging.log and which prolongs anaconda-tb file generation a lot. We only want
to do yum lock logging when inst.debug is used.
Signed-off-by: Vratislav Podzimek <vpodzime(a)redhat.com>
---
anaconda | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/anaconda b/anaconda
index 7e84cf5..26f0d3a 100755
--- a/anaconda
+++ b/anaconda
@@ -375,19 +375,23 @@ def setupEnvironment():
del os.environ["LD_PRELOAD"]
def setupLoggingFromOpts(options):
+ want_yum_lock_logs = False
if options.debug or options.updateSrc:
# debugging means debug logging
options.loglevel = "debug"
+ want_yum_lock_logs = options.debug
if options.loglevel and anaconda_log.logLevelMap.has_key(options.loglevel):
level = anaconda_log.logLevelMap[opts.loglevel]
anaconda_log.logger.tty_loglevel = level
anaconda_log.setHandlersLevel(log, level)
- packaging_log = logging.getLogger("packaging")
- anaconda_log.setHandlersLevel(packaging_log, level)
storage_log = logging.getLogger("storage")
anaconda_log.setHandlersLevel(storage_log, level)
+ if options.loglevel != "debug" or want_yum_lock_logs:
+ packaging_log = logging.getLogger("packaging")
+ anaconda_log.setHandlersLevel(packaging_log, level)
+
if options.syslog:
anaconda_log.logger.updateRemote(options.syslog)
--
1.8.5.3
10 years, 1 month
[PATCH] Use BOOTAA64.efi for AARCH64 bootloader filename (#1080113)
by Brian C. Lane
Need to stay withing the FAT filename 8.3 limits
Resolves: rhbz#1080113
---
share/efi.tmpl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/share/efi.tmpl b/share/efi.tmpl
index d38416d..6e0c600 100644
--- a/share/efi.tmpl
+++ b/share/efi.tmpl
@@ -8,7 +8,7 @@ APPLE_EFI_DISKNAME=inroot+"/usr/share/pixmaps/bootloader/fedora-media.vol"
mkdir ${EFIBOOTDIR}
mkdir ${EFIBOOTDIR}/fonts/
%if efiarch == 'AARCH64':
-install boot/efi/EFI/*/grubaa64.efi ${EFIBOOTDIR}/BOOT${efiarch}.efi
+install boot/efi/EFI/*/grubaa64.efi ${EFIBOOTDIR}/BOOTAA64.efi
install boot/efi/EFI/*/grubaa64.efi ${EFIBOOTDIR}/grubaa64.efi
%else:
install boot/efi/EFI/*/shim.efi ${EFIBOOTDIR}/BOOT${efiarch}.efi
--
1.8.5.3
10 years, 1 month
[blivet] support for container member set management
by David Lehman
This adds the ability to add/remove members from a volume group,
md array, or btrfs volume. It adds a ContainerDevice class to
provide the interfaces.
This isn't expected to impact anaconda at all.
blivet/deviceaction.py | 198 +++++++++++++--
blivet/devicefactory.py | 26 +-
blivet/devicelibs/btrfs.py | 14 +-
blivet/devicelibs/lvm.py | 57 ++++-
blivet/devicelibs/mdraid.py | 61 ++++-
blivet/devices.py | 592 +++++++++++++++++++++++---------------------
blivet/devicetree.py | 21 +-
blivet/formats/fs.py | 4 +-
tests/action_test.py | 122 +++++++++
tests/devices_test.py | 88 ++++---
10 files changed, 816 insertions(+), 367 deletions(-)
10 years, 1 month
[blivet:rhel7/master 0/4] Fix up remaining tests that must be run as root (v2)
by Anne Mulhern
Make crypt tests runnable...no change.
Make lvm test runnable...only change is to catch up with changes to vginfo.
Teardown RAID device...totally new replaces Remove action_test.py
Skip lvm test case...I don't think its worth the trouble to do anything fancier,
but if anybody has suggestions...
lvm2 nowadays comes with some sort of actual python bindings, it might be worth
looking into that.
mulhern (4):
Make crypt tests runnable.
Make lvm tests runnable.
Teardown RAID device once testing is over
Skip lvm test case with an informative message
tests/devicelibs_test/crypto_test.py | 140 ++++++++++++++++++++++++----------
tests/devicelibs_test/lvm_test.py | 144 ++++++++++++++++++++++-------------
tests/devicelibs_test/mdraid_test.py | 21 ++++-
3 files changed, 208 insertions(+), 97 deletions(-)
--
1.8.3.1
10 years, 1 month
[rhel7/master] Check boot args for None (#1075918)
by Brian C. Lane
When there are multiple boot args, some may be empty, like inst.dd, so
check the new value and the previous value to make sure they are not
None.
Related: rhbz#1073130
Resolves: rhbz#1075918
---
pyanaconda/flags.py | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/pyanaconda/flags.py b/pyanaconda/flags.py
index 1435311..cbba624 100644
--- a/pyanaconda/flags.py
+++ b/pyanaconda/flags.py
@@ -167,8 +167,9 @@ class BootArgs(OrderedDict):
val = None
# Duplicate args create a space separated string
- if key in self:
- self[key] = self[key] + " " + val
+ if self.get(key, None):
+ if val:
+ self[key] = self[key] + " " + val
else:
self[key] = val
--
1.8.5.3
10 years, 1 month