[anaconda][f21-branch/master][PATCH] Add missing python-lxml BuildRequires
by Martin Kolman
Needed for generating the help content files.
Signed-off-by: Martin Kolman <mkolman(a)redhat.com>
---
anaconda.spec.in | 2 ++
1 file changed, 2 insertions(+)
diff --git a/anaconda.spec.in b/anaconda.spec.in
index 687bea2..6f6f102 100644
--- a/anaconda.spec.in
+++ b/anaconda.spec.in
@@ -73,6 +73,8 @@ BuildRequires: dbus-devel >= %{dbusver}
BuildRequires: dbus-python
BuildRequires: rpm-devel >= %{rpmver}
BuildRequires: libarchive-devel >= %{libarchivever}
+# required for help content generation
+BuildRequires: python-lxml
%ifarch %livearches
BuildRequires: desktop-file-utils
%endif
--
1.9.3
9 years, 5 months
[anaconda][rhel7-branch][PATCH] Add a subpackage for the help content
by Martin Kolman
To get some help content versioning and to prepare the ground for having a separate
help content package in the future, add a subpackage for holding the help content files.
The subpackage has its own version to ease the eventual future transition to a standalone package
- could that be an issue for some of the compose tools are dependency solvers ?
Also a note about the interesting way how RPM handles version definition in spec files:
It is defined by the Version: keyword and subpackages can use it to define a separate version from
the main package one. To work with the version value the %{version} macro can be used,
*however* once the subpackage uses the Version: keyword to set its version, the %{version}
macro no longer points to the main package version but to the subpackage one.
This behavior is quite unfortunate as sub package definitions are above the %prep, %build
and %install sections, meaning every usage of the %{version} in these section macro will return the
subpackage version, even if you want to get the version of the main package. And even using %define *above*
the subpackage definition to remember the main package version does not work, as all macros are apparently
expanded only once used.
So as I have not been able to find a better way, I've just hacked around it by using the #VERSION# special variable
that gets substituted for the actual version by the makefile and should thus be exempt from the above described
%{version} handling madness.
Any suggestion how to solve this in a nicer way will be appreciated! :)
Martin Kolman (1):
Add help content subpackage (#1072033)
anaconda.spec.in | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
--
1.9.3
9 years, 5 months
[PATCH 0/2] Handle unstaged changes in the pre-commit hook
by David Shea
Now you can use commit --interactive and pylint at the same time.
David Shea (2):
Use git status -z
Handle unstaged changes in the pre-commit hook.
scripts/githooks/pre-commit | 39 ++++++++++++++++++++++++++-------------
1 file changed, 26 insertions(+), 13 deletions(-)
--
2.1.0
9 years, 5 months
[blivet-f21/master] Run dosfsck in non-interactive mode (#1167959)
by Brian C. Lane
(cherry picked from commit 6edc21acd9b50fa3eeeb6031838ffc7e1d4c754a)
---
blivet/formats/fs.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/blivet/formats/fs.py b/blivet/formats/fs.py
index 33a2489..2dc08d6 100644
--- a/blivet/formats/fs.py
+++ b/blivet/formats/fs.py
@@ -1100,6 +1100,7 @@ class FATFS(FS):
_maxSize = Size("1 TiB")
_packages = [ "dosfstools" ]
_defaultMountOptions = ["umask=0077", "shortname=winnt"]
+ _defaultCheckOptions = ["-n"]
# FIXME this should be fat32 in some cases
partedSystem = fileSystemType["fat16"]
--
1.9.3
9 years, 5 months
[PATCH] datetime_spoke: Fix warnings about removing nonexistent source
by Colin Walters
First, we missed setting the variable to None in one place for the
update source.
Second, when the "start updating" source returns False, we need to set
the corresponding variable to None as well in the source itself to
preserve the invariant that the ID is non-None if and only if the
source is outstanding.
---
pyanaconda/ui/gui/spokes/datetime_spoke.py | 3 +++
1 file changed, 3 insertions(+)
9 years, 5 months
[PATCH 1/2] Actually fix the message dropping commit.
by Chris Lumens
What's stored in self.spokes is not the name of the spoke, but the name of the
spoke class. Compare that.
---
pyanaconda/ui/gui/hubs/__init__.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pyanaconda/ui/gui/hubs/__init__.py b/pyanaconda/ui/gui/hubs/__init__.py
index de454ee..1242587 100644
--- a/pyanaconda/ui/gui/hubs/__init__.py
+++ b/pyanaconda/ui/gui/hubs/__init__.py
@@ -260,7 +260,7 @@ class Hub(GUIObject, common.Hub):
# The first argument to all codes is the name of the spoke we are
# acting on. If no such spoke exists, throw the message away.
spoke = self._spokes.get(args[0], None)
- if not spoke or spoke.title not in self._spokes:
+ if not spoke or spoke.__class__.__name__ not in self._spokes:
q.task_done()
continue
--
1.9.3
9 years, 5 months
[master] Make sure storage info bar is displayed (#1166730)
by Brian C. Lane
---
pyanaconda/ui/gui/spokes/storage.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/pyanaconda/ui/gui/spokes/storage.py b/pyanaconda/ui/gui/spokes/storage.py
index a1fadc8..cd0b05f 100644
--- a/pyanaconda/ui/gui/spokes/storage.py
+++ b/pyanaconda/ui/gui/spokes/storage.py
@@ -512,6 +512,7 @@ class StorageSpoke(NormalSpoke, StorageChecker):
self.set_warning(_("Error checking storage configuration. Click for details."))
elif self.warnings:
self.set_warning(_("Warning checking storage configuration. Click for details."))
+ self.window.show_all()
def initialize(self):
NormalSpoke.initialize(self)
--
1.9.3
9 years, 5 months
[blivet:master 0/2] Add a new pylint checker (v3)
by Anne Mulhern
The changes from v1 are:
* Fixed a bug in the checker where it would give false positive in case
where there is an overridden value that is not a literal. There were no
instances where this was occurring in the code, so it was not an obvious
problem.
* Commented the checker analysis more heavily to document its restrictions.
* Added an additional checker in the same vein that detects a tiny subset of
pointless function overrides.
* Removed the (1) pointless function override that the new checker found
(in second patch).
The only change from (v2) is that it is a lot tidied up and some
uniformities taken care of. An identical set of statements is removed in
patch (2).
mulhern (2):
Add a simple pylint checker for pointless overrides.
Remove pointless overrides.
blivet/formats/biosboot.py | 1 -
blivet/formats/disklabel.py | 1 -
blivet/formats/dmraid.py | 3 -
blivet/formats/fs.py | 10 --
blivet/formats/luks.py | 1 -
blivet/formats/multipath.py | 3 -
blivet/formats/prepboot.py | 1 -
tests/formats_test/init_test.py | 3 -
tests/pylint/pointless-override.py | 252 +++++++++++++++++++++++++++++++++++++
tests/pylint/pylint-one.sh | 2 +-
10 files changed, 253 insertions(+), 24 deletions(-)
create mode 100644 tests/pylint/pointless-override.py
--
1.9.3
9 years, 5 months
[master] Don't set iSCSI initiator entry sensitivity to False.
by Samantha N. Bueno
If a user ever adds another iscsi device or has to correct a typo in
the initiator name entry, they won't be able to since its sensitivity
always gets set to False after initially setting the entry text.
---
pyanaconda/ui/gui/spokes/advstorage/iscsi.py | 1 -
1 file changed, 1 deletion(-)
diff --git a/pyanaconda/ui/gui/spokes/advstorage/iscsi.py b/pyanaconda/ui/gui/spokes/advstorage/iscsi.py
index d3dbc2a..89239d3 100644
--- a/pyanaconda/ui/gui/spokes/advstorage/iscsi.py
+++ b/pyanaconda/ui/gui/spokes/advstorage/iscsi.py
@@ -155,7 +155,6 @@ class ISCSIDialog(GUIObject):
self._storeFilter.set_visible_column(1)
self._initiatorEntry.set_text(self.iscsi.initiator)
- self._initiatorEntry.set_sensitive(not self.iscsi.initiatorSet)
@property
def selectedNames(self):
--
1.9.3
9 years, 5 months