[PATCH] Highlight done buttons via 'suggested-action' style class (#1045250)
by Máirín Duffy
Call more attention to the 'Done' buttons in the upper left of spoke
windows by adding the 'suggested-action' button style class to those
buttons. The effect will be buttons with a blue background. This
should help draw more attention to the buttons for users who have
a hard time finding them. Reference to GNOME docs on usage of this
button style are here: https://wiki.gnome.org/HowDoI/Buttons
---
widgets/src/SpokeWindow.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/widgets/src/SpokeWindow.c b/widgets/src/SpokeWindow.c
index 6b87785..ef2b927 100644
--- a/widgets/src/SpokeWindow.c
+++ b/widgets/src/SpokeWindow.c
@@ -121,7 +121,11 @@ static void anaconda_spoke_window_init(AnacondaSpokeWindow *win) {
gtk_widget_set_vexpand(win->priv->button, FALSE);
gtk_widget_set_valign(win->priv->button, GTK_ALIGN_END);
gtk_widget_set_margin_bottom(win->priv->button, 6);
-
+
+ /* Set 'Done' button to blue 'suggested-action' style class */
+ GtkStyleContext *context = gtk_widget_get_style_context(win->priv->button);
+ gtk_style_context_add_class(context, "suggested-action");
+
/* Hook up some signals for that button. The signal handlers here will
* just raise our own custom signals for the whole window.
*/
--
1.8.4.2
10 years, 4 months
[PATCH] Ignore the compile script
by David Shea
Autoconf added a new thing that we don't care about.
---
.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/.gitignore b/.gitignore
index 079e463..6d84d21 100644
--- a/.gitignore
+++ b/.gitignore
@@ -23,6 +23,7 @@ anaconda*.tar.bz2
anaconda*.tar.gz
anaconda.spec
autom4te.cache
+compile
config.guess
config.h
config.h.in
--
1.8.5.2
10 years, 4 months
[PATCH 1/4] Remove _transactionErrors from yumpayload.py.
by Chris Lumens
It was apparently unused.
---
pyanaconda/packaging/yumpayload.py | 23 -----------------------
1 file changed, 23 deletions(-)
diff --git a/pyanaconda/packaging/yumpayload.py b/pyanaconda/packaging/yumpayload.py
index cbd9352..5083bbe 100644
--- a/pyanaconda/packaging/yumpayload.py
+++ b/pyanaconda/packaging/yumpayload.py
@@ -1389,29 +1389,6 @@ reposdir=%s
else:
rpm.addMacro("__file_context_path", "%{nil}")
- def _transactionErrors(self, errors):
- spaceNeeded = {}
- retval = ""
-
- # RPM can give us a bunch of potential errors, but we really only
- # care about a handful.
- for (descr, (ty, mount, need)) in errors:
- log.error(descr)
-
- if ty == rpm.RPMPROB_DISKSPACE:
- spaceNeeded[mount] = need
-
- # Now that we've found the ones we are interested in, create an
- # error string to match.
- if spaceNeeded:
- retval += _("You need more space on the following "
- "file systems:\n")
-
- for (mount, need) in spaceNeeded.items():
- retval += "%s on %s\n" % (Size(need), mount)
-
- return retval
-
def install(self):
""" Install the payload.
--
1.8.3.1
10 years, 4 months
[PATCH rhel7-branch] network GUI: don't crash when wifi is activated in standalone spoke (#1046138)
by Radek Vykydal
Resolves: rhbz#1046138
These connections are handled is scope of respective wireless device
configuration (device treeview item) in the spoke (active ap connection is used
when applying to ksdata).
---
pyanaconda/ui/gui/spokes/network.py | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/pyanaconda/ui/gui/spokes/network.py b/pyanaconda/ui/gui/spokes/network.py
index 6a59b02..0c9dfdc 100644
--- a/pyanaconda/ui/gui/spokes/network.py
+++ b/pyanaconda/ui/gui/spokes/network.py
@@ -435,6 +435,10 @@ class NetworkControlBox(GObject.GObject):
# this must be some slave.
if dev_cfg.device_type == NetworkManager.DeviceType.ETHERNET:
continue
+ # Wireless settings are handled in scope of its device's dev_cfg
+ if dev_cfg.device_type == NetworkManager.DeviceType.WIFI:
+ continue
+ # Virtual device settings (bond, team, vlan, ...)
self.add_dev_cfg(dev_cfg)
# select the first device
--
1.7.11.7
10 years, 4 months
[PATCH rhel7-branch] network GUI: fix typo making device adding fail silently (#1047799)
by Radek Vykydal
Resolves: rhbz#1047799
---
pyanaconda/ui/gui/spokes/network.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pyanaconda/ui/gui/spokes/network.py b/pyanaconda/ui/gui/spokes/network.py
index 1798fce..6a59b02 100644
--- a/pyanaconda/ui/gui/spokes/network.py
+++ b/pyanaconda/ui/gui/spokes/network.py
@@ -619,7 +619,7 @@ class NetworkControlBox(GObject.GObject):
def add_device(self, ty):
log.info("network: adding device of type %s" % ty)
self.kill_nmce(msg="Add device button clicked")
- proc = subprocess.Popen(["nm-connection-editor", "--create", "--ty=%s" % ty])
+ proc = subprocess.Popen(["nm-connection-editor", "--create", "--type=%s" % ty])
self._running_nmce = proc
GLib.child_watch_add(proc.pid, self.on_nmce_adding_exited)
--
1.7.11.7
10 years, 4 months
[PATCH rhel7-branch] network GUI: Fix porting thinko in log msg causing traceback on Configure (#1047941)
by Radek Vykydal
Resolves: rhbz#1047941
---
pyanaconda/ui/gui/spokes/network.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pyanaconda/ui/gui/spokes/network.py b/pyanaconda/ui/gui/spokes/network.py
index 1dbec82..1798fce 100644
--- a/pyanaconda/ui/gui/spokes/network.py
+++ b/pyanaconda/ui/gui/spokes/network.py
@@ -528,7 +528,7 @@ class NetworkControlBox(GObject.GObject):
return
log.info("network: configuring connection %s device %s ssid %s" %
- uuid, devname, self.selected_ssid)
+ (uuid, devname, self.selected_ssid))
self.kill_nmce(msg="Configure button clicked")
proc = subprocess.Popen(["nm-connection-editor", "--edit", "%s" % uuid])
self._running_nmce = proc
--
1.7.11.7
10 years, 4 months
[blivet:rhel7/master 0/2] All about DeviceFormats
by Anne Mulhern
I keep coming back w/ this patch because there's a frequent problem where some
error like:
AttributeError: 'DeviceFormat' object has no attribute X
is encountered.
These patches don't fix any of these problems but will, I believe, make them
all slightly easier to address.
mulhern (2):
A few simple unit tests for some formats methods (#1043763)
Make get_device_format_class return None if class not found (#1043763)
blivet/__init__.py | 3 ++-
blivet/formats/__init__.py | 26 ++++++++++++--------------
tests/formats_test/__init__.py | 0
tests/formats_test/init_test.py | 35 +++++++++++++++++++++++++++++++++++
4 files changed, 49 insertions(+), 15 deletions(-)
create mode 100644 tests/formats_test/__init__.py
create mode 100644 tests/formats_test/init_test.py
--
1.8.3.1
10 years, 4 months
[blivet:rhel7/master 0/3] The title of the first patch says it all
by Anne Mulhern
I sent out a patch set previously for this. I'm not including the first patch
from that set
which was just a bunch of tests, because it hasn't changed at all.
The first patch from this set merges a bunch of patches from the previous set
because it got more ambitious and it was pointless to keep the changes separate.
The second patch is very small, and I hope non-controversial.
The third should be non-controversial as well, it's more tests.
All test pass on both rhel7 and master.
mulhern (3):
Changes to the handling of filesystem labeling (#1038590)
Remove fsConfigFromFile (#1038590)
More tests to check writing and reading labels (#1038590)
blivet/formats/fs.py | 167 +++++++++++++++++--------------
blivet/formats/fslabel.py | 216 ++++++++++++++++++++++++++++++++++++++++
tests/formats_test/misc_test.py | 157 +++++++++++++++++++++++++----
3 files changed, 445 insertions(+), 95 deletions(-)
create mode 100644 blivet/formats/fslabel.py
--
1.8.3.1
10 years, 4 months
[master/rhel7-branch] s390x/advanced storage GUI patches, take II
by Samantha N. Bueno
Re-post from last month with recommended edits. I wanted to post these
with the dasd patches, but I can't have nice things. Anyway, to
summarize again:
-- First adds functionality to the 'add zFCP' button in advanced
storage. Users can manually add zFCP devices with this, so it is no
longer necessary to specify them in the parm file.
-- Second gives life to the z-Panel in the advanced storage spoke. I
also added another columns I thought would be useful (device.name). All
issues I was running into previously are now fixed, thanks to clumens
and vpodzime's advice.
-- Third patch is very simple and fixes an issue where searching by LUN
in the advanced storage spoke failed.
A new/updated screencast is available here if anyone wants to see the
patches in action: http://sbueno.fedorapeople.org/s390x-gui-patches.webm
Again, I am willing to provide anyone (@redhat) with access to my s390x
guest as well.
The glade files will require a bit of fudging to make this apply to
master, but other than that I don't believe any significant editing will
be necessary.
The zFCP disk descriptions are still too wide and look awkward. That's
not going to be an easy fix, but I am looking into that.
Samantha
10 years, 4 months
[rhel7-branch/master][PATCH] Global screenshot support V2
by Martin Kolman
Turns out, the scrot dependency is not needed as you can do a full-screen screenshot
just by using GDK! Thanks goes to Ray Strode (halfline) for the hint. :)
So I'm posting this modified patch for RHEL7 & I guess we might just
revert the already committed global screenshot support on master and
replace it with this patch.
Martin Kolman (1):
Global screenshot support (#1025038)
anaconda.spec.in | 1 +
pyanaconda/ui/gui/__init__.py | 54 +++++++++++++++++++++++++------------------
2 files changed, 33 insertions(+), 22 deletions(-)
--
1.8.4.2
10 years, 4 months