[PATCH] If no iscsi nodes are discovered, return an empty list instead of None.
by Chris Lumens
---
blivet/iscsi.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/blivet/iscsi.py b/blivet/iscsi.py
index cecda6a..654de63 100644
--- a/blivet/iscsi.py
+++ b/blivet/iscsi.py
@@ -300,7 +300,7 @@ class iscsi(object):
port=int(port),
authinfo=authinfo)
if found_nodes is None:
- return None
+ return []
self.discovered_targets[(ipaddr, port)] = []
for node in found_nodes:
self.discovered_targets[(ipaddr, port)].append([node, False])
--
1.8.1.2
11 years
[PATCH 1/4] Make the beta warning in the upper right large.
by Chris Lumens
This makes it the same size as the distribution text, which is what we
had in the mockups.
---
widgets/src/BaseWindow.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/widgets/src/BaseWindow.c b/widgets/src/BaseWindow.c
index d587d6e..c21eeca 100644
--- a/widgets/src/BaseWindow.c
+++ b/widgets/src/BaseWindow.c
@@ -654,9 +654,9 @@ static void format_beta_label (AnacondaBaseWindow *window, const char *markup) {
gchar *escaped;
PangoAttrList *attrs;
- /* define attributes -- medium size, bold weight and red text color */
+ /* define attributes -- large size, bold weight and red text color */
attrs = pango_attr_list_new();
- pango_attr_list_insert(attrs, pango_attr_scale_new(PANGO_SCALE_MEDIUM));
+ pango_attr_list_insert(attrs, pango_attr_scale_new(PANGO_SCALE_LARGE));
pango_attr_list_insert(attrs, pango_attr_weight_new(PANGO_WEIGHT_BOLD));
pango_attr_list_insert(attrs, pango_attr_foreground_new(0xfdfd, 0x1010, 0x1010));
@@ -669,6 +669,3 @@ static void format_beta_label (AnacondaBaseWindow *window, const char *markup) {
pango_attr_list_unref(attrs);
g_free(escaped);
}
-
-
-
--
1.8.1.2
11 years
[PATCH][lorax] Add command for anaconda log viewing to bash history
by Martin Kolman
This patch adds a command for viewing the anaconda log
(located in /tmp/anaconda.log) to bash history.
During debugging, I've found I'm typing this command all the
time, so I think it would be useful to have it already present
in history for easier access.
Martin Kolman (1):
Add command for opening anaconda log file to history
share/config_files/common/bash_history | 1 +
1 file changed, 1 insertion(+)
--
1.8.1.4
11 years
[PATCH] (v2) Don't require network configuration in Live DVD (#962485)
by Radek Vykydal
---
pyanaconda/ui/gui/spokes/network.py | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/pyanaconda/ui/gui/spokes/network.py b/pyanaconda/ui/gui/spokes/network.py
index 597419e..432fc09 100644
--- a/pyanaconda/ui/gui/spokes/network.py
+++ b/pyanaconda/ui/gui/spokes/network.py
@@ -33,7 +33,7 @@
from gi.repository import Gtk, AnacondaWidgets
-from pyanaconda.flags import flags
+from pyanaconda import flags
from pyanaconda.i18n import _, N_, P_
from pyanaconda import constants
from pyanaconda.ui.communication import hubQ
@@ -1170,7 +1170,7 @@ class NetworkSpoke(NormalSpoke):
@property
def showable(self):
- return not (flags.livecdInstall or flags.imageInstall)
+ return flags.can_touch_runtime_system("allow network configuration")
def initialize(self):
NormalSpoke.initialize(self)
@@ -1257,7 +1257,8 @@ class NetworkStandaloneSpoke(StandaloneSpoke):
@property
def completed(self):
- return len(self.network_control_box.activated_connections()) > 0
+ return (not flags.can_touch_runtime_system("require network connection")
+ or len(self.network_control_box.activated_connections()) > 0)
def initialize(self):
StandaloneSpoke.initialize(self)
--
1.7.11.7
11 years
[PATCH] Don't require network configuration in Live DVD (#962485)
by Radek Vykydal
---
pyanaconda/ui/gui/spokes/network.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pyanaconda/ui/gui/spokes/network.py b/pyanaconda/ui/gui/spokes/network.py
index 597419e..b8c1a14 100644
--- a/pyanaconda/ui/gui/spokes/network.py
+++ b/pyanaconda/ui/gui/spokes/network.py
@@ -1257,7 +1257,7 @@ class NetworkStandaloneSpoke(StandaloneSpoke):
@property
def completed(self):
- return len(self.network_control_box.activated_connections()) > 0
+ return flags.livecdInstall or len(self.network_control_box.activated_connections()) > 0
def initialize(self):
StandaloneSpoke.initialize(self)
--
1.7.11.7
11 years
[PATCH] Set default FS choice to LVM in text mode (#962600)
by Samantha N. Bueno
Trying to maintain some consistency between text and graphical
behavior.
---
pyanaconda/ui/tui/spokes/storage.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/pyanaconda/ui/tui/spokes/storage.py b/pyanaconda/ui/tui/spokes/storage.py
index d89d4bd..c7bf1c8 100644
--- a/pyanaconda/ui/tui/spokes/storage.py
+++ b/pyanaconda/ui/tui/spokes/storage.py
@@ -367,7 +367,8 @@ class PartitionSchemeSpoke(NormalTUISpoke):
title = _("Partition Scheme Options")
category = "destination"
- _selection = None
+ # set default FS to LVM, for consistency with graphical behavior
+ _selection = 2
def __init__(self, app, data, storage, payload, instclass):
NormalTUISpoke.__init__(self, app, data, storage, payload, instclass)
--
1.7.11.7
11 years
[PATCH] Fix non-default language being hidden
by Martin Kolman
As has reported on Anaconda-devel, the welcome spoke currently doesn't show
the selected language if it is different to the default one.
This patch fixes this behaviour, but due to a bug in GTK the fix
is not 100% effective. Even though the selected language is now visible,
it is not correctly aligned with the top of the viewport.
Why row_align=0.5 ?
So that if some other cell than the upper most one is selected, it ends
in the middle of the viewport & neighboring cells are visible.
Martin Kolman (1):
Fix non-default language being hidden in welcome spoke
pyanaconda/ui/gui/spokes/welcome.py | 30 ++++++++++++++++++++++--------
1 file changed, 22 insertions(+), 8 deletions(-)
--
1.8.1.4
11 years
[master][PATCH] Remove the get_current_layout_name function (#895766)
by Vratislav Podzimek
It doesn't profile any useful functionality anymore now that we have the layout
indicator and may hit some problems with the XklEngine instance (see the
referenced bug for more information).
Signed-off-by: Vratislav Podzimek <vpodzime(a)redhat.com>
---
pyanaconda/keyboard.py | 15 ---------------
1 file changed, 15 deletions(-)
diff --git a/pyanaconda/keyboard.py b/pyanaconda/keyboard.py
index 74b93d3..03b0455 100755
--- a/pyanaconda/keyboard.py
+++ b/pyanaconda/keyboard.py
@@ -524,21 +524,6 @@ class XklWrapper(object):
else:
return language_layouts[0].name
- def get_current_layout_name(self):
- """
- Get current activated X layout's name
-
- :return: current activated X layout's name (e.g. "Czech (qwerty)")
-
- """
-
- self._engine.start_listen(Xkl.EngineListenModes.TRACK_KEYBOARD_STATE)
- state = self._engine.get_current_state()
- groups_names = self._engine.get_groups_names()
- self._engine.stop_listen(Xkl.EngineListenModes.TRACK_KEYBOARD_STATE)
-
- return groups_names[state.group]
-
def activate_default_layout(self):
"""
Activates default layout (the first one in the list of configured
--
1.7.11.7
11 years
[PATCH] Move udev rules generation to pre-trigger (#958924)
by Brian C. Lane
From: "Brian C. Lane" <bcl(a)redhat.com>
driver-disk does its own udev trigger so we need to generate these rules
after it runs. Otherwise it will try to run them twice.
---
dracut/module-setup.sh | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/dracut/module-setup.sh b/dracut/module-setup.sh
index bea2da4..8e75e2c 100755
--- a/dracut/module-setup.sh
+++ b/dracut/module-setup.sh
@@ -28,9 +28,9 @@ install() {
inst_hook cmdline 27 "$moddir/parse-anaconda-repo.sh"
inst_hook cmdline 28 "$moddir/parse-anaconda-net.sh"
inst_hook pre-udev 30 "$moddir/anaconda-modprobe.sh"
- inst_hook pre-udev 40 "$moddir/repo-genrules.sh"
- inst_hook pre-udev 40 "$moddir/kickstart-genrules.sh"
- inst_hook pre-udev 40 "$moddir/updates-genrules.sh"
+ inst_hook pre-trigger 50 "$moddir/repo-genrules.sh"
+ inst_hook pre-trigger 50 "$moddir/kickstart-genrules.sh"
+ inst_hook pre-trigger 50 "$moddir/updates-genrules.sh"
inst_hook initqueue/settled 00 "$moddir/anaconda-ks-sendheaders.sh"
inst_hook initqueue/online 80 "$moddir/anaconda-netroot.sh"
inst "$moddir/anaconda-diskroot" "/sbin/anaconda-diskroot"
--
1.8.1.4
11 years
[PATCH v2] Move udev rules generation to pre-trigger (#958924)
by Brian C. Lane
From: "Brian C. Lane" <bcl(a)redhat.com>
driver-disk does its own udev trigger so we need to generate these rules
after it runs. Otherwise it will try to run them twice.
Source the anaconda-lib in genrules scripts, I was seeing an error in
the dracut logs about a missing function.
---
dracut/anaconda-lib.sh | 2 +-
dracut/kickstart-genrules.sh | 2 ++
dracut/module-setup.sh | 6 +++---
dracut/repo-genrules.sh | 3 +--
dracut/updates-genrules.sh | 2 ++
5 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/dracut/anaconda-lib.sh b/dracut/anaconda-lib.sh
index 51affc7..86ab570 100755
--- a/dracut/anaconda-lib.sh
+++ b/dracut/anaconda-lib.sh
@@ -203,7 +203,7 @@ run_kickstart() {
# replay udev events to trigger actions
if [ "$do_disk" ]; then
- . $hookdir/pre-udev/*repo-genrules.sh
+ . $hookdir/pre-trigger/*repo-genrules.sh
udevadm control --reload
udevadm trigger --action=change --subsystem-match=block
fi
diff --git a/dracut/kickstart-genrules.sh b/dracut/kickstart-genrules.sh
index 880c553..f29ad87 100755
--- a/dracut/kickstart-genrules.sh
+++ b/dracut/kickstart-genrules.sh
@@ -1,6 +1,8 @@
#!/bin/sh
# generate udev rules for fetching kickstarts.
+. /lib/anaconda-lib.sh
+
case "${kickstart%%:*}" in
http|https|ftp|nfs)
# handled by fetch-kickstart-net in the online hook
diff --git a/dracut/module-setup.sh b/dracut/module-setup.sh
index bea2da4..8e75e2c 100755
--- a/dracut/module-setup.sh
+++ b/dracut/module-setup.sh
@@ -28,9 +28,9 @@ install() {
inst_hook cmdline 27 "$moddir/parse-anaconda-repo.sh"
inst_hook cmdline 28 "$moddir/parse-anaconda-net.sh"
inst_hook pre-udev 30 "$moddir/anaconda-modprobe.sh"
- inst_hook pre-udev 40 "$moddir/repo-genrules.sh"
- inst_hook pre-udev 40 "$moddir/kickstart-genrules.sh"
- inst_hook pre-udev 40 "$moddir/updates-genrules.sh"
+ inst_hook pre-trigger 50 "$moddir/repo-genrules.sh"
+ inst_hook pre-trigger 50 "$moddir/kickstart-genrules.sh"
+ inst_hook pre-trigger 50 "$moddir/updates-genrules.sh"
inst_hook initqueue/settled 00 "$moddir/anaconda-ks-sendheaders.sh"
inst_hook initqueue/online 80 "$moddir/anaconda-netroot.sh"
inst "$moddir/anaconda-diskroot" "/sbin/anaconda-diskroot"
diff --git a/dracut/repo-genrules.sh b/dracut/repo-genrules.sh
index 8b95ce1..55abd32 100755
--- a/dracut/repo-genrules.sh
+++ b/dracut/repo-genrules.sh
@@ -2,8 +2,7 @@
# generate udev rules for handling anaconda-specific root devices
# (just the disk-based ones - the network ones are done by netroot)
-# import anaconda-lib for when_diskdev_appears
-command -v when_diskdev_appears >/dev/null || . /lib/anaconda-lib.sh
+. /lib/anaconda-lib.sh
case "$root" in
anaconda-disk:*)
diff --git a/dracut/updates-genrules.sh b/dracut/updates-genrules.sh
index 3ed1e2c..6dd8aee 100755
--- a/dracut/updates-genrules.sh
+++ b/dracut/updates-genrules.sh
@@ -1,6 +1,8 @@
#!/bin/sh
# generate udev rules for fetching updates
+. /lib/anaconda-lib.sh
+
updates=$anac_updates
[ -n "$updates" ] || return
case $updates in
--
1.8.1.4
11 years