[PATCH] get_widget -> get_object (#927898).
by Chris Lumens
---
pyanaconda/ui/gui/spokes/user.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pyanaconda/ui/gui/spokes/user.py b/pyanaconda/ui/gui/spokes/user.py
index 5f8a40e..84bcb8f 100644
--- a/pyanaconda/ui/gui/spokes/user.py
+++ b/pyanaconda/ui/gui/spokes/user.py
@@ -111,7 +111,7 @@ class AdvancedUserDialog(GUIObject):
self._user.uid = None
if self.builder.get_object("c_gid").get_active():
- self._user.gid = int(self.builder.get_widget("gid").get_value())
+ self._user.gid = int(self.builder.get_object("gid").get_value())
else:
self._user.gid = None
--
1.8.1.2
11 years, 1 month
[PATCH] THREAD_* constants are in pyanaconda, not pykickstart.
by Chris Lumens
---
pyanaconda/ui/gui/hubs/progress.py | 3 ++-
pyanaconda/ui/tui/hubs/progress.py | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/pyanaconda/ui/gui/hubs/progress.py b/pyanaconda/ui/gui/hubs/progress.py
index 40c1531..a1da2fd 100644
--- a/pyanaconda/ui/gui/hubs/progress.py
+++ b/pyanaconda/ui/gui/hubs/progress.py
@@ -33,7 +33,8 @@ import sys
from pyanaconda.localization import expand_langs
from pyanaconda.product import productName
from pyanaconda.flags import flags
-from pykickstart.constants import KS_WAIT, KS_SHUTDOWN, KS_REBOOT, THREAD_INSTALL, THREAD_CONFIGURATION
+from pyanaconda.constants import THREAD_INSTALL, THREAD_CONFIGURATION
+from pykickstart.constants import KS_WAIT, KS_SHUTDOWN, KS_REBOOT
from pyanaconda.ui.gui.hubs import Hub
from pyanaconda.ui.gui.utils import gtk_action_nowait, gtk_call_once
diff --git a/pyanaconda/ui/tui/hubs/progress.py b/pyanaconda/ui/tui/hubs/progress.py
index cbe3e07..3e22619 100644
--- a/pyanaconda/ui/tui/hubs/progress.py
+++ b/pyanaconda/ui/tui/hubs/progress.py
@@ -26,7 +26,8 @@ import gettext
_ = lambda x: gettext.ldgettext("anaconda", x)
from pyanaconda.flags import flags
-from pykickstart.constants import KS_SHUTDOWN, KS_REBOOT, THREAD_INSTALL, THREAD_CONFIGURATION
+from pyanaconda.constants import THREAD_INSTALL, THREAD_CONFIGURATION
+from pykickstart.constants import KS_SHUTDOWN, KS_REBOOT
from pyanaconda.ui.tui.hubs import TUIHub
from pyanaconda.ui.tui.simpleline.base import ExitAllMainLoops
--
1.8.1.2
11 years, 1 month
[PATCH] Trying to fix yum thread issue and rpm chroot
by Brian C. Lane
From: "Brian C. Lane" <bcl(a)redhat.com>
I'm stuck on this again.
I've confirmed (in a previous test) that I can write the yum transaction file
out and use execWithRedirect and a couple parameters to run the yum cli and
execute it. That actually worked and it installed a minimal system that booted.
That seems like a hack, although much less of one now that I've spent time
bashing my head against yum/rpm library problems.
This current patch saves the transaction and then reloads it in a separate
thread (using multiprocessing). What should happen is that it loads it and executes
it using our RPMCallback class to retry downloads and track progress.
What actually happens is that it loads it, appears to prepare the transactiion
and the callback gets the first call, a RPMCALLBACK_INST_OPEN_FILE call, logs
that it got the call and then rpm, for reasons that I can't figure out, kills
the process. I don't get any of my extra logging that I've tried to add and
nothing past the "callback: log entry" It isn't catching any exceptions either.
There's an updates.img at http://bcl.fedorapeople.org/updates/yum_thread.img
This can be used with the 19.12 boot.iso from http://alt.fedoraproject.org/pub/alt/anaconda/
Ideas welcome :)
Brian C. Lane (1):
Execute the yum transaction in another process
pyanaconda/install.py | 4 +-
pyanaconda/packaging/yumpayload.py | 336 ++++++++++++++++++++++++++-----------
2 files changed, 238 insertions(+), 102 deletions(-)
--
1.8.1.4
11 years, 1 month
[PATCH] Don't allow setting a mountpoint for an fstype we cannot mount.
by David Lehman
Related: rhbz#910506
---
pyanaconda/ui/gui/spokes/custom.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pyanaconda/ui/gui/spokes/custom.py b/pyanaconda/ui/gui/spokes/custom.py
index cb25709..a13dd59 100644
--- a/pyanaconda/ui/gui/spokes/custom.py
+++ b/pyanaconda/ui/gui/spokes/custom.py
@@ -1393,7 +1393,7 @@ class CustomPartitioningSpoke(NormalSpoke, StorageChecker):
nameEntry.set_text(device_name)
mountPointEntry.set_text(getattr(device.format, "mountpoint", "") or "")
- mountPointEntry.set_sensitive(hasattr(device.format, "mountpoint"))
+ mountPointEntry.set_sensitive(device.format.mountable)
# FIXME: Make sure you cannot set a label for specific btrfs subvols
labelEntry.set_text(getattr(device.format, "label", "") or "")
--
1.8.1.4
11 years, 1 month
[blivet]
by David Lehman
Just a few smaller/simpler patches someone might want to git am while
I am gone. Or not. Either way.
11 years, 1 month
[PATCH] Use the named tuple in root password dialog (#924138)
by Martin Sivak
---
pyanaconda/ui/tui/spokes/__init__.py | 2 +-
pyanaconda/ui/tui/spokes/password.py | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/pyanaconda/ui/tui/spokes/__init__.py b/pyanaconda/ui/tui/spokes/__init__.py
index cd4dba0..6b3c868 100644
--- a/pyanaconda/ui/tui/spokes/__init__.py
+++ b/pyanaconda/ui/tui/spokes/__init__.py
@@ -30,7 +30,7 @@ from pyanaconda.iutil import setdeepattr, getdeepattr
import gettext
_ = lambda x: gettext.ldgettext("anaconda", x)
-__all__ = ["TUISpoke", "EditTUISpoke", "EditTUIDialog", "StandaloneSpoke", "NormalSpoke", "PersonalizationSpoke",
+__all__ = ["TUISpoke", "EditTUISpoke", "EditTUIDialog", "EditTUISpokeEntry", "StandaloneSpoke", "NormalSpoke", "PersonalizationSpoke",
"collect_spokes", "collect_categories"]
class TUISpoke(TUIObject, tui.Widget, Spoke):
diff --git a/pyanaconda/ui/tui/spokes/password.py b/pyanaconda/ui/tui/spokes/password.py
index 522aa30..2bc2b52 100644
--- a/pyanaconda/ui/tui/spokes/password.py
+++ b/pyanaconda/ui/tui/spokes/password.py
@@ -20,7 +20,7 @@
# Jesse Keating <jkeating(a)redhat.com>
#
-from pyanaconda.ui.tui.spokes import EditTUIDialog
+from pyanaconda.ui.tui.spokes import EditTUIDialog, EditTUISpokeEntry
from pyanaconda.ui.common import FirstbootSpokeMixIn
from pyanaconda.ui.tui.simpleline import TextWidget
from pyanaconda.users import cryptPassword
@@ -66,7 +66,7 @@ class PasswordSpoke(FirstbootSpokeMixIn, EditTUIDialog):
def prompt(self, args = None):
"""Overriden prompt as password typing is special."""
- EditTUIDialog.prompt(self, (_("Password"), "", EditTUIDialog.PASSWORD, True))
+ EditTUIDialog.prompt(self, EditTUISpokeEntry(_("Password"), "", EditTUIDialog.PASSWORD, True))
if self.value == None:
return
--
1.7.11.7
11 years, 1 month
[PATCH 1/2] Use only self.data in TUI timezone spoke's status
by Martin Sivak
---
pyanaconda/ui/tui/spokes/time.py | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/pyanaconda/ui/tui/spokes/time.py b/pyanaconda/ui/tui/spokes/time.py
index b9d5a26..98b9dc7 100644
--- a/pyanaconda/ui/tui/spokes/time.py
+++ b/pyanaconda/ui/tui/spokes/time.py
@@ -46,7 +46,7 @@ class TimeZoneSpoke(FirstbootSpokeMixIn, NormalTUISpoke):
@property
def completed(self):
- return bool(self.data.timezone.timezone or self._selection)
+ return bool(self.data.timezone.timezone)
@property
def mandatory(self):
@@ -56,8 +56,6 @@ class TimeZoneSpoke(FirstbootSpokeMixIn, NormalTUISpoke):
def status(self):
if self.data.timezone.timezone:
return _("%s timezone") % self.data.timezone.timezone
- elif self._selection:
- return _("%s timezone") % self._selection
else:
return _("Timezone is not set.")
--
1.7.11.7
11 years, 1 month
[PATCH] udev-settle.service is now systemd-udev-settle.service
by Will Woods
..so change our systemd units accordingly.
---
data/systemd/anaconda-direct.service | 4 ++--
data/systemd/anaconda.target | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/data/systemd/anaconda-direct.service b/data/systemd/anaconda-direct.service
index c92dd9b..61df8ca 100644
--- a/data/systemd/anaconda-direct.service
+++ b/data/systemd/anaconda-direct.service
@@ -3,8 +3,8 @@ WantedBy=anaconda.target
[Unit]
Description=the anaconda installation program
-Wants=instperf.service rsyslog.service udev-settle.service NetworkManager.service
-After=instperf.service rsyslog.service udev-settle.service NetworkManager.service anaconda-sshd.service
+Wants=instperf.service rsyslog.service systemd-udev-settle.service NetworkManager.service
+After=instperf.service rsyslog.service systemd-udev-settle.service NetworkManager.service anaconda-sshd.service
Requires=anaconda.service
[Service]
diff --git a/data/systemd/anaconda.target b/data/systemd/anaconda.target
index 65ad131..77e42ff 100644
--- a/data/systemd/anaconda.target
+++ b/data/systemd/anaconda.target
@@ -5,6 +5,6 @@ After=basic.target
AllowIsolate=yes
Wants=instperf.service
Wants=rsyslog.service
-Wants=udev-settle.service
+Wants=systemd-udev-settle.service
Wants=NetworkManager.service
Wants=plymouth-quit.service plymouth-quit-wait.service
--
1.8.1.4
11 years, 1 month
[PATCH 1/3] Refresh the checkboxes on AdvancedUser dialog properly (#924257)
by Martin Sivak
---
pyanaconda/ui/gui/spokes/user.py | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/pyanaconda/ui/gui/spokes/user.py b/pyanaconda/ui/gui/spokes/user.py
index ee627c4..c42035d 100644
--- a/pyanaconda/ui/gui/spokes/user.py
+++ b/pyanaconda/ui/gui/spokes/user.py
@@ -51,7 +51,7 @@ class AdvancedUserDialog(GUIObject):
def initialize(self):
GUIObject.initialize(self)
- def _apply_checkboxes(self, _editable, data = None):
+ def _apply_checkboxes(self, _editable = None, data = None):
"""Update the state of this screen according to the
checkbox states on the screen. It is called from
the toggled Gtk event.
@@ -72,6 +72,14 @@ class AdvancedUserDialog(GUIObject):
elif self._user.name:
t_home.set_text("/home/%s" % self._user.name)
+ c_home = self.builder.get_object("c_home")
+ c_home.set_active(bool(self._user.homedir))
+ c_uid = self.builder.get_object("c_uid")
+ c_uid.set_active(bool(self._user.uid))
+ c_gid = self.builder.get_object("c_gid")
+ c_gid.set_active(bool(self._user.gid))
+ self._apply_checkboxes()
+
groups = []
for group_name in self._user.groups:
group = self._groupDict[group_name]
--
1.7.11.7
11 years, 1 month