On 12/09/2013 12:29 PM, Chris Lumens wrote:
utils/dd/dd_extract.c | 2 +- utils/dd/dd_list.c | 2 +- widgets/src/BaseWindow.c | 1 + 3 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/utils/dd/dd_extract.c b/utils/dd/dd_extract.c index b6d6af5..46c8426 100644 --- a/utils/dd/dd_extract.c +++ b/utils/dd/dd_extract.c @@ -67,7 +67,7 @@ static const char *options_help [][2] = { void show_help() { int i;
- printf(usage);
- printf("%s", usage); for (i=0; options_help[i][0]; i++) { printf(" -%c, --%-20s %s\n", options_help[i][0][0], options_help[i][0],
diff --git a/utils/dd/dd_list.c b/utils/dd/dd_list.c index 6fb19ca..28ce8d5 100644 --- a/utils/dd/dd_list.c +++ b/utils/dd/dd_list.c @@ -72,7 +72,7 @@ int globErrFunc(const char *epath, int eerrno) void show_help() { int i;
- printf(usage);
- printf("%s", usage); for (i=0; options_help[i][0]; i++) { printf(" -%c, --%-20s %s\n", options_help[i][0][0], options_help[i][0],
diff --git a/widgets/src/BaseWindow.c b/widgets/src/BaseWindow.c index 48a8393..77977cf 100644 --- a/widgets/src/BaseWindow.c +++ b/widgets/src/BaseWindow.c @@ -18,6 +18,7 @@ */
#include <libintl.h> +#include <locale.h> #include <stdlib.h> #include <string.h>
Did you intend for the BaseWindow one to be in this patch? Either way, ack. We could add -Wformat-security to the CFLAGS in configure.ac and widgets/configure.ac, too.