On Tue, 2014-03-25 at 11:48 -0400, mulhern wrote:
These are a bunch of small and pretty obvious changes inspired by pylint warnings.
These look good aside from patch 10.
David
- Catch correct error and disable warning is the only actual bug fix. You need
to fail to parse /proc/mounts correctly to make it manifest, though.
mulhern (10): Catch correct error and disable warning. Give abstract method the same signature as its overriding methods. Spell parameter self correctly Put a field and a method in the base class Get rid of unnecessary pass statements Don't comment out function headers but leave their bodies uncommented Delete method-local pruneFile function. Remove unused assignment to boot. Remove some unused exception names. Replace with a semantically equivalent chunk.
blivet/__init__.py | 6 +----- blivet/devicelibs/raid.py | 2 +- blivet/devices.py | 7 ++----- blivet/devicetree.py | 8 +++----- blivet/formats/fslabel.py | 19 +++++++++++++++---- blivet/iscsi.py | 1 - blivet/util.py | 4 ++-- scripts/makeupdates | 9 --------- tests/devicelibs_test/lvm_test.py | 9 --------- 9 files changed, 24 insertions(+), 41 deletions(-)