New: [rhinstaller/blivet/pulls/138 master] Allow partitioning of md arrays whose members are all disks
by dashea
The motivation here is to enable hardware vendors to use regular md arrays for fwraid without the need for mdmonitor. The difficulty is that there will be nothing to distinguish these fwraid arrays from any other user-created array whose members are disks.
Existing arrays whose members/parents are all partitionable will be partitionable.
Existing arrays whose members/parents are all disks will be treated as disks.
It shouldn't be possible to delete such arrays in anaconda. They should be treated like fwraid arrays. It will be possible to delete them in blivet by scheduling an `ActionDestroyFormat`/`ActionDestroyDevice` action pair, but calling `DeviceTree.recursiveRemove` on them will not destroy the array.
--
To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/138
8 years, 11 months
Updated: [rhinstaller/blivet/pulls/133 master] Fix tests deprecation warnings in a backward compatible way
by dashea
>From the original review in PR #120
@mulkieran
> Please use "with self.assertRaises" everywhere. It's just easier on the eyes.
This doesn't work b/c assertRaises and assertRaisesRegex are different. I'm not quite sure what do you mean but directly changing one for the other doesn't seem to work.
> Also, we always use six.PY2 and six.PY3 to check the python version for this kind of thing, not sys.version_info, so it's probably best to stick with that.
Fixed.
> I think you should be able to avoid modifying the class hierarchy to deal with the versioning problem in commit 3. You might consider modifying unittest.TestCase instead, for example.
Let me see how can I do this. Is there a place where I can hook into before the test cases are actually executed? If so I can monkey-patch unittest.TestCase instead of creating another base class.
--
To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/133
8 years, 11 months