KDE sets $LANGUAGE to an empty string for some mysterious reason, and
they know about it, and they ain't gonna fix it. Ignore $LANGUAGE if
it's an empty string because a careful reading of the man page says that
$LANGUAGE only counts if it contains something and an empty $LANGUAGE
breaks everything.
--
To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/109
We tried to show exception object instead of string.
Now the exception is changed to string.
Resolves: rhbz#1209414
--
To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/108
This solution is definitely not the ideal one but at least it fixes the problem with failing atomic builds. It is neccessary to come up with a better solution for all nodev devices and its mountpoints.
-----
These are currently failing because of mounts cache. The problem is mostly with chrooted mounts and bind mounts of 'nodev' devices. This solution is definitely not ideal one but at least it fixes the problem with failing atomic builds. It is neccessaty to come up with a better solution for all nodev devices and its mountpoints.
--
To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/115
It's the responsibility of whoever calls processKickstart to clean up the
temp file afterwards, if it's no longer needed. dracut/parse-kickstart does
the call, but the temp file is needed to be passed to anaconda. Thus it
can't do the cleanup. The test must therefore do so.
Also, each test should be its own function to ensure it gets cleaned up
after. tearDown only gets called once per class, so it will only clean up
one file.
---
tests/dracut_tests/parse-kickstart_test.py | 16 ++++++++++++++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/tests/dracut_tests/parse-kickstart_test.py b/tests/dracut_tests/parse-kickstart_test.py
index b8fdac7..f076001 100644
--- a/tests/dracut_tests/parse-kickstart_test.py
+++ b/tests/dracut_tests/parse-kickstart_test.py
@@ -31,8 +31,16 @@ class BaseTestCase(unittest.TestCase):
def tearDown(self):
# remove the testing directory
if self.tmpdir and os.path.isdir(self.tmpdir):
- shutil.rmtree(self.tmpdir)
+ try:
+ with open(self.tmpdir + "/ks.info") as f:
+ for line in f:
+ if line.startswith("parsed_kickstart="):
+ os.remove(line[18:-2])
+ break
+ except OSError:
+ pass
+ shutil.rmtree(self.tmpdir)
class ParseKickstartTestCase(BaseTestCase):
@classmethod
@@ -66,6 +74,7 @@ class ParseKickstartTestCase(BaseTestCase):
self.assertEqual(lines[0], "inst.repo=nfs:nolock,timeo=50:host.at.foo.com:/path/to/tree", lines)
+ def nfs_test_2(self):
with tempfile.NamedTemporaryFile() as ks_file:
ks_file.write("""nfs --server=host.at.foo.com --dir=/path/to/tree""")
ks_file.flush()
@@ -79,7 +88,6 @@ class ParseKickstartTestCase(BaseTestCase):
ks_file.flush()
lines = self.execParseKickstart(ks_file.name)
-
self.assertEqual(len(lines), 3, lines)
self.assertEqual(lines[0], "inst.repo=https://host.at.foo.com/path/to/tree", lines)
self.assertEqual(lines[1], "rd.noverifyssl", lines)
@@ -110,6 +118,7 @@ class ParseKickstartTestCase(BaseTestCase):
dd_args_ks = open(self.tmpdir+"/dd_args_ks").readlines()
self.assertEqual(dd_args_ks[0], "sda5", dd_args_ks)
+ def driverdisk_test_2(self):
with tempfile.NamedTemporaryFile() as ks_file:
ks_file.write("""driverdisk --source=http://host.att.foo.com/path/to/dd""")
ks_file.flush()
@@ -125,6 +134,7 @@ class ParseKickstartTestCase(BaseTestCase):
self.assertEqual(lines[0], "ip=dhcp", lines)
+ def network_test_2(self):
with tempfile.NamedTemporaryFile() as ks_file:
ks_file.write("""network --device=AA:BB:CC:DD:EE:FF --bootproto=dhcp --activate""")
ks_file.flush()
@@ -251,6 +261,7 @@ network --device=lo --vlanid=171
self.assertEqual(lines[0], "inst.cmdline", lines)
+ def displaymode_test_2(self):
with tempfile.NamedTemporaryFile() as ks_file:
ks_file.write("""graphical""")
ks_file.flush()
@@ -258,6 +269,7 @@ network --device=lo --vlanid=171
self.assertEqual(lines[0], "inst.graphical", lines)
+ def displaymode_test_3(self):
with tempfile.NamedTemporaryFile() as ks_file:
ks_file.write("""text""")
ks_file.flush()
--
2.2.2
Fix for crash in text anaconda when user set illegal IP address.
Fix bad warning message when illegal IP is set.
*Resolves bug (#1217393)*
--
To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/98
New version of #99
-----
Override readCurrentSize of LVM old-style snapshots to check size
on COW device instead of snapshot device. (The latter one reports
snapshot to be same size as the LV.)
Signed-off-by: Vojtech Trefny <vtrefny(a)redhat.com>
--
To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/114
GError and Error are just aliases of each other, and GError is more
distinctive, thus a better choice for filtering so long as it is
used always in place of Error.
Should have gone in with commit 3f0aa449e42bc64da78e2ff8c0553b4526deed00.
Signed-off-by: mulhern <amulhern(a)redhat.com>
--
To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/116