Updated: [rhinstaller/anaconda/pulls/383 master] don't delete shared/boot parts in deleteAll (#1183880)
by dashea
This is one potential approach to help with #1183880 . It
changes the deleteAll behaviour as follows:
* Partitions known to be shared with other OSes won't be deleted
* Boot partitions won't be deleted if there are unknown parts
You can delete these partitions only by specifically targeting
them. It also adds a variant of the ConfirmDeleteDialog for
boot partitions, with text specifically explaining that they
might be needed for other OSes to boot.
This is my alternative to #377 - I'm just providing it as an option. We could pull the ConfirmDeleteDialog change out of this as a standalone to go along with dlehman's minimal change to the 'delete other partitions' text, also?
--
To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/383
8 years, 2 months
Updated: [rhinstaller/blivet/pulls/251 master] Use libbytesize's Size class as a base for our Size class
by dashea
libbytesize provides an implementation of what we need for manipulations and
calculations with sizes in bytes. It's a little bit faster and more importantly
it can be shared with other projects because it's written in C. Thus we should
use it.
At some point it would be nice if we could drop our own Size class and the
blivet/size.py module altogether because they don't bring any extra value, but
for now we need this thin wrapper to keep the API (almost*) stable. The only
real changes are:
1) Strings like "100 kibibytes" are no longer accepted, I doubt anybody has ever
used this functionality. If the opposite turns out to be true such support will
be added to libbytesize and no change will be needed in Blivet.
2) humanReadable() now ignores the 'skip' and 'min_value' attributes. The former
one is always replaced by 'True' (i.e. trailing zeroes are always stripped), the
latter one is ignored because it made things really cryptic and weird.
* see the commit, mainly the part modifying/removing the tests for more details
Note: tests are expected to be failing at this phase -- libbytesize is not available as a package yet. I am of course not going to merge this before that changes.
--
To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/251
8 years, 2 months
New: [rhinstaller/anaconda/pulls/164 master] Generate random hostnames
by dashea
Instead of defaulting to localhost.localdomain (which makes joining
an enterprise domain difficult), we will instead generate a random
hostname of the form <famous_person>.<adjective>.lan.
Note that if DHCP provides a hostname for this machine, the DHCP-
assigned hostname will be selected, rather than using this
randomly-assigned one.
Testing performed:
Booted two VMs, one bridged to a network which has DHCP-assigned
naming, one NATed with libvirt having no DHCP-assigned names. On
the bridged VM, anaconda selected new-host-4.home as directed by
DHCP. On the NATed VM, it selected newton.elegant.lan as directed
by this random name generation.
--
To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/164
8 years, 2 months
New: [rhinstaller/blivet/pulls/163 master] LUKS resize
by dashea
This is a request for comment, because it is incomplete. I am trying to figure out better ways to test the higher-level functionality but am having problems obtaining a cooperating virtual machine.
There are a few points:
* What makes this a bit tricky is that LUKS is handled as both a device and a format. There is a sense
in which it is both.
* I decided to start from the bottom up this time, working on resizing the format first, rather than worrying about the Actions.
* If the resize of a LUKSDevice is handled as just a resize of its slave's LUKS format then blivet.resizeDevice() does not need to change at all to handle LUKS devices AFAICT.
* However, it does not make much sense to resize a LUKS format outside the LUKS device...since the format knows nothing about the size of the, e.g., filesystem that it encrypts. And yet, it is still possible. Not sure whether it is necessary or desirable to do anything about that.
* I have not handled the dependencies between the actions.
--
To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/163
8 years, 2 months