[PATCH] Disable sort indicators on the filter UI.
by Chris Lumens
They don't currently work, so don't like and pretend they do by showing the
little arrows in the header.
---
pyanaconda/ui/gui/spokes/filter.glade | 44 -----------------------------------
1 file changed, 44 deletions(-)
diff --git a/pyanaconda/ui/gui/spokes/filter.glade b/pyanaconda/ui/gui/spokes/filter.glade
index edd5235..5a324a2 100644
--- a/pyanaconda/ui/gui/spokes/filter.glade
+++ b/pyanaconda/ui/gui/spokes/filter.glade
@@ -348,8 +348,6 @@
<object class="GtkTreeViewColumn" id="searchWWIDCol">
<property name="title" translatable="yes">WWID</property>
<property name="clickable">True</property>
- <property name="sort_indicator">True</property>
- <property name="sort_column_id">10</property>
<child>
<object class="GtkCellRendererText" id="searchWWIDRenderer"/>
<attributes>
@@ -364,8 +362,6 @@
<object class="GtkTreeViewColumn" id="searchCapacityCol">
<property name="title" translatable="yes">Capacity</property>
<property name="clickable">True</property>
- <property name="sort_indicator">True</property>
- <property name="sort_column_id">6</property>
<child>
<object class="GtkCellRendererText" id="searchCapacityRenderer"/>
<attributes>
@@ -380,8 +376,6 @@
<object class="GtkTreeViewColumn" id="searchInterconnectCol">
<property name="title" translatable="yes">Interconnect</property>
<property name="clickable">True</property>
- <property name="sort_indicator">True</property>
- <property name="sort_column_id">8</property>
<child>
<object class="GtkCellRendererText" id="searchInterconnectRenderer"/>
<attributes>
@@ -396,8 +390,6 @@
<object class="GtkTreeViewColumn" id="searchModelCol">
<property name="title" translatable="yes">Model</property>
<property name="clickable">True</property>
- <property name="sort_indicator">True</property>
- <property name="sort_column_id">5</property>
<child>
<object class="GtkCellRendererText" id="searchModelRenderer"/>
<attributes>
@@ -412,8 +404,6 @@
<object class="GtkTreeViewColumn" id="searchLUNCol">
<property name="title" translatable="yes">LUN</property>
<property name="clickable">True</property>
- <property name="sort_indicator">True</property>
- <property name="sort_column_id">14</property>
<child>
<object class="GtkCellRendererText" id="searchLUNRenderer"/>
<attributes>
@@ -428,8 +418,6 @@
<object class="GtkTreeViewColumn" id="searchPortCol">
<property name="title" translatable="yes">Port</property>
<property name="clickable">True</property>
- <property name="sort_indicator">True</property>
- <property name="sort_column_id">12</property>
<child>
<object class="GtkCellRendererText" id="searchPortRenderer"/>
<attributes>
@@ -444,8 +432,6 @@
<object class="GtkTreeViewColumn" id="searchTargetRenderer2">
<property name="title" translatable="yes">Target</property>
<property name="clickable">True</property>
- <property name="sort_indicator">True</property>
- <property name="sort_column_id">13</property>
<child>
<object class="GtkCellRendererText" id="searchTargetRenderer"/>
<attributes>
@@ -460,8 +446,6 @@
<object class="GtkTreeViewColumn" id="searchVendorCol">
<property name="title" translatable="yes">Vendor</property>
<property name="clickable">True</property>
- <property name="sort_indicator">True</property>
- <property name="sort_column_id">7</property>
<child>
<object class="GtkCellRendererText" id="searchVendorRenderer"/>
<attributes>
@@ -747,8 +731,6 @@
<object class="GtkTreeViewColumn" id="multipathWWIDCol">
<property name="title" translatable="yes">WWID</property>
<property name="clickable">True</property>
- <property name="sort_indicator">True</property>
- <property name="sort_column_id">10</property>
<child>
<object class="GtkCellRendererText" id="multipathWWIDRenderer"/>
<attributes>
@@ -763,8 +745,6 @@
<object class="GtkTreeViewColumn" id="multipathCapacityCol">
<property name="title" translatable="yes">Capacity</property>
<property name="clickable">True</property>
- <property name="sort_indicator">True</property>
- <property name="sort_column_id">6</property>
<child>
<object class="GtkCellRendererText" id="multipathCapacityRenderer"/>
<attributes>
@@ -779,8 +759,6 @@
<object class="GtkTreeViewColumn" id="multipathVendorCol">
<property name="title" translatable="yes">Vendor</property>
<property name="clickable">True</property>
- <property name="sort_indicator">True</property>
- <property name="sort_column_id">7</property>
<child>
<object class="GtkCellRendererText" id="multipathVendorRenderer"/>
<attributes>
@@ -796,8 +774,6 @@
<object class="GtkTreeViewColumn" id="multipathInterconnectCol">
<property name="title" translatable="yes">Interconnect</property>
<property name="clickable">True</property>
- <property name="sort_indicator">True</property>
- <property name="sort_column_id">8</property>
<child>
<object class="GtkCellRendererText" id="multipathInterconnectRenderer"/>
<attributes>
@@ -812,8 +788,6 @@
<object class="GtkTreeViewColumn" id="multipathPathsCol">
<property name="title" translatable="yes">Paths</property>
<property name="clickable">True</property>
- <property name="sort_indicator">True</property>
- <property name="sort_column_id">11</property>
<child>
<object class="GtkCellRendererText" id="multipathPathsRenderer"/>
<attributes>
@@ -1106,8 +1080,6 @@
<object class="GtkTreeViewColumn" id="otherIDCol">
<property name="title" translatable="yes">Identifier</property>
<property name="clickable">True</property>
- <property name="sort_indicator">True</property>
- <property name="sort_column_id">10</property>
<child>
<object class="GtkCellRendererText" id="otherIDRenderer"/>
<attributes>
@@ -1122,8 +1094,6 @@
<object class="GtkTreeViewColumn" id="otherCapacityCol">
<property name="title" translatable="yes">Capacity</property>
<property name="clickable">True</property>
- <property name="sort_indicator">True</property>
- <property name="sort_column_id">6</property>
<child>
<object class="GtkCellRendererText" id="otherCapacityRenderer"/>
<attributes>
@@ -1138,8 +1108,6 @@
<object class="GtkTreeViewColumn" id="otherVendorCol">
<property name="title" translatable="yes">Vendor</property>
<property name="clickable">True</property>
- <property name="sort_indicator">True</property>
- <property name="sort_column_id">7</property>
<child>
<object class="GtkCellRendererText" id="otherVendorRenderer"/>
<attributes>
@@ -1155,8 +1123,6 @@
<object class="GtkTreeViewColumn" id="otherInterconnectCol">
<property name="title" translatable="yes">Interconnect</property>
<property name="clickable">True</property>
- <property name="sort_indicator">True</property>
- <property name="sort_column_id">8</property>
<child>
<object class="GtkCellRendererText" id="otherInterconnectRenderer"/>
<attributes>
@@ -1375,8 +1341,6 @@
<object class="GtkTreeViewColumn" id="zCCWCol">
<property name="title" translatable="yes">CCW</property>
<property name="clickable">True</property>
- <property name="sort_indicator">True</property>
- <property name="sort_column_id">15</property>
<child>
<object class="GtkCellRendererText" id="zCCWRenderer"/>
<attributes>
@@ -1391,8 +1355,6 @@
<object class="GtkTreeViewColumn" id="zTypeCol">
<property name="title" translatable="yes">Type</property>
<property name="clickable">True</property>
- <property name="sort_indicator">True</property>
- <property name="sort_column_id">4</property>
<child>
<object class="GtkCellRendererText" id="zTypeRenderer"/>
<attributes>
@@ -1407,8 +1369,6 @@
<object class="GtkTreeViewColumn" id="zCapacityCol">
<property name="title" translatable="yes">Capacity</property>
<property name="clickable">True</property>
- <property name="sort_indicator">True</property>
- <property name="sort_column_id">6</property>
<child>
<object class="GtkCellRendererText" id="zCapacityRenderer"/>
<attributes>
@@ -1423,8 +1383,6 @@
<object class="GtkTreeViewColumn" id="zWWPNCol">
<property name="title" translatable="yes">WWPN</property>
<property name="clickable">True</property>
- <property name="sort_indicator">True</property>
- <property name="sort_column_id">10</property>
<child>
<object class="GtkCellRendererText" id="zWWPNRenderer"/>
<attributes>
@@ -1439,8 +1397,6 @@
<object class="GtkTreeViewColumn" id="zLUNCol">
<property name="title" translatable="yes">LUN</property>
<property name="clickable">True</property>
- <property name="sort_indicator">True</property>
- <property name="sort_column_id">14</property>
<child>
<object class="GtkCellRendererText" id="zLUNRenderer"/>
<attributes>
--
1.8.1.2
11 years
[PATCH] Remove the Viewport from the disk shopping cart.
by Chris Lumens
Having one here prevents scrolling the view automatically with the keyboard.
---
pyanaconda/ui/gui/spokes/lib/cart.glade | 115 +++++++++++++++-----------------
1 file changed, 52 insertions(+), 63 deletions(-)
diff --git a/pyanaconda/ui/gui/spokes/lib/cart.glade b/pyanaconda/ui/gui/spokes/lib/cart.glade
index 8cff0b6..2bf866e 100644
--- a/pyanaconda/ui/gui/spokes/lib/cart.glade
+++ b/pyanaconda/ui/gui/spokes/lib/cart.glade
@@ -93,81 +93,70 @@
<property name="can_focus">True</property>
<property name="shadow_type">in</property>
<child>
- <object class="GtkViewport" id="viewport2">
+ <object class="GtkTreeView" id="disk_tree_view">
<property name="visible">True</property>
- <property name="can_focus">False</property>
+ <property name="can_focus">True</property>
+ <property name="model">disk_store</property>
<child>
- <object class="GtkTreeView" id="disk_tree_view">
- <property name="visible">True</property>
- <property name="can_focus">True</property>
- <property name="model">disk_store</property>
- <child internal-child="selection">
- <object class="GtkTreeSelection" id="disk_selection">
- <signal name="changed" handler="on_selection_changed" swapped="no"/>
- </object>
- </child>
+ <object class="GtkTreeViewColumn" id="boot_column">
+ <property name="title" translatable="yes">Boot</property>
<child>
- <object class="GtkTreeViewColumn" id="boot_column">
- <property name="title" translatable="yes">Boot</property>
- <child>
- <object class="GtkCellRendererPixbuf" id="boot_renderer">
- <property name="stock_id">gtk-apply</property>
- </object>
- <attributes>
- <attribute name="visible">0</attribute>
- </attributes>
- </child>
+ <object class="GtkCellRendererPixbuf" id="boot_renderer">
+ <property name="stock_id">gtk-apply</property>
</object>
+ <attributes>
+ <attribute name="visible">0</attribute>
+ </attributes>
</child>
+ </object>
+ </child>
+ <child>
+ <object class="GtkTreeViewColumn" id="description_column">
+ <property name="spacing">6</property>
+ <property name="title" translatable="yes">Description</property>
+ <property name="clickable">True</property>
<child>
- <object class="GtkTreeViewColumn" id="description_column">
- <property name="spacing">6</property>
- <property name="title" translatable="yes">Description</property>
- <property name="clickable">True</property>
- <child>
- <object class="GtkCellRendererText" id="description_renderer"/>
- <attributes>
- <attribute name="text">1</attribute>
- </attributes>
- </child>
- </object>
+ <object class="GtkCellRendererText" id="description_renderer"/>
+ <attributes>
+ <attribute name="text">1</attribute>
+ </attributes>
</child>
+ </object>
+ </child>
+ <child>
+ <object class="GtkTreeViewColumn" id="name_column">
+ <property name="spacing">6</property>
+ <property name="title" translatable="yes">Name</property>
<child>
- <object class="GtkTreeViewColumn" id="name_column">
- <property name="spacing">6</property>
- <property name="title" translatable="yes">Name</property>
- <child>
- <object class="GtkCellRendererText" id="name_renderer"/>
- <attributes>
- <attribute name="text">4</attribute>
- </attributes>
- </child>
- </object>
+ <object class="GtkCellRendererText" id="name_renderer"/>
+ <attributes>
+ <attribute name="text">4</attribute>
+ </attributes>
</child>
+ </object>
+ </child>
+ <child>
+ <object class="GtkTreeViewColumn" id="capacity_column">
+ <property name="spacing">6</property>
+ <property name="title" translatable="yes">Capacity</property>
+ <property name="clickable">True</property>
<child>
- <object class="GtkTreeViewColumn" id="capacity_column">
- <property name="spacing">6</property>
- <property name="title" translatable="yes">Capacity</property>
- <property name="clickable">True</property>
- <child>
- <object class="GtkCellRendererText" id="capacity_renderer"/>
- <attributes>
- <attribute name="text">2</attribute>
- </attributes>
- </child>
- </object>
+ <object class="GtkCellRendererText" id="capacity_renderer"/>
+ <attributes>
+ <attribute name="text">2</attribute>
+ </attributes>
</child>
+ </object>
+ </child>
+ <child>
+ <object class="GtkTreeViewColumn" id="free_column">
+ <property name="spacing">6</property>
+ <property name="title" translatable="yes">Free</property>
<child>
- <object class="GtkTreeViewColumn" id="free_column">
- <property name="spacing">6</property>
- <property name="title" translatable="yes">Free</property>
- <child>
- <object class="GtkCellRendererText" id="free_renderer"/>
- <attributes>
- <attribute name="text">3</attribute>
- </attributes>
- </child>
- </object>
+ <object class="GtkCellRendererText" id="free_renderer"/>
+ <attributes>
+ <attribute name="text">3</attribute>
+ </attributes>
</child>
</object>
</child>
--
1.8.1.2
11 years
[PATCH 1/2] Transform bootloader --extlinux to extlinux command-line option
by Matthew Miller
From: Matthew Miller <mattdm(a)fedoraproject.org>
---
dracut/parse-kickstart | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/dracut/parse-kickstart b/dracut/parse-kickstart
index 33b68d9..47500c2 100755
--- a/dracut/parse-kickstart
+++ b/dracut/parse-kickstart
@@ -140,6 +140,11 @@ class DisplayMode(commands.displaymode.FC3_DisplayMode):
elif self.displayMode == DISPLAY_MODE_GRAPHICAL:
return "inst.graphical"
+class Bootloader(commands.bootloader.F19_Bootloader):
+ def dracut_args(self, args, lineno, obj):
+ if self.extlinux:
+ return "extlinux"
+
# TODO: keymap, lang... device? selinux?
dracutCmds = {
@@ -154,6 +159,7 @@ dracutCmds = {
'cmdline': DisplayMode,
'graphical': DisplayMode,
'text': DisplayMode,
+ 'bootloader': Bootloader,
}
handlerclass = returnClassForVersion()
class DracutHandler(handlerclass):
--
1.8.2.1
11 years
[PATCH] add --extlinux option
by Matthew Miller
From: Matthew Miller <mattdm(a)mattdm.org>
---
pykickstart/commands/bootloader.py | 23 +++++++++++++++++++++++
pykickstart/handlers/control.py | 2 +-
tests/commands/bootloader.py | 9 +++++++++
3 files changed, 33 insertions(+), 1 deletion(-)
diff --git a/pykickstart/commands/bootloader.py b/pykickstart/commands/bootloader.py
index 0eb2a1b..32035cf 100644
--- a/pykickstart/commands/bootloader.py
+++ b/pykickstart/commands/bootloader.py
@@ -307,3 +307,26 @@ class RHEL6_Bootloader(F12_Bootloader):
op.add_option("--iscrypted", dest="isCrypted", action="store_true", default=False)
op.add_option("--md5pass", action="callback", callback=password_cb, nargs=1, type="string")
return op
+
+class F19_Bootloader(F18_Bootloader):
+ removedKeywords = F18_Bootloader.removedKeywords
+ removedAttrs = F18_Bootloader.removedAttrs
+
+ def __init__(self, writePriority=10, *args, **kwargs):
+ F18_Bootloader.__init__(self, writePriority, *args, **kwargs)
+
+ self.extlinux = kwargs.get("extlinux", False)
+
+ def _getArgsAsStr(self):
+ ret = F18_Bootloader._getArgsAsStr(self)
+
+ if self.extlinux:
+ ret += " --extlinux"
+
+ return ret
+
+ def _getParser(self):
+ op = F18_Bootloader._getParser(self)
+ op.add_option("--extlinux", dest="extlinux", action="store_true",
+ default=False)
+ return op
diff --git a/pykickstart/handlers/control.py b/pykickstart/handlers/control.py
index 1993478..e77e7e4 100644
--- a/pykickstart/handlers/control.py
+++ b/pykickstart/handlers/control.py
@@ -950,7 +950,7 @@ commandMap = {
"authconfig": authconfig.FC3_Authconfig,
"autopart": autopart.F18_AutoPart,
"autostep": autostep.FC3_AutoStep,
- "bootloader": bootloader.F18_Bootloader,
+ "bootloader": bootloader.F19_Bootloader,
"btrfs": btrfs.F17_BTRFS,
"cdrom": method.F18_Method,
"clearpart": clearpart.F17_ClearPart,
diff --git a/tests/commands/bootloader.py b/tests/commands/bootloader.py
index 8e916a6..0ffa10c 100644
--- a/tests/commands/bootloader.py
+++ b/tests/commands/bootloader.py
@@ -148,5 +148,14 @@ class RHEL6_TestCase(F12_TestCase):
self.assert_parse("bootloader --password=blahblah --iscrypted", "bootloader --location=mbr --password=\"blahblah\" --iscrypted\n")
self.assert_parse("bootloader --md5pass=blahblah", "bootloader --location=mbr --password=\"blahblah\" --iscrypted\n")
+class F19_TestCase(F18_TestCase):
+ def runTest(self, iscrypted=False):
+ # run parent tests
+ F18_TestCase.runTest(self, iscrypted=iscrypted)
+
+ self.assert_parse("bootloader --location=mbr --timeout=5 --append=\"rhgb quiet\"")
+ self.assert_parse("bootloader --location=mbr --timeout=5 --extlinux --append=\"rhgb quiet\"")
+
+
if __name__ == "__main__":
unittest.main()
--
1.8.2.1
11 years
(no subject)
by Matthew Miller
Second draft of patches against F19 alpha to include extlinux support.
First adds the new bootloader type without enabling it; second patch enables
it when asked for.
Kickstart flag is the next step; right now this requires extlinux on
the command-line.
11 years
Add partitioning scheme selection in TUI
by Samantha N. Bueno
The first patch adds the ability for users to select a partitioning
scheme (BTRFS, LVM, Standard Partitioning) in text UI. The second just
cleans up a lot of code in the TUI storage spoke.
11 years
[PATCH] Remove the bootloader class's obsoletes attribute.
by Chris Lumens
This was used for upgrades, which we no longer do in anaconda.
---
pyanaconda/bootloader.py | 2 --
1 file changed, 2 deletions(-)
diff --git a/pyanaconda/bootloader.py b/pyanaconda/bootloader.py
index 3e4442a..f34ac8a 100644
--- a/pyanaconda/bootloader.py
+++ b/pyanaconda/bootloader.py
@@ -216,7 +216,6 @@ class TbootLinuxBootLoaderImage(LinuxBootLoaderImage):
class BootLoader(object):
name = "Generic Bootloader"
packages = []
- obsoletes = []
config_file = None
config_file_mode = 0600
can_dual_boot = False
@@ -1336,7 +1335,6 @@ class GRUB2(GRUB):
"""
name = "GRUB2"
packages = ["grub2"]
- obsoletes = ["grub"]
_config_file = "grub.cfg"
_config_dir = "grub2"
config_file_mode = 0600
--
1.8.1.2
11 years
[PATCH] Mark placeholder text in add addtnl keyboard screen as translatable.
by Samantha N. Bueno
---
pyanaconda/ui/gui/spokes/langsupport.glade | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pyanaconda/ui/gui/spokes/langsupport.glade b/pyanaconda/ui/gui/spokes/langsupport.glade
index 0648e9a..7547c27 100644
--- a/pyanaconda/ui/gui/spokes/langsupport.glade
+++ b/pyanaconda/ui/gui/spokes/langsupport.glade
@@ -167,7 +167,7 @@
<property name="invisible_char">●</property>
<property name="invisible_char_set">True</property>
<property name="secondary_icon_name">edit-clear-symbolic</property>
- <property name="placeholder_text">Type here to search.</property>
+ <property name="placeholder_text" translatable="yes">Type here to search.</property>
<signal name="changed" handler="on_entry_changed" swapped="no"/>
<signal name="icon-release" handler="on_clear_icon_clicked" swapped="no"/>
</object>
--
1.7.11.7
11 years
[master] Use systemd-localed's keyboard conf file
by Vratislav Podzimek
This file is read by Gnome in contrast to our own configuration file. Since we
can use systemd-localed to write out configuration with multiple layouts
(although it is a little hack), we don't have to bother about the format of the
file and we can just copy what systemd-localed creates.
This is what the patch does together with cleaning and enhancing
LocaledWrapper's API and features.
Vratislav Podzimek (1):
Use systemd-localed for writing out xorg conf file (#958714)
pyanaconda/keyboard.py | 245 ++++++++++++++++++++++++++++++-------------------
1 file changed, 153 insertions(+), 92 deletions(-)
--
1.7.11.7
11 years
[master] Using busy cursor for better UX
by Vratislav Podzimek
PATCH 1/3 adds a context manager for doing things with the busied cursor. Doing
long-lasting things in the main thread with it improves the user interface as it
looks more like the system is doing something instead of being hanged. An
example of such action can be applying changes in the custom spoke, which is
what PATCH 3/3 does.
PATCH 2/3 is just a minor tweak for not running exception handling window with
the busied cursor.
Vratislav Podzimek (3):
Context manager for doing things with busied cursor
Make sure the "unbusy cursor" is used for the exception window
Busy cursor when applying changes in the custom spoke
pyanaconda/ui/gui/__init__.py | 16 +++++-----------
pyanaconda/ui/gui/spokes/custom.py | 7 ++++++-
pyanaconda/ui/gui/utils.py | 14 ++++++++++++++
3 files changed, 25 insertions(+), 12 deletions(-)
--
1.7.11.7
11 years