On 01/31/2012 07:29 AM, Tomas Sedovic wrote:
On 01/31/2012 01:24 PM, jzigmund(a)redhat.com wrote:
> From: Jozef Zigmund<jzigmund(a)redhat.com>
>
> Now it displays the value of
> pool.statistics[:instances_failed_visible_count].
>
>
https://bugzilla.redhat.com/show_bug.cgi?id=782336
> ---
> src/app/views/pool_families/_pools.html.haml | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/src/app/views/pool_families/_pools.html.haml
> b/src/app/views/pool_families/_pools.html.haml
> index 50a8c00..3112183 100644
> --- a/src/app/views/pool_families/_pools.html.haml
> +++ b/src/app/views/pool_families/_pools.html.haml
> @@ -4,7 +4,7 @@
> %td{:class => 'center'}= pool.deployments.count
> %td{:class => 'center'}= pool.statistics[:total_instances]
> %td{:class => 'center'}= pool.statistics[:instances_pending]
> - %td{:class => 'center'}= pool.statistics[:instances_failed]
> + %td{:class => 'center'}=
> pool.statistics[:instances_failed_visible_count]
> %td{:class => 'center'}= pool.statistics[:quota_percent]
> %td{:class => 'center'}= pool.statistics[:used_quota]
> %td{:class => 'center'}=
> pool.statistics[:available_quota].nil? ? raw('∞') :
> pool.statistics[:available_quota]
Sorry Jozef, I didn't notice Matt's reply and this updated patch when
I wrote the previous reply.
ACK to this. Is the pool.statistics[:instances_failed] value used
anywhere in the code?
If not, we should remove it. If it is, it's still currently broken and
we should fix it (see my previous email).
Yeah it's still used for summary views on the pools side (and probably
here too since the patch has changed).
This issue has caused a bit of confusion, but we really ought to show
aggregate stats across all instances _and_ filtered aggregates. i.e.
pool has 60 instances, 10 failed. Visible to the current user are 10
instances, 2 failed. The user-visible totals are important since that's
what the user sees, but the overall instance count and failures are
useful for seeing overall usage as relates to quota, and for a notion of
overall failure rates, etc. Since we're only summing up, we're not
revealing any private info to non-privileged users.
Thomas