https://bugzilla.redhat.com/show_bug.cgi?id=773768
Unfortunately, we cannot validate the X-Deltacloud-Provider value when we're
adding a new provider. This is because the actual validation requires a working
provider account -- which we don't have at the time.
Fixing this the correct way would require a significant changes around the
Provider and Provider Account creation UI workflow. I.e. ain't gonna happen
now.
So what the fix actually does:
1) Checks that the X-Deltacloud-Provider value is correct on Provider Account
creation.
2) Displays a (hopefully) helpful error message when the user tries to push an
image or launch a deployment whilst having X-Deltacloud-Provider set incorrectly.
Notes to the reviewers
----------------------
This code depends on a Deltacloud Core patch that's been ACKed but not pushed
at the time of writing:
http://mail-archives.apache.org/mod_mbox/deltacloud-dev/201202.mbox/%3C13...
Note that 2 cucumber tests are failing:
cucumber features/provider.feature:61 # Scenario: Create a new Provider failure when using
wrong url
cucumber features/provider_account.feature:17 # Scenario: List providers in XML format
I didn't have the time to fix them. If the patch is otherwise correct and
there's a pressure for getting this in, would you be so kind and fix them?
Hopefully, it's not that difficult.
Otherwise, I'll fix it on 12th March when I'm back.
Thanks,
Thomas