To Whom It May Concern,
Whilst I was using the application, I came to the realization that some of the links in the footer served no purpose. They went nowhere, and there wasn't even an apparent place that they *should* go.
I entered https://bugzilla.redhat.com/show_bug.cgi?id=787280 and proceeded to remove the links and the associated entries in en.yml.
I thank you for your kind consideration of this matter.
Good day, Matt
The "Disclaimer", "Terms of Use", and "Support" links go nowhere, and there are no obvious, immediate plans to remedy that, so they should be removed. --- src/app/views/layouts/application.html.haml | 3 --- src/config/locales/en.yml | 3 --- 2 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/src/app/views/layouts/application.html.haml b/src/app/views/layouts/application.html.haml index ae31ec1..f81093a 100644 --- a/src/app/views/layouts/application.html.haml +++ b/src/app/views/layouts/application.html.haml @@ -59,7 +59,4 @@ .container #legal %nav.footer - %a{:href => '#'}= t('layout.disclaimer') - %a{:href => '#'}= t('layout.terms_of_use') - %a{:href => '#'}= t('layout.support') %span.copyright!= t('layout.copyright') diff --git a/src/config/locales/en.yml b/src/config/locales/en.yml index b5dfc05..6987458 100644 --- a/src/config/locales/en.yml +++ b/src/config/locales/en.yml @@ -1,8 +1,5 @@ en: layout: - disclaimer: Disclaimer - terms_of_use: Terms of Use - support: Support copyright: "Copyright © 2009-2012 Red Hat, Inc. All Rights Reserved." dashboard: Dashboard datetime:
On 04/02/2012, at 7:25 AM, Matt Wagner wrote:
copyright: "Copyright © 2009-2012 Red Hat, Inc. All Rights Reserved."
Now I look it, isn't the "All Rights Reserved." bit very out of place on our upstream (OSS) software...?
Regards and best wishes,
Justin Clift
-- Aeolus Community Manager http://www.aeolusproject.org
On Sat, Feb 04, 2012 at 01:25:47PM +1100, Justin Clift wrote:
On 04/02/2012, at 7:25 AM, Matt Wagner wrote:
copyright: "Copyright © 2009-2012 Red Hat, Inc. All Rights Reserved."
Now I look it, isn't the "All Rights Reserved." bit very out of place on our upstream (OSS) software...?
It does seem out of place. Although I would rather track it as a separate issue from this patch, because otherwise I fear this patch will sit in limbo for weeks. It's not clear to me why "All Rights Reserved" was placed in the footer (nor why it's title-cased), or what the implications are of removing it.
-- Matt
On 02/06/2012 03:35 PM, Matt Wagner wrote:
On Sat, Feb 04, 2012 at 01:25:47PM +1100, Justin Clift wrote:
On 04/02/2012, at 7:25 AM, Matt Wagner wrote:
copyright: "Copyright© 2009-2012 Red Hat, Inc. All Rights Reserved."
Now I look it, isn't the "All Rights Reserved." bit very out of place on our upstream (OSS) software...?
It does seem out of place. Although I would rather track it as a separate issue from this patch, because otherwise I fear this patch will sit in limbo for weeks. It's not clear to me why "All Rights Reserved" was placed in the footer (nor why it's title-cased), or what the implications are of removing it.
-- Matt
Matt, consider the patch ACKed. Unless you want to wait for Angus or Hugh or someone to take a look at it.
On 07/02/2012, at 1:35 AM, Matt Wagner wrote:
On Sat, Feb 04, 2012 at 01:25:47PM +1100, Justin Clift wrote:
On 04/02/2012, at 7:25 AM, Matt Wagner wrote:
copyright: "Copyright © 2009-2012 Red Hat, Inc. All Rights Reserved."
Now I look it, isn't the "All Rights Reserved." bit very out of place on our upstream (OSS) software...?
It does seem out of place. Although I would rather track it as a separate issue from this patch, because otherwise I fear this patch will sit in limbo for weeks. It's not clear to me why "All Rights Reserved" was placed in the footer (nor why it's title-cased), or what the implications are of removing it.
Yeah, no argument that it's a separate BZ/Redmine.
We just don't want to include the "All rights reserved." in an upstream release is all. :)
+ Justin
-- Aeolus Community Manager http://www.aeolusproject.org
On Tue, Feb 07, 2012 at 02:28:20PM +1100, Justin Clift wrote:
Yeah, no argument that it's a separate BZ/Redmine.
We just don't want to include the "All rights reserved." in an upstream release is all. :)
I entered https://bugzilla.redhat.com/show_bug.cgi?id=788153 so we don't forget about this.
On 08/02/2012, at 2:36 AM, Matt Wagner wrote:
On Tue, Feb 07, 2012 at 02:28:20PM +1100, Justin Clift wrote:
Yeah, no argument that it's a separate BZ/Redmine.
We just don't want to include the "All rights reserved." in an upstream release is all. :)
I entered https://bugzilla.redhat.com/show_bug.cgi?id=788153 so we don't forget about this.
This patch should probably be applied to the upstream 0.9-maint branch too.
Just noticed the 0.9.0 rpms generated from that branch, still have the "All rights reserved." text on them. (I'm doing screenshots :>)
Would you be ok, to add this to your todo list?
+ Justin
-- Aeolus Community Manager http://www.aeolusproject.org
On Wed, May 30, 2012 at 07:49:19AM +1000, Justin Clift wrote:
On 08/02/2012, at 2:36 AM, Matt Wagner wrote:
On Tue, Feb 07, 2012 at 02:28:20PM +1100, Justin Clift wrote:
Yeah, no argument that it's a separate BZ/Redmine.
We just don't want to include the "All rights reserved." in an upstream release is all. :)
I entered https://bugzilla.redhat.com/show_bug.cgi?id=788153 so we don't forget about this.
This patch should probably be applied to the upstream 0.9-maint branch too.
Just noticed the 0.9.0 rpms generated from that branch, still have the "All rights reserved." text on them. (I'm doing screenshots :>)
Would you be ok, to add this to your todo list?
Weird... When I check out 0.9-maint, I just see "Copyright (c) 2009-2012 Red Hat, Inc." -- no mention of "All rights reserved". I wonder why we're seeing different things.
I'll poke around a bit more.
-- Matt
aeolus-devel@lists.fedorahosted.org