Hey,
On Wed, 2011-06-01 at 11:25 -0500, Steve Loranz wrote:
I'm not a fan of multiple class definitions per module. Would
like to
see the Watcher code moved to separate modules.
Why all of the class methods instead of making this a singleton.
Class methods should be a convenience to the consumer of a class's
interface instead of a way to manage state.
Steve and I just had a quick chat on IRC about where to go with this
patch set and agreed:
1) I can push 03/11 with a TODO item about the need for the utility
methods to support defining read-only properties
2) The 05/11 and 06/11 patches are just there to make 07/11 easier to
review. If I had squashed them together, Steve wouldn't have
NACKed the result so, ultimately, they're fine to push.
3) Steve's comments above are completely valid. I'll add a TODO and
try and come back to clean the code up further next week
Cheers,
Mark.