On Fri, Aug 26, 2011 at 01:58:48PM -0400, Scott Seago wrote:
src/app/controllers/providers_controller.rb | 6 ++-- src/app/models/provider_account.rb | 21 ++++++++++++++++++- src/app/models/provider_account_observer.rb | 2 +- src/app/models/provider_type.rb | 4 +- .../provider_accounts/_provider_selection.haml | 2 +- src/app/views/provider_types/_list.xml.haml | 2 +- src/app/views/providers/_list.xml.haml | 2 +- ...10217133104_add_provider_type_id_to_provider.rb | 12 ----------- ...20110804215000_rename_provider_type_codename.rb | 9 ++++++++ src/db/seeds.rb | 20 +++++++++--------- src/features/provider_type.feature | 18 ++++++++-------- .../step_definitions/provider_type_steps.rb | 6 ++-- src/spec/factories/credential.rb | 14 ++++++------ src/spec/factories/provider.rb | 6 ++-- src/spec/factories/provider_type.rb | 6 ++-- src/spec/models/provider_spec.rb | 2 +- 16 files changed, 73 insertions(+), 59 deletions(-) create mode 100644 src/db/migrate/20110804215000_rename_provider_type_codename.rb
I still had trouble with this patch series; various errors occur while doing a clean install. I'm going to send a patch that get migrations working. I'm not sure it's the right approach -- I think that your patch disabled creation of ProviderTypes (since this is arguably a job for db:seed). I conditionalized the migrations that expected to be able to modify ProviderTypes, but perhaps we can just get rid of them.
There was also one migration where I had to force AR to reload column information; somehow it was clinging onto a cached view of the tables.
With this in place, all tests pass. However, I still can't actually test this in a browser, as I'm hitting errors with deltacloud. If you happen to reply to this over the weekend, could you tell me how we're supposed to set up and test this? I'm not sure how to get deltacloud to run without specifying a particular provider.