OK updated patchset just sent to list
On 04/19/2012 02:02 PM, Martyn Taylor wrote:
Hi Mo,
As we discussed I've had a few issues with conductor and aeolus-image with your patches on fedora 17. I tried to get this working with manual setup but still having issues. Unfortunately I'm going to have to nack this patch set until some of the issues are solved. I've put a list below with some output.
Regards
Martyn
- We have 1 test failure in aeolus-image.
Failures:
- Aeolus::Image::Warehouse::WarehouseModel#== when other object has
the same instance variables list with the same values Failure/Error: it { subject.==(other_warehouse_model).should be_true } expected false to be true # ./spec/models/warehouse/warehouse_model_spec.rb:41:in `block (5 levels) in module:Warehouse'
Finished in 0.45152 seconds 109 examples, 1 failure, 4 pending
Failed examples:
rspec ./spec/models/warehouse/warehouse_model_spec.rb:41 # Aeolus::Image::Warehouse::WarehouseModel#== when other object has the same instance variables list with the same values rake aborted!
Fixed, aeolus-image-rubygem patch incorporates fix to this.
- Conductor migrations fail:
rake aborted! (/home/martyn/aeolus-tests/conductor/src/config/locales/it.yml): couldn't parse YAML at line 386 column 54
Tasks: TOP => db:migrate (See full trace by running task with --trace) [martyn@vm1 src]$ rake db:migrate --trace Using gem require instead of bundler ========= cucumber/test env deps loaded... ========== ** Invoke db:migrate (first_time) ** Invoke environment (first_time) ** Execute environment Failed to load /home/martyn/aeolus-tests/conductor/src/config/oauth.json, continuing without OAuth support. Run rake dc:oauth_keys and restart Conductor to enable. ** Execute db:migrate rake aborted! (/home/martyn/aeolus-tests/conductor/src/config/locales/it.yml): couldn't parse YAML at line 386 column 54
Fixed, updated / fixed all the locals, the migrations now run on F17.
- We require shadow rubygem for aoelus-configure, puppet dep
ruby-shadow was updated to build against Ruby 1.9 so this is no longer an issue.
- Need to update the conductor spec to remove the fastercsv dependency
This was part of the original patchset, shout out if I missed anything though.
-Mo