On Thu, 2011-07-28 at 10:32 +0100, Mark McLoughlin wrote:
On Thu, 2011-07-28 at 05:23 -0400, Chris Lalancette wrote:
> On 07/28/11 - 09:57:56AM, Mark McLoughlin wrote:
> > On Wed, 2011-07-27 at 04:35 -0400, Chris Lalancette wrote:
> > > diff --git a/src/db/migrate/20110124103216_create_delayed_jobs.rb
b/src/db/migrate/20110124103216_create_delayed_jobs.rb
> > > deleted file mode 100644
> > > index 943ff9b..0000000
> > > --- a/src/db/migrate/20110124103216_create_delayed_jobs.rb
> > > +++ /dev/null
> > > @@ -1,21 +0,0 @@
> > > -class CreateDelayedJobs < ActiveRecord::Migration
> > > - def self.up
> > > - create_table :delayed_jobs, :force => true do |table|
> >
> > Is this really the right thing to do? Why aren't we adding a new
> > migration which removes the table?
>
> Hey Mark,
> The reason I removed this initially is because I was getting errors along
> the lines of "delayed_job gem missing" when trying to run this migration.
Now,
> I didn't investigate all that closely at the time, so it is possible that there
> was something else causing that error and this was just a red herring.
I think that was because of src/config/initializers/delayed_job.rb not
the migration
I doesn't look like the migration uses delayed_job itself
Happy to ACK the rest of the patch FWIW
If there's still some problem caused by the migration after that, we can
dig into the specifics
Cheers,
Mark.