From: Scott Seago <sseago(a)redhat.com>
Tests are still all failing, but this gets them to the point
where they'll run.
---
src/config/cucumber.yml | 2 +-
src/config/environments/cucumber.rb | 67 +++---
src/features/step_definitions/custom_web_steps.rb | 3 +
src/features/step_definitions/web_steps.rb | 246 +++++++--------------
src/features/support/env.rb | 80 +++----
src/features/support/paths.rb | 6 +-
src/features/support/selectors.rb | 39 ++++
src/features/support/vcr.rb | 2 +
src/lib/tasks/cucumber.rake | 12 +
9 files changed, 214 insertions(+), 243 deletions(-)
create mode 100644 src/features/step_definitions/custom_web_steps.rb
create mode 100644 src/features/support/selectors.rb
create mode 100644 src/features/support/vcr.rb
diff --git a/src/config/cucumber.yml b/src/config/cucumber.yml
index 621a14c..19b288d 100644
--- a/src/config/cucumber.yml
+++ b/src/config/cucumber.yml
@@ -1,7 +1,7 @@
<%
rerun = File.file?('rerun.txt') ? IO.read('rerun.txt') : ""
rerun_opts = rerun.to_s.strip.empty? ? "--format #{ENV['CUCUMBER_FORMAT'] ||
'progress'} features" : "--format #{ENV['CUCUMBER_FORMAT'] ||
'pretty'} #{rerun}"
-std_opts = "--format #{ENV['CUCUMBER_FORMAT'] || 'progress'}
--strict --tags ~@wip"
+std_opts = "--format #{ENV['CUCUMBER_FORMAT'] || 'pretty'} --strict
--tags ~@wip"
%>
default: <%= std_opts %> features
wip: --tags @wip:3 --wip features
diff --git a/src/config/environments/cucumber.rb b/src/config/environments/cucumber.rb
index 743fd76..f4e4baf 100644
--- a/src/config/environments/cucumber.rb
+++ b/src/config/environments/cucumber.rb
@@ -1,32 +1,35 @@
-# Edit at your own peril - it's recommended to regenerate this file
-# in the future when you upgrade to a newer version of Cucumber.
-
-# IMPORTANT: Setting config.cache_classes to false is known to
-# break Cucumber's use_transactional_fixtures method.
-# For more information see
https://rspec.lighthouseapp.com/projects/16211/tickets/165
-config.cache_classes = true
-
-# Log error messages when you accidentally call methods on nil.
-config.whiny_nils = true
-
-# Show full error reports and disable caching
-config.action_controller.consider_all_requests_local = true
-config.action_controller.perform_caching = false
-
-# Disable request forgery protection in test environment
-config.action_controller.allow_forgery_protection = false
-
-# Tell Action Mailer not to deliver emails to the real world.
-# The :test delivery method accumulates sent emails in the
-# ActionMailer::Base.deliveries array.
-config.action_mailer.delivery_method = :test
-
-config.gem 'cucumber-rails', :lib => false, :version =>
'~>0.3.2' unless File.directory?(File.join(Rails.root,
'vendor/plugins/cucumber-rails'))
-config.gem 'database_cleaner', :lib => false, :version =>
'~>0.5.0' unless File.directory?(File.join(Rails.root,
'vendor/plugins/database_cleaner'))
-config.gem 'webrat', :lib => false, :version =>
'~>0.7.3' unless File.directory?(File.join(Rails.root,
'vendor/plugins/webrat'))
-config.gem 'rspec', :lib => false, :version =>
'~>1.3.0' unless File.directory?(File.join(Rails.root,
'vendor/plugins/rspec'))
-config.gem 'rspec-rails', :lib => false, :version =>
'~>1.3.2' unless File.directory?(File.join(Rails.root,
'vendor/plugins/rspec-rails'))
-
-config.gem "factory_girl", :lib => "factory_girl", :version =>
"~>1.3.1"
-config.gem 'vcr', :lib => 'vcr', :version => '>=
1.10.0'
-config.gem 'webmock', :lib => 'webmock', :version => '>=
1.6.4'
+Conductor::Application.configure do
+ # Settings specified here will take precedence over those in config/environment.rb
+
+ # The test environment is used exclusively to run your application's
+ # test suite. You never need to work with it otherwise. Remember that
+ # your test database is "scratch space" for the test suite and is wiped
+ # and recreated between test runs. Don't rely on the data there!
+ config.cache_classes = true
+
+ # Log error messages when you accidentally call methods on nil.
+ config.whiny_nils = true
+
+ # Show full error reports and disable caching
+ config.consider_all_requests_local = true
+ config.action_controller.perform_caching = false
+
+ # Raise exceptions instead of rendering exception templates
+ config.action_dispatch.show_exceptions = false
+
+ # Disable request forgery protection in test environment
+ config.action_controller.allow_forgery_protection = false
+
+ # Tell Action Mailer not to deliver emails to the real world.
+ # The :test delivery method accumulates sent emails in the
+ # ActionMailer::Base.deliveries array.
+ config.action_mailer.delivery_method = :test
+
+ # Use SQL instead of Active Record's schema dumper when creating the test
database.
+ # This is necessary if your schema can't be completely dumped by the schema
dumper,
+ # like if you have constraints or database-specific column types
+ # config.active_record.schema_format = :sql
+
+ # Print deprecation notices to the stderr
+ config.active_support.deprecation = :stderr
+end
diff --git a/src/features/step_definitions/custom_web_steps.rb
b/src/features/step_definitions/custom_web_steps.rb
new file mode 100644
index 0000000..a3e0463
--- /dev/null
+++ b/src/features/step_definitions/custom_web_steps.rb
@@ -0,0 +1,3 @@
+When /^(?:|I )follow link with ID "([^"]*)"$/ do |link_id|
+ click_link(link_id)
+end
diff --git a/src/features/step_definitions/web_steps.rb
b/src/features/step_definitions/web_steps.rb
index ee01547..d79b63b 100644
--- a/src/features/step_definitions/web_steps.rb
+++ b/src/features/step_definitions/web_steps.rb
@@ -1,16 +1,45 @@
-# IMPORTANT: This file is generated by cucumber-rails - edit at your own peril.
-# It is recommended to regenerate this file in the future when you upgrade to a
-# newer version of cucumber-rails. Consider adding your own code to a new file
-# instead of editing this one. Cucumber will automatically load all features/**/*.rb
-# files.
+# TL;DR: YOU SHOULD DELETE THIS FILE
+#
+# This file was generated by Cucumber-Rails and is only here to get you a head start
+# These step definitions are thin wrappers around the Capybara/Webrat API that lets you
+# visit pages, interact with widgets and make assertions about page content.
+#
+# If you use these step definitions as basis for your features you will quickly end up
+# with features that are:
+#
+# * Hard to maintain
+# * Verbose to read
+#
+# A much better approach is to write your own higher level step definitions, following
+# the advice in the following blog posts:
+#
+# *
http://benmabey.com/2008/05/19/imperative-vs-declarative-scenarios-in-use...
+# *
http://dannorth.net/2011/01/31/whose-domain-is-it-anyway/
+# *
http://elabs.se/blog/15-you-re-cuking-it-wrong
+#
require 'uri'
require 'cgi'
require File.expand_path(File.join(File.dirname(__FILE__), "..",
"support", "paths"))
+require File.expand_path(File.join(File.dirname(__FILE__), "..",
"support", "selectors"))
+
+module WithinHelpers
+ def with_scope(locator)
+ locator ? within(*selector_for(locator)) { yield } : yield
+ end
+end
+World(WithinHelpers)
+
+# Single-line step scoper
+When /^(.*) within (.*[^:])$/ do |step, parent|
+ with_scope(parent) { When step }
+end
-# Commonly used webrat steps
-#
http://github.com/brynary/webrat
+# Multi-line step scoper
+When /^(.*) within (.*[^:]):$/ do |step, parent, table_or_string|
+ with_scope(parent) { When "#{step}:", table_or_string }
+end
Given /^(?:|I )am on (.+)$/ do |page_name|
visit path_to(page_name)
@@ -24,24 +53,10 @@ When /^(?:|I )press "([^"]*)"$/ do |button|
click_button(button)
end
-When /^I press "([^\"]*)" within "([^\"]*)"$/ do
|button,scope_selector|
- within(scope_selector) do
- click_button(button)
- end
-end
-
When /^(?:|I )follow "([^"]*)"$/ do |link|
click_link(link)
end
-When /^(?:|I )follow link with ID "([^"]*)"$/ do |link_id|
- click_link(link_id)
-end
-
-When /^(?:|I )follow "([^"]*)" within "([^"]*)"$/ do |link,
parent|
- click_link_within(parent, link)
-end
-
When /^(?:|I )fill in "([^"]*)" with "([^"]*)"$/ do |field,
value|
fill_in(field, :with => value)
end
@@ -71,53 +86,6 @@ When /^(?:|I )select "([^"]*)" from
"([^"]*)"$/ do |value, field|
select(value, :from => field)
end
-# Use this step in conjunction with Rail's datetime_select helper. For example:
-# When I select "December 25, 2008 10:00" as the date and time
-When /^(?:|I )select "([^"]*)" as the date and time$/ do |time|
- select_datetime(time)
-end
-
-# Use this step when using multiple datetime_select helpers on a page or
-# you want to specify which datetime to select. Given the following view:
-# <%= f.label :preferred %><br />
-# <%= f.datetime_select :preferred %>
-# <%= f.label :alternative %><br />
-# <%= f.datetime_select :alternative %>
-# The following steps would fill out the form:
-# When I select "November 23, 2004 11:20" as the "Preferred" date and
time
-# And I select "November 25, 2004 10:30" as the "Alternative" date
and time
-When /^(?:|I )select "([^"]*)" as the "([^"]*)" date and
time$/ do |datetime, datetime_label|
- select_datetime(datetime, :from => datetime_label)
-end
-
-# Use this step in conjunction with Rail's time_select helper. For example:
-# When I select "2:20PM" as the time
-# Note: Rail's default time helper provides 24-hour time-- not 12 hour time. Webrat
-# will convert the 2:20PM to 14:20 and then select it.
-When /^(?:|I )select "([^"]*)" as the time$/ do |time|
- select_time(time)
-end
-
-# Use this step when using multiple time_select helpers on a page or you want to
-# specify the name of the time on the form. For example:
-# When I select "7:30AM" as the "Gym" time
-When /^(?:|I )select "([^"]*)" as the "([^"]*)" time$/ do
|time, time_label|
- select_time(time, :from => time_label)
-end
-
-# Use this step in conjunction with Rail's date_select helper. For example:
-# When I select "February 20, 1981" as the date
-When /^(?:|I )select "([^"]*)" as the date$/ do |date|
- select_date(date)
-end
-
-# Use this step when using multiple date_select helpers on one page or
-# you want to specify the name of the date on the form. For example:
-# When I select "April 26, 1982" as the "Date of Birth" date
-When /^(?:|I )select "([^"]*)" as the "([^"]*)" date$/ do
|date, date_label|
- select_date(date, :from => date_label)
-end
-
When /^(?:|I )check "([^"]*)"$/ do |field|
check(field)
end
@@ -130,137 +98,89 @@ When /^(?:|I )choose "([^"]*)"$/ do |field|
choose(field)
end
-# Adds support for validates_attachment_content_type. Without the mime-type getting
-# passed to attach_file() you will get a "Photo file is not one of the allowed file
types."
-# error message
When /^(?:|I )attach the file "([^"]*)" to "([^"]*)"$/ do
|path, field|
- type = path.split(".")[1]
-
- case type
- when "jpg"
- type = "image/jpg"
- when "jpeg"
- type = "image/jpeg"
- when "png"
- type = "image/png"
- when "gif"
- type = "image/gif"
- end
-
- attach_file(field, path, type)
+ attach_file(field, File.expand_path(path))
end
Then /^(?:|I )should see "([^"]*)"$/ do |text|
- if response.respond_to? :should
- response.should contain(text)
+ if page.respond_to? :should
+ page.should have_content(text)
else
- assert_contain text
- end
-end
-
-Then /^(?:|I )should see "([^"]*)" within "([^"]*)"$/ do
|text, selector|
- within(selector) do |content|
- if content.respond_to? :should
- content.should contain(text)
- else
- hc = Webrat::Matchers::HasContent.new(text)
- assert hc.matches?(content), hc.failure_message
- end
+ assert page.has_content?(text)
end
end
Then /^(?:|I )should see \/([^\/]*)\/$/ do |regexp|
regexp = Regexp.new(regexp)
- if response.respond_to? :should
- response.should contain(regexp)
- else
- assert_match(regexp, response_body)
- end
-end
-Then /^(?:|I )should see \/([^\/]*)\/ within "([^"]*)"$/ do |regexp,
selector|
- within(selector) do |content|
- regexp = Regexp.new(regexp)
- if content.respond_to? :should
- content.should contain(regexp)
- else
- assert_match(regexp, content)
- end
+ if page.respond_to? :should
+ page.should have_xpath('//*', :text => regexp)
+ else
+ assert page.has_xpath?('//*', :text => regexp)
end
end
Then /^(?:|I )should not see "([^"]*)"$/ do |text|
- if response.respond_to? :should_not
- response.should_not contain(text)
+ if page.respond_to? :should
+ page.should have_no_content(text)
else
- assert_not_contain(text)
- end
-end
-
-Then /^(?:|I )should not see "([^"]*)" within "([^"]*)"$/
do |text, selector|
- within(selector) do |content|
- if content.respond_to? :should_not
- content.should_not contain(text)
- else
- hc = Webrat::Matchers::HasContent.new(text)
- assert !hc.matches?(content), hc.negative_failure_message
- end
+ assert page.has_no_content?(text)
end
end
Then /^(?:|I )should not see \/([^\/]*)\/$/ do |regexp|
regexp = Regexp.new(regexp)
- if response.respond_to? :should_not
- response.should_not contain(regexp)
+
+ if page.respond_to? :should
+ page.should have_no_xpath('//*', :text => regexp)
else
- assert_not_contain(regexp)
+ assert page.has_no_xpath?('//*', :text => regexp)
end
end
-Then /^(?:|I )should not see \/([^\/]*)\/ within "([^"]*)"$/ do |regexp,
selector|
- within(selector) do |content|
- regexp = Regexp.new(regexp)
- if content.respond_to? :should_not
- content.should_not contain(regexp)
+Then /^the "([^"]*)" field(?: within (.*))? should contain
"([^"]*)"$/ do |field, parent, value|
+ with_scope(parent) do
+ field = find_field(field)
+ field_value = (field.tag_name == 'textarea') ? field.text : field.value
+ if field_value.respond_to? :should
+ field_value.should =~ /#{value}/
else
- assert_no_match(regexp, content)
+ assert_match(/#{value}/, field_value)
end
end
end
-Then /^the "([^"]*)" field should contain "([^"]*)"$/ do
|field, value|
- field_value = field_labeled(field).value
- if field_value.respond_to? :should
- field_value.should =~ /#{value}/
- else
- assert_match(/#{value}/, field_value)
- end
-end
-
-Then /^the "([^"]*)" field should not contain "([^"]*)"$/
do |field, value|
- field_value = field_labeled(field).value
- if field_value.respond_to? :should_not
- field_value.should_not =~ /#{value}/
- else
- assert_no_match(/#{value}/, field_value)
+Then /^the "([^"]*)" field(?: within (.*))? should not contain
"([^"]*)"$/ do |field, parent, value|
+ with_scope(parent) do
+ field = find_field(field)
+ field_value = (field.tag_name == 'textarea') ? field.text : field.value
+ if field_value.respond_to? :should_not
+ field_value.should_not =~ /#{value}/
+ else
+ assert_no_match(/#{value}/, field_value)
+ end
end
end
-Then /^the "([^"]*)" checkbox should be checked$/ do |label|
- field = field_labeled(label)
- if field.respond_to? :should
- field.should be_checked
- else
- assert field.checked?
+Then /^the "([^"]*)" checkbox(?: within (.*))? should be checked$/ do
|label, parent|
+ with_scope(parent) do
+ field_checked = find_field(label)['checked']
+ if field_checked.respond_to? :should
+ field_checked.should be_true
+ else
+ assert field_checked
+ end
end
end
-Then /^the "([^"]*)" checkbox should not be checked$/ do |label|
- field = field_labeled(label)
- if field.respond_to? :should_not
- field.should_not be_checked
- else
- assert !field.checked?
+Then /^the "([^"]*)" checkbox(?: within (.*))? should not be checked$/ do
|label, parent|
+ with_scope(parent) do
+ field_checked = find_field(label)['checked']
+ if field_checked.respond_to? :should
+ field_checked.should be_false
+ else
+ assert !field_checked
+ end
end
end
diff --git a/src/features/support/env.rb b/src/features/support/env.rb
index d06255f..2d8b48e 100644
--- a/src/features/support/env.rb
+++ b/src/features/support/env.rb
@@ -4,55 +4,47 @@
# instead of editing this one. Cucumber will automatically load all features/**/*.rb
# files.
-ENV["RAILS_ENV"] ||= "test"
-require File.expand_path(File.dirname(__FILE__) + '/../../config/environment')
+require 'cucumber/rails'
-require 'cucumber/formatter/unicode' # Remove this line if you don't want
Cucumber Unicode support
-require 'cucumber/rails/world'
-require 'cucumber/rails/active_record'
-require 'cucumber/web/tableish'
+# Capybara defaults to XPath selectors rather than Webrat's default of CSS3. In
+# order to ease the transition to Capybara we set the default here. If you'd
+# prefer to use XPath just remove this line and adjust any selectors in your
+# steps to use the XPath syntax.
+Capybara.default_selector = :css
-# Pull in our VCR configuration
-require File.expand_path(File.dirname(__FILE__) + '../../../spec/vcr_setup.rb')
-
-require 'webrat'
-require 'webrat/core/matchers'
+# By default, any exception happening in your Rails application will bubble up
+# to Cucumber so that your scenario will fail. This is a different from how
+# your application behaves in the production environment, where an error page will
+# be rendered instead.
+#
+# Sometimes we want to override this default behaviour and allow Rails to rescue
+# exceptions and display an error page (just like when the app is running in
production).
+# Typical scenarios where you want to do this is when you test your error pages.
+# There are two ways to allow Rails to rescue exceptions:
+#
+# 1) Tag your scenario (or feature) with @allow-rescue
+#
+# 2) Set the value below to true. Beware that doing this globally is not
+# recommended as it will mask a lot of errors for you!
+#
+ActionController::Base.allow_rescue = false
-Webrat.configure do |config|
- config.mode = :rack
- config.open_error_files = false # Set to true if you want error pages to pop up in the
browser
+# Remove/comment out the lines below if your app doesn't have a database.
+# For some databases (like MongoDB and CouchDB) you may need to use :truncation instead.
+begin
+ DatabaseCleaner.strategy = :transaction
+rescue NameError
+ raise "You need to add database_cleaner to your Gemfile (in the :test group) if
you wish to use it."
end
-# If you set this to false, any error raised from within your app will bubble
-# up to your step definition and out to cucumber unless you catch it somewhere
-# on the way. You can make Rails rescue errors and render error pages on a
-# per-scenario basis by tagging a scenario or feature with the @allow-rescue tag.
+# You may also want to configure DatabaseCleaner to use different strategies for certain
features and scenarios.
+# See the DatabaseCleaner documentation for details. Example:
#
-# If you set this to true, Rails will rescue all errors and render error
-# pages, more or less in the same way your application would behave in the
-# default production environment. It's not recommended to do this for all
-# of your scenarios, as this makes it hard to discover errors in your application.
-ActionController::Base.allow_rescue = false
-
-# If you set this to true, each scenario will run in a database transaction.
-# You can still turn off transactions on a per-scenario basis, simply tagging
-# a feature or scenario with the @no-txn tag. If you are using Capybara,
-# tagging with @culerity or @javascript will also turn transactions off.
+# Before('@no-txn,@selenium,@culerity,@celerity,@javascript') do
+# DatabaseCleaner.strategy = :truncation, {:except => %w[widgets]}
+# end
#
-# If you set this to false, transactions will be off for all scenarios,
-# regardless of whether you use @no-txn or not.
+# Before('~@no-txn', '~@selenium', '~@culerity',
'~@celerity', '~@javascript') do
+# DatabaseCleaner.strategy = :transaction
+# end
#
-# Beware that turning transactions off will leave data in your database
-# after each scenario, which can lead to hard-to-debug failures in
-# subsequent scenarios. If you do this, we recommend you create a Before
-# block that will explicitly put your database in a known state.
-Cucumber::Rails::World.use_transactional_fixtures = true
-# How to clean your database when transactions are turned off. See
-#
http://github.com/bmabey/database_cleaner for more info.
-if defined?(ActiveRecord::Base)
- begin
- require 'database_cleaner'
- DatabaseCleaner.strategy = :truncation
- rescue LoadError => ignore_if_database_cleaner_not_present
- end
-end
diff --git a/src/features/support/paths.rb b/src/features/support/paths.rb
index 1461077..271f46d 100644
--- a/src/features/support/paths.rb
+++ b/src/features/support/paths.rb
@@ -8,7 +8,7 @@ module NavigationHelpers
def path_to(page_name)
case page_name
- when /the home\s?page/
+ when /^the home\s?page$/
'/'
when /the new account page/
@@ -135,10 +135,10 @@ module NavigationHelpers
else
begin
- page_name =~ /the (.*) page/
+ page_name =~ /^the (.*) page$/
path_components = $1.split(/\s+/)
self.send(path_components.push('path').join('_').to_sym)
- rescue Object => e
+ rescue NoMethodError, ArgumentError
raise "Can't find mapping from \"#{page_name}\" to a
path.\n" +
"Now, go and add a mapping in #{__FILE__}"
end
diff --git a/src/features/support/selectors.rb b/src/features/support/selectors.rb
new file mode 100644
index 0000000..44e34a4
--- /dev/null
+++ b/src/features/support/selectors.rb
@@ -0,0 +1,39 @@
+module HtmlSelectorsHelpers
+ # Maps a name to a selector. Used primarily by the
+ #
+ # When /^(.+) within (.+)$/ do |step, scope|
+ #
+ # step definitions in web_steps.rb
+ #
+ def selector_for(locator)
+ case locator
+
+ when "the page"
+ "html > body"
+
+ # Add more mappings here.
+ # Here is an example that pulls values out of the Regexp:
+ #
+ # when /^the (notice|error|info) flash$/
+ # ".flash.#{$1}"
+
+ # You can also return an array to use a different selector
+ # type, like:
+ #
+ # when /the header/
+ # [:xpath, "//header"]
+
+ # This allows you to provide a quoted selector as the scope
+ # for "within" steps as was previously the default for the
+ # web steps:
+ when /^"(.+)"$/
+ $1
+
+ else
+ raise "Can't find mapping from \"#{locator}\" to a
selector.\n" +
+ "Now, go and add a mapping in #{__FILE__}"
+ end
+ end
+end
+
+World(HtmlSelectorsHelpers)
diff --git a/src/features/support/vcr.rb b/src/features/support/vcr.rb
new file mode 100644
index 0000000..e38bc05
--- /dev/null
+++ b/src/features/support/vcr.rb
@@ -0,0 +1,2 @@
+# Pull in our VCR configuration
+require File.expand_path(File.dirname(__FILE__) + '../../../spec/vcr_setup.rb')
diff --git a/src/lib/tasks/cucumber.rake b/src/lib/tasks/cucumber.rake
index 64cca31..ae5c636 100644
--- a/src/lib/tasks/cucumber.rake
+++ b/src/lib/tasks/cucumber.rake
@@ -34,6 +34,12 @@ begin
desc 'Run all features'
task :all => [:ok, :wip]
+
+ task :statsetup do
+ require 'rails/code_statistics'
+ ::STATS_DIRECTORIES << %w(Cucumber\ features features) if
File.exist?('features')
+ ::CodeStatistics::TEST_TYPES << "Cucumber features" if
File.exist?('features')
+ end
end
desc 'Alias for cucumber:ok'
task :cucumber => 'cucumber:ok'
@@ -43,6 +49,12 @@ begin
task :features => :cucumber do
STDERR.puts "*** The 'features' task is deprecated. See rake -T cucumber
***"
end
+
+ # In case we don't have ActiveRecord, append a no-op task that we can depend upon.
+ task 'db:test:prepare' do
+ end
+
+ task :stats => 'cucumber:statsetup'
rescue LoadError
desc 'cucumber rake task not available (cucumber not installed)'
task :cucumber do
--
1.7.4.4