Re: [katello-devel] moving to ruby 1.9.3
by Hugh O. Brock
On Thu, Oct 18, 2012 at 04:39:44PM +0100, Cliff Perry wrote:
> On 10/18/2012 01:14 PM, Bryan Kearney wrote:
> >On 10/18/2012 05:34 AM, Dmitri Dolguikh wrote:
> >>On 18/10/12 09:22 AM, Ivan Nečas wrote:
> >>>On 10/17/2012 07:18 PM, Hugh Brock wrote:
> >>>>On Wed, Oct 17, 2012 at 05:19:09PM +0100, Dmitri Dolguikh wrote:
> >>>>>On 17/10/12 05:04 PM, Jason Rist wrote:
> >>>>>>On 10/17/2012 09:37 AM, Dmitri Dolguikh wrote:
> >>>>>>>As part of port to Ruby 1.9.3, I'd suggest moving away from custom
> >>>>>>>ruby
> >>>>>>>repository for bundler-based installs, and switch to rubygems.org
> >>>>>>>repository instead. Folks still would rather use Fedora-provided
> >>>>>>>gems
> >>>>>>>can do so, since Fedora 17 versions of 'bundler' and 'gem' are
> >>>>>>>yum-aware. This would simplify dependency management during
> >>>>>>>development.
> >>>>>>>
> >>>>>>>
> >>>>>>>As the next step I'd like to propose to switch to rails 3.2 (the
> >>>>>>>version
> >>>>>>>of Rails that's going to be shipped with f18) in master (which is
> >>>>>>>what
> >>>>>>>Aeolus folks did).
> >>>Let's call it Fedora 18 support :)
> >>>>>>>
> >>>>>>>
> >>>>>>>-d
> >>>>>>>
> >>>>>>>_______________________________________________
> >>>>>>>katello-devel mailing list
> >>>>>>>katello-devel(a)redhat.com
> >>>>>>>https://www.redhat.com/mailman/listinfo/katello-devel
> >>>>>>I think this is what we should have been doing. Can we not develop
> >>>>>>upstream in a more normal rails fashion and then deal with
> >>>>>>packaging and
> >>>>>>the like downstream? Or is that too much work?
> >>>>>>
> >>>>>I'm not sure why we aren't doing this atm. Considering that we have
> >>>>>a suite of integration tests that is being run *after* katello has
> >>>>>been packaged, it's safe to split development and packaging - we are
> >>>>>able to catch the issues.
> >>>Here are some reasons why we care about RPM packages from the beginning:
> >>>
> >>>1. Katello as a working thing by far isn't just a Rails app and
> >>>outside of the Ruby word gems mean nothing.
> >>>2. The installation process is part of the whole project. Using the
> >>>installation process that will be used in production from start means
> >>>catching the issues sooner than just before release
> >>>3. Creating an RPM forces you to thing about the license soon. It's
> >>>not pleasant to find out that your code is not shipable because of the
> >>>licensing issues
> >>>4. The code has to work on the target platform (which is Fedora an
> >>>RHEL for us), and (as Metallica sings) nothing else matters
> >>>5. Things like selinux need to be solved as well.
> >>>6. This approach is Continuous Delivery compliant: and now we are
> >>>having 2-months CR release cycle
> >>>
> >>>You can do whatever you want on the development machine. And I have
> >>>nothing against improvements that will make development on non-Fedora
> >>>based systems easier. But when you want to merge into the master, you
> >>>have to count on the fact that somebody will want to install it on
> >>>test or production machine.
> >>>
> >>>Unlike Aeolus, we don't try to get Katello into Fedora official repos
> >>>yet (though our client packages are already there). And getting the
> >>>packages to Fedora it the thing that makes the packaging harder and
> >>>slows down the process: waiting for 2 weeks till the library can be
> >>>used is just too much. Therefore we have our own Koji instance, where
> >>>the deps go in the first place, and then we can work on getting them
> >>>to Fedora later while development goes on.
> >>>
> >>>So what I'm saying is: it would be great if someone clones our repo,
> >>>runs bundle install and the server runs on every platform (though I
> >>>don't thing forcing the developer to run all the deps (like Pulp,
> >>>Candlepin, Katello-Cli) from source would make the Rails developer
> >>>happy. But giving up our nightly builds and all the good things that
> >>>go with it just for this reason is really huge step backward. And I
> >>>don't see a reason that this two things couldn't co-exist together.
> >>>
> >>>-- Ivan
> >>
> >>I think we need to standardize on whether replies go above or below the
> >>original comment :)
> >>
>
> In the middle - don't standardize - cos people will then complain.
> We are all grown adults and can adapt to everyone's habits.
>
> >>
> >>I don't think anybody participating in this thread suggests that
> >>packaging is not important. Nor is anyone talking about about abandoning
> >>nightly builds, etc.
> >>
> >>I'm suggesting that we remove development process dependency on build
> >>artifacts. Let's use rubygems.org in development (I know of several
> >>people who are doing this already; it's *very* useful to be able to add
> >>new dependencies in development quickly). Let's use system-provided gems
> >>in packaged Katello.
> >>
> >+1
>
> Personal opinion.
>
> I'll suggest, if you make a pull request for katello in github, that
> you have resolved gem packaging/build before submitting a patch/code
> that requires a new gem. In other words - hack away as you want, but
> once you want it formally in Katello - clean it up and make it
> easily consumable for all, wanting to install Katello from nightly
> rpm based yum repos. If a pull request requires a new(er) gem, then
> it should be rejected until that gem is packaged and available via
> rpm in one of the usual repos for katello.
>
We did this for a while with Aeolus. Unfortunately it confuses the hell
out of ruby developers who don't know anything about RPM.
Imagine for a moment that you are a top-notch rails programmer. Unless
you already work at Red Hat, chances are you've never had to write an
RPM spec before.
Now let's say by some miracle you become interested in contributing to
upstream Katello, or Aeolus. You poke around, talk to people, figure out
that the feature you want isn't already in progress and that upstream
would like to have it. So you go off and write the thing. Along the way
you add your friend's handy gem that does XYZ.
When you submit your patch upstream, we say, oh, gee, sorry, we don't
take patches that add gem dependencies unless you also wrap them up in
this arcane packaging format that is redundant (for rubyists) and not
the least bit useful to you.
I don't think I need to describe what the typical reaction would be...
If we ever want any of these projects to fly on their own without 100%
support from Red Hat, we have to stop doing things that make them weird
to non-RH folks. Like even talking about RPM... or, god help us,
Fedora.
--Hugh
--
== Hugh Brock, hbrock(a)redhat.com ==
== Engineering Manager, Cloud BU ==
== Aeolus Project: Manage virtual infrastructure across clouds. ==
== http://aeolusproject.org ==
"I know that you believe you understand what you think I said, but I’m
not sure you realize that what you heard is not what I meant."
--Robert McCloskey
11 years, 6 months
passenger
by Mo Morsi
Passenger is now in Fedora [1]. If anyone had the cycles, I think it
would be worthwhile to try and get our services running directly under
apache (currently we are proxying connections to thin). Most likely this
will entail some conductor and configure modifications, though some
components (init scripts and such) can be removed in the process.
-Mo
[1] http://pkgs.fedoraproject.org/cgit/rubygem-passenger.git/
11 years, 6 months
2012.10.1 Sprint End Deadlines
by steve linabery
Thanks to everyone's hard work the current sprint (2012.10.1) is well underway.
Given the unfortunate tendency of time to slip away, you may want to keep the following dates in mind:
Tue 23-Oct
* All patches to list
Wed 24-Oct
* All commits and pull requests merged to master
Thu 25-Oct
* Integration/burn in time -- dev should be:
* actively engaged with QE efforts to ensure everything works end-to-end and rectify cases where that is not true
* work to define stories for the next sprint
* freshen up documentation on the wiki/site
Thu 01-Nov
End of Sprint Review and Demos
Note that this leaves less than a week for development of current features. If you have something that is likely to slip, please raise a red flag early and often. And please keep an eye on the mailing lists for patches and pull requests in need of love.
I have added these dates to the aeolusproject.org wiki[1]
Thank you!
Steve Linabery (eggs|eggmaster)
[1] https://redmine.aeolusproject.org/redmine/projects/aeolus/wiki/2012_10_1_...
11 years, 6 months
Tomorrow: Redmine hostname change
by Matt Wagner
Hi folks,
Tomorrow at 4pm EST (slightly over 23 hours from when I send this
email), I intend to flip the switch to move Redmine to a new hostname.
Specifically, Redmine's new home will be
https://redmine.aeolusproject.org/redmine
(Yes, the /redmine prefix is remaining, for technical reasons.)
That URL is already (incidentally) accessible. Tomorrow:
a.) There may be brief downtime during the cut-over. (Not if it can be
avoided, though.)
b.) The existing Redmine URLs (www.aeolusproject.org/redmine) will begin
to serve a 301 redirect to the new URL, on the redmine.aeolusproject.org
subdomain. Once the change is live, you should update any
links/bookmarks you may have, because the redirect may not last forever.
c.) Because of technical limitations (multiple hostnames are not
supported via SSL on a single IP), the static still will no longer be
supported in HTTPS mode. (Redmine, of course, will use SSL -- it's
taking over as the SSL vhost on our IP.)
The reason for this move is that we are looking into moving the main
www.aeolusproject.org static site elsewhere (specifically, GitHub
Pages), in which case the /redmine link would suddenly stop working.
Moving Redmine to its own subdomain solves this issue, and helps keep
each app somewhat flexible in any event.
Before anyone asks -- while there has been talk about using GitHub as a
replacement for Redmine (Issues and their wiki), that is unrelated to
this move.
Best regards,
Matt
11 years, 6 months
[PATCH conductor] BZ 813179 Revised missing translation keys in frontend_realms#form view
by jzigmund@redhat.com
From: Jozef Zigmund <jzigmund(a)redhat.com>
https://bugzilla.redhat.com/show_bug.cgi?id=813179
---
src/app/views/frontend_realms/_form.html.haml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/app/views/frontend_realms/_form.html.haml b/src/app/views/frontend_realms/_form.html.haml
index 39f86e1..bf3a0b8 100644
--- a/src/app/views/frontend_realms/_form.html.haml
+++ b/src/app/views/frontend_realms/_form.html.haml
@@ -2,13 +2,13 @@
= render 'layouts/error_messages', :object => @realm
%fieldset
.field
- = form.label :name, :class => 'em'
+ = form.label :name
.input
= form.text_field :name, :value => @realm.name, :class => 'em long'
.field
= form.label :description
.input
- = form.text_area :description, :title => 'description', :value => @realm.description, :class => 'long'
+ = form.text_area :description, :title => t("activerecord.attributes.frontend_realm.description"), :value => @realm.description, :class => 'long'
%fieldset.options
= form.submit t('save'), :class => "submit button primary"
--
1.7.11.7
11 years, 6 months
[PATCH conductor] BZ 860556 Revised missing translation keys
by jzigmund@redhat.com
From: Jozef Zigmund <jzigmund(a)redhat.com>
https://bugzilla.redhat.com/show_bug.cgi?id=860556
---
src/app/models/quota.rb | 4 ++--
src/app/views/providers/new.html.haml | 2 +-
src/app/views/settings/self_service.html.haml | 2 +-
src/app/views/users/show.html.haml | 2 +-
src/config/locales/activerecord/en.yml | 5 +++++
src/config/locales/en.yml | 1 +
6 files changed, 11 insertions(+), 5 deletions(-)
diff --git a/src/app/models/quota.rb b/src/app/models/quota.rb
index 83e630a..9e408c5 100644
--- a/src/app/models/quota.rb
+++ b/src/app/models/quota.rb
@@ -46,14 +46,14 @@ class Quota < ActiveRecord::Base
:less_than_or_equal_to => 2147483647,
:only_integer => true,
:allow_nil => true,
- :message => "must be a positive whole number less than 2147483647"
+ :message => I18n.t("quotas.flash.error.must_be_positive")
validates_numericality_of :maximum_running_instances,
:greater_than_or_equal_to => 0,
:less_than_or_equal_to => 2147483647,
:only_integer => true,
:allow_nil => true,
- :message => "must be a positive whole number less than 2147483647"
+ :message => I18n.t("quotas.flash.error.must_be_positive")
QuotaResource = Struct.new(:name, :used, :max, :available, :unit)
diff --git a/src/app/views/providers/new.html.haml b/src/app/views/providers/new.html.haml
index 54144a1..c5d53ac 100644
--- a/src/app/views/providers/new.html.haml
+++ b/src/app/views/providers/new.html.haml
@@ -1,7 +1,7 @@
= render :partial => 'layouts/admin_nav'
%header.page-header
.obj_actions
- %span.label.light Choose a provider:
+ %span.label.light=t("providers.choose_a_provider")
%ul#provider_select
%li
= link_to t("providers.index.create_new_provider"), "javascript:void(0)"
diff --git a/src/app/views/settings/self_service.html.haml b/src/app/views/settings/self_service.html.haml
index 898e9ab..c243b6f 100644
--- a/src/app/views/settings/self_service.html.haml
+++ b/src/app/views/settings/self_service.html.haml
@@ -3,7 +3,7 @@
.obj_actions
.return_to
= t 'return_to'
- = link_to "Settings", settings_path
+ = link_to t("settings.settings"), settings_path
%h1.settings=t '.self_service_settings'
%section.content-section
diff --git a/src/app/views/users/show.html.haml b/src/app/views/users/show.html.haml
index 4ebe8a6..cb90992 100644
--- a/src/app/views/users/show.html.haml
+++ b/src/app/views/users/show.html.haml
@@ -54,7 +54,7 @@
%td= t("user_groups.#{user_group.membership_source.downcase}")
%section.content-section.permissions
%header
- %h2.permissions=t'permissions.index.permissions'
+ %h2.permissions=t'instances.tab_captions.permissions'
.content
= render :partial => 'permissions/objects'
/%section.content-section.user
diff --git a/src/config/locales/activerecord/en.yml b/src/config/locales/activerecord/en.yml
index 6c3ab0d..6397d17 100644
--- a/src/config/locales/activerecord/en.yml
+++ b/src/config/locales/activerecord/en.yml
@@ -37,6 +37,7 @@ en:
task: "Task"
user: "User"
view_state: "View State"
+ user_group: User Group
attributes:
base_permission_object:
name: "Name"
@@ -338,6 +339,10 @@ en:
last_login_ip: "Last Login Ip"
created_at: "Created At"
updated_at: "Updated At"
+ user_group:
+ type: Type
+ name: Name
+ description: Description
view_state:
user_id: "User"
name: "Name"
diff --git a/src/config/locales/en.yml b/src/config/locales/en.yml
index 5235672..79698b1 100644
--- a/src/config/locales/en.yml
+++ b/src/config/locales/en.yml
@@ -1474,6 +1474,7 @@ en:
updated: "Quota updated"
error:
not_updated: "Could not update quota. Please check you have entered valid values"
+ must_be_positive: "must be a positive whole number less than 2147483647"
roles:
new_role: New Role
tab_captions:
--
1.7.11.7
11 years, 6 months