On Monday, May 30, 2016 01:01:26 PM William Brown wrote:

On Sun, 2016-05-29 at 10:55 -0700, Thomas Spuhler wrote:

...

389-ds-base-1.3.5.4 doesn't build on Mageia Altlinux reported the same problem with 389-ds-base-1.3.5.3

This is the error: /libslapd_la-ssl.o ldap/servers/slapd/ssl.c: In function 'svrcore_setup': ldap/servers/slapd/ssl.c:1291:5: error: unknown type name 'SVRCOREStdSystemdPinObj' SVRCOREStdSystemdPinObj *StdPinObj; ^ ldap/servers/slapd/ssl.c:1292:18: error: 'SVRCOREStdSystemdPinObj' undeclared (first use in this function) StdPinObj = (SVRCOREStdSystemdPinObj *)SVRCORE_GetRegisteredPinObj();

See log http://pkgsubmit.mageia.org/uploads/failure/cauldron/core/release/2016052 8191035.spuhler.duvel.44896/log/389-ds-base-1 .3.5.4-1.mga6/build.0.20160528191128.log

The attached patch makes it build

Hi,

Sorry but we won't be applying that patch as it reverses the behaviour of the WITH_SYSTEMD flag (IE, on systems without systemd, it would try and build with it ...)

Your distro needs to update SVRCore. The 389-ds project now owns svrcore, and has updated it from 4.0.4 to 4.1.2.

https://pagure.io/svrcore

Svrcore 4.1.2 is required to support WITH_SYSTEMD on 389-ds 1.3.5. 4.1.2 of course provides the needed SVRCORE_CreateStdSystemdPinObj types.

The design doc around this feature can be found here:

https://www.port389.org/docs/389ds/design/systemd-ask-pass.html

Alternately, this could be changed with a header / function check (IE WITH_SVRCORE_CreateStdSystemdPinObj).

We don't think it's worth it though, as the fix that svrcore 4.1.2 brings to using ssl without a pin.txt on systemd is very, very valueable to administrators.

If you need help with upgrade svrcore on your distro, please feel free to ask,

Thanks a lot for your reply, especially on Memorial Day. I see now that the requirement was added to the Fedora 389-ds-base spec.