Hi Mark,
it is the pretty good written testcase.
But there is one thing you can improve. (commit was pushed, so this is for the future)
Instead of this:
{{{
if not entries:
log.fatal('Failed return an entries from search')
assert False
}}}
You can write like this:
{{{
assert entries, 'Failed return an entries from search'
}}}
It's much more simple and readable, and produces the better output.
Thanks,
Simon
----- Original Message -----
From: "Mark Reynolds" <mareynol(a)redhat.com>
To: "389 Directory server developer discussion."
<389-devel(a)lists.fedoraproject.org>
Sent: Monday, August 17, 2015 8:53:05 PM
Subject: [389-devel] please review: Ticket 48233 - Server crashes during shutdown if ACIs
contain IP address
restrictions
https://fedorahosted.org/389/ticket/48233
https://fedorahosted.org/389/attachment/ticket/48233/0001-Ticket-48233-Se...
--
389-devel mailing list
389-devel(a)lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/389-devel