https://fedorahosted.org/389/ticket/48299

https://fedorahosted.org/389/attachment/ticket/48299/0001-Ticket-48299-paged... git patch file (master) -- revised; fixed a bug pointed out by Thierry (Thank you!!) and a minor memory leak.

On 09/30/2015 01:32 AM, 389 Project wrote:

Comment (by tbordaz):

Hi noriko,

The fix looks good, just two remarks

• pagedresults_set_search_result_pb is called each time search result is

freed. Should not it be called in opshared.c:722 (I find this line suspicious should not it be SLAPI_PAGED_RESULTS_INDEX ?)

• in pagedresults_set_search_result_pb, you call slapi_pblock_set(pb,

SLAPI_PAGED_RESULTS_INDEX, &index); . My understanding it is to reset the pr_idx (index==-1). But later you test 'index'. Did you mean slapi_pblock_'''get'''(pb, SLAPI_PAGED_RESULTS_INDEX, &index).