Thanks for the review, Rich!

Pushed to master.

$ git merge usn
Updating 177f772..6b08e5b
Fast forward
 ldap/servers/plugins/replication/repl5_agmt.c |  136 +++++++++++++++++----
 ldap/servers/plugins/usn/usn.c                |   40 +++++-
 ldap/servers/plugins/usn/usn.h                |    2 +-
 ldap/servers/slapd/dse.c                      |    7 +-
 ldap/servers/slapd/plugin.c                   |  156 +++++++++++++++++++++++++
 ldap/servers/slapd/proto-slap.h               |    2 +-
 ldap/servers/slapd/slapi-plugin.h             |   23 ++++
 ldap/servers/slapd/slapi-private.h            |    2 +
 8 files changed, 329 insertions(+), 39 deletions(-)
$ git push
Counting objects: 31, done.
Delta compression using 4 threads.
Compressing objects: 100% (16/16), done.
Writing objects: 100% (16/16), 5.66 KiB, done.
Total 16 (delta 13), reused 0 (delta 0)
To ssh://git.fedorahosted.org/git/389/ds.git
   177f772..6b08e5b  master -> master

On 08/31/2009 07:22 AM, Rich Megginson wrote:
Noriko Hosoi wrote:
Thanks to Endi and Rich for their comments to improve the functionality.  I changed the slapi APIs to take and return the Slapi_Value(Set) to support any data type other than string.

New slapi APIs in libslapd:
 int slapi_set_plugin_default_config(const char *type, Slapi_Value *value);
 Description: Add given "type: value" to the plugin default config entry
              (cn=plugin default config,cn=config) unless the same "type:
              value" pair already exists in the entry.
 Parameters: type - Attribute type to add to the default config entry
             value - Attribute value to add to the default config entry
 Return Value: 0 if the operation was successful
               non-0 if the operation was not successful

 int slapi_get_plugin_default_config(char *type, Slapi_ValueSet **valueset);
 Description: Get attribute values of given type from the plugin default
              config entry (cn=plugin default config,cn=config).
 Parameters: type - Attribute type to get from the default config entry
             valueset Valueset holding the attribute values
 Return Value: 0 if the operation was successful
             non-0 if the operation was not successful
 warning: Caller is responsible to free attrs by slapi_ch_array_free

Thanks,
--noriko
Looks good.  ack


------------------------------------------------------------------------

--
389-devel mailing list
389-devel@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-directory-devel


-- 389-devel mailing list 389-devel@redhat.com https://www.redhat.com/mailman/listinfo/fedora-directory-devel