From rmeggins at redhat.com Wed Oct 30 18:38:29 2013 Content-Type: multipart/mixed; boundary="===============7324169540004624403==" MIME-Version: 1.0 From: Rich Megginson To: 389-devel at lists.fedoraproject.org Subject: Re: [389-devel] Please review lib389 ticket 47575: add test case for ticket47560 Date: Wed, 30 Oct 2013 12:38:58 -0600 Message-ID: <52715242.1090505@redhat.com> In-Reply-To: 52714C17.2030200@redhat.com --===============7324169540004624403== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On 10/30/2013 12:12 PM, thierry bordaz wrote: > On 10/30/2013 06:59 PM, Rich Megginson wrote: >> On 10/30/2013 10:47 AM, thierry bordaz wrote: >>> Hello, >>> >>> This tickets implement a test case and propose a layout of the >>> CI tests in the 389-ds. >>> The basic idea is to put CI tests under: >>> /dirsrvtests/ >>> tickets/ >>> standalone_test.py >>> m1c1_test.py >>> m2_c1_test.py >>> ... >>> >> Does "tickets" in this case mean "tickets for issues in the 389 trac"? > Yes in my mind, this directory would contains test cases for 389 tickets. File or directory? I don't understand - is standalone_test.py supposed = to be a real ticket? Or will the tickets directory contain files like = ticket47424.py, ticket47332.py, etc.? > >>> >>> testsuites/ >>> acl_test.py >>> replication_test.py >>> ... >>> >>> For example, test_standalone.py would setup a standalone >>> topology and will contain all ticket test cases that are >>> applicable on standalone topology. >>> >>> https://fedorahosted.org/389/attachment/ticket/47575/0001-Ticket-47575-= CI-test-add-test-case-for-ticket47560.patch >> >> So we would just keep adding tests to the single file = >> standalone_test.py, every time we add a test for a trac ticket that = >> deals with a standalone server? > Yes, if we have a test case for a ticket_xyz, we may add a new class = > method > > class Test_standAlone(object): > def setup(self): > ... > def teardown(self): > ... > > def test_ticket_xyz(self): > def _test_ticket_xyx_setup(): > > def _test_ticket_xyz_teardown(): > > > _test_ticket_xyz_setup() > > > > _test_ticket_xyz_teardown() > > > > > > def test_ticket_abc(self) > ... > > def test_final(self) > > This won't be in a separate file called ticketXYZ.py? > > > > > > >> >>> >>> regards >>> thierry >>> >>> >>> -- >>> 389-devel mailing list >>> 389-devel(a)lists.fedoraproject.org >>> https://admin.fedoraproject.org/mailman/listinfo/389-devel >> > --===============7324169540004624403== Content-Type: text/html MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="attachment.html" PGh0bWw+CiAgPGhlYWQ+CiAgICA8bWV0YSBjb250ZW50PSJ0ZXh0L2h0bWw7IGNoYXJzZXQ9VVRG LTgiIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSI+CiAgPC9oZWFkPgogIDxib2R5IGJnY29sb3I9 IiNGRkZGRkYiIHRleHQ9IiMwMDAwMDAiPgogICAgPGRpdiBjbGFzcz0ibW96LWNpdGUtcHJlZml4 Ij5PbiAxMC8zMC8yMDEzIDEyOjEyIFBNLCB0aGllcnJ5IGJvcmRhegogICAgICB3cm90ZTo8YnI+ CiAgICA8L2Rpdj4KICAgIDxibG9ja3F1b3RlIGNpdGU9Im1pZDo1MjcxNEMxNy4yMDMwMjAwQHJl ZGhhdC5jb20iIHR5cGU9ImNpdGUiPgogICAgICA8bWV0YSBjb250ZW50PSJ0ZXh0L2h0bWw7IGNo YXJzZXQ9VVRGLTgiIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSI+CiAgICAgIDxkaXYgY2xhc3M9 Im1vei1jaXRlLXByZWZpeCI+T24gMTAvMzAvMjAxMyAwNjo1OSBQTSwgUmljaAogICAgICAgIE1l Z2dpbnNvbiB3cm90ZTo8YnI+CiAgICAgIDwvZGl2PgogICAgICA8YmxvY2txdW90ZSBjaXRlPSJt aWQ6NTI3MTQ5MDYuNzAwMDgwN0ByZWRoYXQuY29tIiB0eXBlPSJjaXRlIj4KICAgICAgICA8bWV0 YSBjb250ZW50PSJ0ZXh0L2h0bWw7IGNoYXJzZXQ9VVRGLTgiCiAgICAgICAgICBodHRwLWVxdWl2 PSJDb250ZW50LVR5cGUiPgogICAgICAgIDxkaXYgY2xhc3M9Im1vei1jaXRlLXByZWZpeCI+T24g MTAvMzAvMjAxMyAxMDo0NyBBTSwgdGhpZXJyeQogICAgICAgICAgYm9yZGF6IHdyb3RlOjxicj4K ICAgICAgICA8L2Rpdj4KICAgICAgICA8YmxvY2txdW90ZSBjaXRlPSJtaWQ6NTI3MTM4MzAuMTAx MDcwOEByZWRoYXQuY29tIiB0eXBlPSJjaXRlIj4KICAgICAgICAgIDxtZXRhIGh0dHAtZXF1aXY9 ImNvbnRlbnQtdHlwZSIgY29udGVudD0idGV4dC9odG1sOwogICAgICAgICAgICBjaGFyc2V0PVVU Ri04Ij4KICAgICAgICAgIDxmb250IGZhY2U9IlRpbWVzIE5ldyBSb21hbiwgVGltZXMsIHNlcmlm Ij5IZWxsbyw8YnI+CiAgICAgICAgICAgIDxicj4KICAgICAgICAgIDwvZm9udD4KICAgICAgICAg IDxibG9ja3F1b3RlPjxmb250IGZhY2U9IlRpbWVzIE5ldyBSb21hbiwgVGltZXMsIHNlcmlmIj5U aGlzCiAgICAgICAgICAgICAgdGlja2V0cyBpbXBsZW1lbnQgYSB0ZXN0IGNhc2UgYW5kIHByb3Bv c2UgYSBsYXlvdXQgb2YgdGhlCiAgICAgICAgICAgICAgQ0kgdGVzdHMgaW4gdGhlIDM4OS1kcy48 L2ZvbnQ+PGJyPgogICAgICAgICAgICA8Zm9udCBmYWNlPSJUaW1lcyBOZXcgUm9tYW4sIFRpbWVz LCBzZXJpZiI+VGhlIGJhc2ljIGlkZWEgaXMKICAgICAgICAgICAgICB0byBwdXQgQ0kgdGVzdHMg dW5kZXI6PGJyPgogICAgICAgICAgICA8L2ZvbnQ+PHR0PiZsdDtoZWFkJmd0Oy9kaXJzcnZ0ZXN0 cy88L3R0Pjx0dD48YnI+CiAgICAgICAgICAgIDwvdHQ+PHR0PsKgwqDCoCB0aWNrZXRzLzwvdHQ+ PHR0Pjxicj4KICAgICAgICAgICAgPC90dD48dHQ+wqDCoMKgIMKgwqDCoCBzdGFuZGFsb25lX3Rl c3QucHk8L3R0Pjx0dD48YnI+CiAgICAgICAgICAgIDwvdHQ+PHR0PsKgwqDCoCDCoMKgwqAgbTFj MV90ZXN0LnB5PC90dD48dHQ+PGJyPgogICAgICAgICAgICA8L3R0Pjx0dD7CoMKgwqAgwqDCoMKg IG0yX2MxX3Rlc3QucHk8L3R0Pjx0dD48YnI+CiAgICAgICAgICAgIDwvdHQ+PHR0PsKgwqDCoCDC oMKgwqAgLi4uPC90dD48dHQ+PGJyPgogICAgICAgICAgICA8L3R0PjwvYmxvY2txdW90ZT4KICAg ICAgICA8L2Jsb2NrcXVvdGU+CiAgICAgICAgPHR0PkRvZXMgInRpY2tldHMiIGluIHRoaXMgY2Fz ZSBtZWFuICJ0aWNrZXRzIGZvciBpc3N1ZXMgaW4gdGhlCiAgICAgICAgICAzODkgdHJhYyI/PC90 dD48YnI+CiAgICAgIDwvYmxvY2txdW90ZT4KICAgICAgWWVzIGluIG15IG1pbmQsIHRoaXMgZGly ZWN0b3J5IHdvdWxkIGNvbnRhaW5zIHRlc3QgY2FzZXMgZm9yIDM4OQogICAgICB0aWNrZXRzLjxi cj4KICAgIDwvYmxvY2txdW90ZT4KICAgIDxicj4KICAgIEZpbGUgb3IgZGlyZWN0b3J5P8KgIEkg ZG9uJ3QgdW5kZXJzdGFuZCAtIGlzIHN0YW5kYWxvbmVfdGVzdC5weQogICAgc3VwcG9zZWQgdG8g YmUgYSByZWFsIHRpY2tldD/CoCBPciB3aWxsIHRoZSB0aWNrZXRzIGRpcmVjdG9yeSBjb250YWlu CiAgICBmaWxlcyBsaWtlIHRpY2tldDQ3NDI0LnB5LCB0aWNrZXQ0NzMzMi5weSwgZXRjLj88YnI+ CiAgICA8YnI+CiAgICA8YmxvY2txdW90ZSBjaXRlPSJtaWQ6NTI3MTRDMTcuMjAzMDIwMEByZWRo YXQuY29tIiB0eXBlPSJjaXRlIj4gPGJyPgogICAgICA8YmxvY2txdW90ZSBjaXRlPSJtaWQ6NTI3 MTQ5MDYuNzAwMDgwN0ByZWRoYXQuY29tIiB0eXBlPSJjaXRlIj4KICAgICAgICA8YmxvY2txdW90 ZSBjaXRlPSJtaWQ6NTI3MTM4MzAuMTAxMDcwOEByZWRoYXQuY29tIiB0eXBlPSJjaXRlIj4KICAg ICAgICAgIDxibG9ja3F1b3RlPjx0dD4gPC90dD48dHQ+PGJyPgogICAgICAgICAgICA8L3R0Pjx0 dD7CoMKgwqAgdGVzdHN1aXRlcy88L3R0Pjx0dD48YnI+CiAgICAgICAgICAgIDwvdHQ+PHR0PsKg wqDCoCDCoMKgwqAgYWNsX3Rlc3QucHk8L3R0Pjx0dD48YnI+CiAgICAgICAgICAgIDwvdHQ+PHR0 PsKgwqDCoCDCoMKgwqAgcmVwbGljYXRpb25fdGVzdC5weTwvdHQ+PHR0Pjxicj4KICAgICAgICAg ICAgPC90dD48dHQ+wqDCoMKgIMKgwqDCoCAuLi48L3R0Pjxmb250IGZhY2U9IlRpbWVzIE5ldyBS b21hbiwgVGltZXMsCiAgICAgICAgICAgICAgc2VyaWYiPjxicj4KICAgICAgICAgICAgICA8YnI+ CiAgICAgICAgICAgICAgRm9yIGV4YW1wbGUsIHRlc3Rfc3RhbmRhbG9uZS5weSB3b3VsZCBzZXR1 cCBhIHN0YW5kYWxvbmUKICAgICAgICAgICAgICB0b3BvbG9neSBhbmQgd2lsbCBjb250YWluIGFs bCB0aWNrZXQgdGVzdCBjYXNlcyB0aGF0IGFyZQogICAgICAgICAgICAgIGFwcGxpY2FibGUgb24g c3RhbmRhbG9uZSB0b3BvbG9neS48L2ZvbnQ+PGJyPgogICAgICAgICAgPC9ibG9ja3F1b3RlPgog ICAgICAgICAgPGZvbnQgZmFjZT0iVGltZXMgTmV3IFJvbWFuLCBUaW1lcywgc2VyaWYiPjxhCiAg ICAgICAgICAgICAgbW96LWRvLW5vdC1zZW5kPSJ0cnVlIiBjbGFzcz0ibW96LXR4dC1saW5rLWZy ZWV0ZXh0IgpocmVmPSJodHRwczovL2ZlZG9yYWhvc3RlZC5vcmcvMzg5L2F0dGFjaG1lbnQvdGlj a2V0LzQ3NTc1LzAwMDEtVGlja2V0LTQ3NTc1LUNJLXRlc3QtYWRkLXRlc3QtY2FzZS1mb3ItdGlj a2V0NDc1NjAucGF0Y2giPmh0dHBzOi8vZmVkb3JhaG9zdGVkLm9yZy8zODkvYXR0YWNobWVudC90 aWNrZXQvNDc1NzUvMDAwMS1UaWNrZXQtNDc1NzUtQ0ktdGVzdC1hZGQtdGVzdC1jYXNlLWZvci10 aWNrZXQ0NzU2MC5wYXRjaDwvYT48YnI+CiAgICAgICAgICA8L2ZvbnQ+PC9ibG9ja3F1b3RlPgog ICAgICAgIDxicj4KICAgICAgICA8Zm9udCBmYWNlPSJUaW1lcyBOZXcgUm9tYW4sIFRpbWVzLCBz ZXJpZiI+U28gd2Ugd291bGQganVzdCBrZWVwCiAgICAgICAgICBhZGRpbmcgdGVzdHMgdG8gdGhl IHNpbmdsZSBmaWxlIHN0YW5kYWxvbmVfdGVzdC5weSwgZXZlcnkgdGltZQogICAgICAgICAgd2Ug YWRkIGEgdGVzdCBmb3IgYSB0cmFjIHRpY2tldCB0aGF0IGRlYWxzIHdpdGggYSBzdGFuZGFsb25l CiAgICAgICAgICBzZXJ2ZXI/PGJyPgogICAgICAgIDwvZm9udD48L2Jsb2NrcXVvdGU+CiAgICAg IDxmb250IGZhY2U9IlRpbWVzIE5ldyBSb21hbiwgVGltZXMsIHNlcmlmIj5ZZXMsIGlmIHdlIGhh dmUgYSB0ZXN0CiAgICAgICAgY2FzZSBmb3IgYSB0aWNrZXRfeHl6LCB3ZSBtYXkgYWRkIGEgbmV3 IGNsYXNzIG1ldGhvZDxicj4KICAgICAgICA8YnI+CiAgICAgIDwvZm9udD4KICAgICAgPGJsb2Nr cXVvdGU+PHR0PmNsYXNzIFRlc3Rfc3RhbmRBbG9uZShvYmplY3QpOjwvdHQ+PGJyPgogICAgICAg IDx0dD7CoMKgwqDCoMKgwqDCoCBkZWYgc2V0dXAoPC90dD48dHQ+c2VsZik6PC90dD48YnI+CiAg ICAgICAgPHR0PsKgwqDCoCDCoMKgwqAgwqDCoMKgIC4uLjwvdHQ+PGJyPgogICAgICAgIDx0dD7C oMKgwqAgwqDCoMKgIGRlZiB0ZWFyZG93bihzZWw8L3R0Pjx0dD5mKTo8L3R0Pjxicj4KICAgICAg ICA8dHQ+wqDCoMKgIMKgwqDCoCDCoMKgwqAgLi4uPC90dD48YnI+CiAgICAgICAgPGJyPgogICAg ICAgIDx0dD7CoMKgwqAgwqDCoMKgIGRlZiB0ZXN0X3RpY2tldF94eXooc2VsZik6PC90dD48YnI+ CiAgICAgICAgPHR0PsKgwqDCoCDCoMKgwqAgwqDCoMKgIGRlZiBfdGVzdF90aWNrZXRfeDwvdHQ+ PHR0Pnl4X3NldHVwKCk6PC90dD48YnI+CiAgICAgICAgPHR0PsKgwqDCoCDCoMKgwqAgwqDCoMKg IMKgwqDCoCA8L3R0Pjx0dD4mbHQ7aW5pdGlhbGl6YXRpb24gb2YgdGVzdCBjYXNlCiAgICAgICAg ICB0aWNrZXQgeHl6Jmd0OzwvdHQ+PGJyPgogICAgICAgIDx0dD7CoMKgwqAgwqDCoMKgIMKgwqDC oCBkZWYgX3Rlc3RfdGlja2V0X3h5el90ZWFyZDwvdHQ+PHR0Pm93bigpOjwvdHQ+PGJyPgogICAg ICAgIDx0dD7CoMKgwqAgwqDCoMKgIMKgwqDCoCDCoMKgwqAgJmx0O2NsZWFudXAgZm9yIHRlc3Qg Y2FzZSB0aWNrZXQgeHl6PC90dD48dHQ+Jmd0OzwvdHQ+PGJyPgogICAgICAgIDxicj4KICAgICAg ICA8dHQ+wqDCoMKgIMKgwqDCoCDCoMKgwqAgX3Rlc3RfdGlja2V0X3h5el9zPC90dD48dHQ+ZXR1 cDwvdHQ+PHR0PigpPC90dD48YnI+CiAgICAgICAgPGJyPgogICAgICAgIDx0dD7CoMKgwqAgwqDC oMKgIMKgwqDCoCAmbHQ7dGVzdCBjYXNlJmd0OzwvdHQ+PGJyPgogICAgICAgIDxicj4KICAgICAg ICA8dHQ+wqDCoMKgIMKgwqDCoCDCoMKgwqAgX3Rlc3RfdGlja2V0X3h5el90ZWFyZG93bjwvdHQ+ PHR0PigpPGJyPgogICAgICAgICAgPGJyPgogICAgICAgICAgPGJyPgogICAgICAgICAgPGJyPgog ICAgICAgICAgPGJyPgogICAgICAgICAgwqDCoMKgIMKgwqDCoCA8YnI+CiAgICAgICAgICDCoMKg wqAgwqDCoMKgIGRlZiB0ZXN0X3RpY2tldF9hYmMoc2VsZik8YnI+CiAgICAgICAgICDCoMKgwqAg wqDCoMKgIMKgwqDCoCAuLi48YnI+CiAgICAgICAgICA8YnI+CiAgICAgICAgICDCoMKgwqAgwqDC oMKgIGRlZiB0ZXN0X2ZpbmFsKHNlbGYpPGJyPgogICAgICAgICAgwqDCoMKgIMKgwqDCoCDCoMKg wqAgJmx0O3RyaWdnZXJzIHRoZSBjbGVhbnVwIG9mIHRoZSBzdGFuZGFsb25lCiAgICAgICAgICBp bnN0YW5jZSZndDs8YnI+CiAgICAgICAgPC90dD48L2Jsb2NrcXVvdGU+CiAgICA8L2Jsb2NrcXVv dGU+CiAgICA8dHQ+VGhpcyB3b24ndCBiZSBpbiBhIHNlcGFyYXRlIGZpbGUgY2FsbGVkIHRpY2tl dFhZWi5weT88L3R0Pjxicj4KICAgIDxibG9ja3F1b3RlIGNpdGU9Im1pZDo1MjcxNEMxNy4yMDMw MjAwQHJlZGhhdC5jb20iIHR5cGU9ImNpdGUiPgogICAgICA8YmxvY2txdW90ZT48dHQ+IDwvdHQ+ PGJyPgogICAgICAgIDxicj4KICAgICAgICA8YnI+CiAgICAgICAgwqDCoMKgIMKgwqDCoCDCoMKg wqAgPGJyPgogICAgICA8L2Jsb2NrcXVvdGU+CiAgICAgIDxmb250IGZhY2U9IlRpbWVzIE5ldyBS b21hbiwgVGltZXMsIHNlcmlmIj48YnI+CiAgICAgIDwvZm9udD4KICAgICAgPGJsb2NrcXVvdGUg Y2l0ZT0ibWlkOjUyNzE0OTA2LjcwMDA4MDdAcmVkaGF0LmNvbSIgdHlwZT0iY2l0ZSI+PGZvbnQK ICAgICAgICAgIGZhY2U9IlRpbWVzIE5ldyBSb21hbiwgVGltZXMsIHNlcmlmIj4gPGJyPgogICAg ICAgIDwvZm9udD4KICAgICAgICA8YmxvY2txdW90ZSBjaXRlPSJtaWQ6NTI3MTM4MzAuMTAxMDcw OEByZWRoYXQuY29tIiB0eXBlPSJjaXRlIj48Zm9udAogICAgICAgICAgICBmYWNlPSJUaW1lcyBO ZXcgUm9tYW4sIFRpbWVzLCBzZXJpZiI+IDxicj4KICAgICAgICAgICAgcmVnYXJkczxicj4KICAg ICAgICAgICAgdGhpZXJyeTxicj4KICAgICAgICAgIDwvZm9udD4gPGJyPgogICAgICAgICAgPGZp ZWxkc2V0IGNsYXNzPSJtaW1lQXR0YWNobWVudEhlYWRlciI+PC9maWVsZHNldD4KICAgICAgICAg IDxicj4KICAgICAgICAgIDxwcmUgd3JhcD0iIj4tLQozODktZGV2ZWwgbWFpbGluZyBsaXN0Cjxh IG1vei1kby1ub3Qtc2VuZD0idHJ1ZSIgY2xhc3M9Im1vei10eHQtbGluay1hYmJyZXZpYXRlZCIg aHJlZj0ibWFpbHRvOjM4OS1kZXZlbEBsaXN0cy5mZWRvcmFwcm9qZWN0Lm9yZyI+Mzg5LWRldmVs QGxpc3RzLmZlZG9yYXByb2plY3Qub3JnPC9hPgo8YSBtb3otZG8tbm90LXNlbmQ9InRydWUiIGNs YXNzPSJtb3otdHh0LWxpbmstZnJlZXRleHQiIGhyZWY9Imh0dHBzOi8vYWRtaW4uZmVkb3JhcHJv amVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby8zODktZGV2ZWwiPmh0dHBzOi8vYWRtaW4uZmVkb3Jh cHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby8zODktZGV2ZWw8L2E+PC9wcmU+CiAgICAgICAg PC9ibG9ja3F1b3RlPgogICAgICAgIDxicj4KICAgICAgPC9ibG9ja3F1b3RlPgogICAgICA8YnI+ CiAgICA8L2Jsb2NrcXVvdGU+CiAgICA8YnI+CiAgPC9ib2R5Pgo8L2h0bWw+Cg== --===============7324169540004624403==--