389-devel August 2016

389-devel@lists.fedoraproject.org

12 participants
46 discussions

Please review: 48805, sign comparison warnings.
by William Brown 30 Aug '16

30 Aug '16

https://fedorahosted.org/389/ticket/48805 https://fedorahosted.org/389/attachment/ticket/48805/0001-Ticket-48805-Sign… -- Sincerely, William Brown Software Engineer Red Hat, Brisbane

1 0

Sign compare checking
by William Brown 30 Aug '16

30 Aug '16

Hi, I'm going through the list of sign-compare errors from gcc, and putting in the appropriate casts (uint -> int normally). I found in filter.c: /* openldap does not return LBER_END_OF_SEQORSET - so check for len == -1 - openldap ber_next_element will not set len if it has reached the end, and -1 is not a valid value for a real len */ if ( (tag != LBER_END_OF_SEQORSET) && (len != -1) && (*fstr != NULL) ) { LDAPDebug( LDAP_DEBUG_ANY, " error parsing filter list \n", 0, 0, 0 ); slapi_ch_free((void**)fstr ); } However, len is a ber_len_t, which is a typedef uint. It's actually impossible for this value to hold a -1. So either, this is a bug in the way openldap uses the ber_len_t type, we have a mistake in our logic, or something else hokey is going on. I would like to update this to: if ( (tag != LBER_END_OF_SEQORSET) && (len == 0) && (*fstr != NULL) ) Or even: if ( (tag != LBER_END_OF_SEQORSET) && (*fstr != NULL) ) What do you think of this assessment given the ber_len_t type? -- Sincerely, William Brown Software Engineer Red Hat, Brisbane

2 3

Reminder: Please Review: ns + ds tickets
by William Brown 29 Aug '16

29 Aug '16

Hi, Nunc-stans, These have been waiting for a while: https://fedorahosted.org/nunc-stans/ticket/57 https://fedorahosted.org/nunc-stans/attachment/ticket/57/0001-Ticket-57-Abi… https://fedorahosted.org/nunc-stans/ticket/58 https://fedorahosted.org/nunc-stans/attachment/ticket/58/0001-Ticket-58-Add… Directory Server https://fedorahosted.org/389/ticket/397 https://fedorahosted.org/389/attachment/ticket/397/0001-Ticket-397-Implemen… -- Sincerely, William Brown Software Engineer Red Hat, Brisbane

1 0

Jenkins build is back to normal : 389-DS-CI #63
by Mark Reynolds 28 Aug '16

28 Aug '16

See <http://vm-058-081.abc.idm.lab.eng.brq.redhat.com:8080/job/389-DS-CI/63/>

1 0

Adding vCard Schema
by kashefi＠arissystem.com 27 Aug '16

27 Aug '16

Hello, Is it possible for you to include vCard schema in 389ds by default? https://tools.ietf.org/html/draft-gryphon-ldap-schema-vcard4-00 Best Regards Kianoosh Kashefi

2 1

Jenkins build is back to normal : 389-DS-COMMIT #93
by Mark Reynolds 27 Aug '16

27 Aug '16

See <http://vm-058-081.abc.idm.lab.eng.brq.redhat.com:8080/job/389-DS-COMMIT/93/>

1 0

please review: Ticket 48972 - remove old legacy password policy code that used ACI's
by Mark Reynolds 27 Aug '16

27 Aug '16

https://fedorahosted.org/389/ticket/48972 https://fedorahosted.org/389/attachment/ticket/48972/0001-Ticket-48972-remo…

1 0

please review: Ticket 48957 - set proper update status to replication agreement in case of failure
by Mark Reynolds 26 Aug '16

26 Aug '16

https://fedorahosted.org/389/ticket/48957 https://fedorahosted.org/389/attachment/ticket/48957/0001-Ticket-48957-set-…

1 0

Please review: 48805, fix gcc 6.0 warnings
by William Brown 26 Aug '16

26 Aug '16

https://fedorahosted.org/389/ticket/48805 https://fedorahosted.org/389/attachment/ticket/48805/0001-Ticket-48805-Misl… -- Sincerely, William Brown Software Engineer Red Hat, Brisbane

1 0

please review: Ticket 48950 - Add systemd warning to the LD_PRELOAD example in /etc/sysconfig/dirsrv
by Mark Reynolds 25 Aug '16

25 Aug '16

https://fedorahosted.org/389/ticket/48950 https://fedorahosted.org/389/attachment/ticket/48950/0001-Ticket-48950-Add-…

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

389-devel August 2016