September 2015 - 389-devel - Fedora mailing-lists

Git rights for QE team
by Simon Pichugin 09 Oct '15

09 Oct '15

Hi Nathan, Hi Mark, Hi team, as I know, we've decided to make me "gatekeeper" of QE team for managing lib389 and DS git repos. Can you please update the status of this situation? Also, there is two tickets with new reviewed testcases, that need to be pushed. Can you please help me with that? Or if I'll get the rights soon, I do it by myself. :) https://fedorahosted.org/389/ticket/47957 https://fedorahosted.org/389/ticket/48264 Thanks, Simon

2 4

Please review (take 2): [389 Project] #48299: pagedresults - when timed out, search results could have been already freed.
by Noriko Hosoi 30 Sep '15

30 Sep '15

https://fedorahosted.org/389/ticket/48299 https://fedorahosted.org/389/attachment/ticket/48299/0001-Ticket-48299-page… git patch file (master) -- revised; fixed a bug pointed out by Thierry (Thank you!!) and a minor memory leak. On 09/30/2015 01:32 AM, 389 Project wrote: > Comment (by tbordaz): > > Hi noriko, > > The fix looks good, just two remarks > * pagedresults_set_search_result_pb is called each time search result is > freed. Should not it be called in opshared.c:722 (I find this line > suspicious should not it be SLAPI_PAGED_RESULTS_INDEX ?) > * in pagedresults_set_search_result_pb, you call slapi_pblock_set(pb, > SLAPI_PAGED_RESULTS_INDEX, &index); . My understanding it is to reset the > pr_idx (index==-1). But later you test 'index'. Did you mean > slapi_pblock_'''get'''(pb, SLAPI_PAGED_RESULTS_INDEX, &index). >

1 0

Please review (revised): [389 Project] #48298: ns-slapd crash during ipa-replica-manage del
by Noriko Hosoi 30 Sep '15

30 Sep '15

https://fedorahosted.org/389/ticket/48298 https://fedorahosted.org/389/attachment/ticket/48298/0001-Ticket-48298-ns-s… git patch file (master) -- different approach -- revised following the reviews by Rich (Thank you!!)

1 0

Please review (test failed ==> a new approach): [389 Project] #48298: ns-slapd crash during ipa-replica-manage del
by Noriko Hosoi 29 Sep '15

29 Sep '15

https://fedorahosted.org/389/ticket/48298 https://fedorahosted.org/389/attachment/ticket/48298/0001-Ticket-48298-ns-s… On 09/29/2015 08:15 AM, 389 Project wrote: > Comment: > > Unfortunately, it did not pass the IPA tests. > Bug Description: The cause of the problem is rather not a race condition but accessing an already freed agreement in a plug-in: > The crashed thread is deleting an agreement object, which calls mep_pre_op. > It eventually calls op_shared_search with the deleted agreement object with > base scope and filter "(|(objectclass=*)(objectclass=ldapsubentry))" > Since it is a DSE entry it goes to dse_search, in which it calls agmt_get_ > replarea and crashes in slapi_sdn_copy by NULL dereference in from SDN... Fix Description: This patch adds the check to agmt_get_replarea, in which if the agreement is not in the agreement list, it returnes NULL repl area. When the NULL repl area is returned the callers back off with an error. Thanks, --noriko

1 0

Please review: [389 Project] #48299: pagedresults - when timed out, search results could have been already freed.
by Noriko Hosoi 29 Sep '15

29 Sep '15

https://fedorahosted.org/389/ticket/48299 https://fedorahosted.org/389/attachment/ticket/48299/0001-Ticket-48299-page…

1 0

Please review (take 3): [389 Project] #48298: ns-slapd crash during ipa-replica-manage del
by Noriko Hosoi 29 Sep '15

29 Sep '15

https://fedorahosted.org/389/ticket/48298 https://fedorahosted.org/389/attachment/ticket/48298/0001-Ticket-48298-ns-s… git patch file (master) -- merged the 2 patches and revised to avoid the self deadlock.

1 0

Please review (additional fixes - take 2): [389 Project] #48298: ns-slapd crash during ipa-replica-manage del
by Noriko Hosoi 28 Sep '15

28 Sep '15

https://fedorahosted.org/389/ticket/48298 https://fedorahosted.org/389/attachment/ticket/48298/0001-Ticket-48298-ns-s… git patch file (master) -- revised the previous patch following the comments by Rich (take 2)

1 0

Please review (additional fixes): [389 Project] #48298: ns-slapd crash during ipa-replica-manage del
by Noriko Hosoi 28 Sep '15

28 Sep '15

https://fedorahosted.org/389/ticket/48298 https://fedorahosted.org/389/attachment/ticket/48298/0001-Ticket-48298-ns-s… git patch file (master) -- additional fixes (merge them when commit) Thank you, Rich, for the reviews and comments. Do you think (1) is overkill? Description: In addition to the previous patch for #48298, 1) agmt_delete - lock all the agreement deletion in PR_Lock(ra->lock). 2) get_agmt_status - retrieve all the ra contents in PR_Lock(ra->lock) first and use them in the function. --noriko

1 0

Please review: [389 Project] #48298: ns-slapd crash during ipa-replica-manage del
by Noriko Hosoi 28 Sep '15

28 Sep '15

https://fedorahosted.org/389/ticket/48298 https://fedorahosted.org/389/attachment/ticket/48298/0001-Ticket-48298-ns-s…

1 0

please review: Ticket 48204 - Add support for python3 to lib389 and DS
by Mark Reynolds 25 Sep '15

25 Sep '15

https://fedorahosted.org/389/ticket/48204 lib389 patch https://fedorahosted.org/389/attachment/ticket/48204/0001-Ticket-48204-upda… 389-ds-base patch https://fedorahosted.org/389/attachment/ticket/48204/0001-Ticket-48204-upda…

1 2

Commit: Regression in your 389 makefile patches
by Noriko Hosoi 23 Sep '15

23 Sep '15

Thanks to Simo for fixing the 389-ds-base Makefile.am. Pushed his patch to the master branch. > commit 3c827508f8e177992010011305f78da3b3ab3b25 > Author: Simo Sorce <simo(a)redhat.com> > Date: Wed Sep 23 15:08:17 2015 -0400 > > Fix out of tree build > > Signed-off-by: Simo Sorce <simo(a)redhat.com> --noriko On 09/23/2015 12:16 PM, Simo Sorce wrote: > On 23/09/15 13:37, Simo Sorce wrote: >> I know how to fix this, I repored and I am in the process. >> It is mostly adding some $(srcdir)/ in front of some of the paths > > Can you try this patch. > This changes only Makefile.am so you'll need to run autoreconf -fi > before a configure. > > > Noriko, > you'll have to commit also the other files for a full patch to master.

1 0

Please review: Ticket 48283: many attrlist_replace errors in connection with cleanallruv
by Ludwig Krispenz 23 Sep '15

23 Sep '15

https://fedorahosted.org/389/ticket/48283 https://fedorahosted.org/389/attachment/ticket/48283/0001-Ticket-48283-many…

1 0

please review: Ticket 48266 - do not free "repl keep alive" entry if an error occurs
by Mark Reynolds 22 Sep '15

22 Sep '15

https://fedorahosted.org/389/ticket/48266 https://fedorahosted.org/389/attachment/ticket/48266/0001-Ticket-48266-do-n…

1 0

please review: Ticket 48284 - free entry during internal add when error occurs during pblock setup
by Mark Reynolds 22 Sep '15

22 Sep '15

https://fedorahosted.org/389/ticket/48284 https://fedorahosted.org/389/attachment/ticket/48284/0001-Ticket-48284-free…

1 0

please review: Ticket 48266 - Fix crash during online init of consumer (keep alive repl entry)
by Mark Reynolds 22 Sep '15

22 Sep '15

https://fedorahosted.org/389/ticket/48266 https://fedorahosted.org/389/attachment/ticket/48266/0001-Ticket-48266-Onli…

1 0

Please review (additional fix): [389 Project] #48188: segfault in ns-slapd due to accessing Slapi_DN freed in pre bind plug-in
by Noriko Hosoi 18 Sep '15

18 Sep '15

https://fedorahosted.org/389/ticket/48188 https://fedorahosted.org/389/attachment/ticket/48188/0001-Ticket-48188-segf… git patch file (master) -- Additional fixes based upon the comments by Rich in comment 24 Description: Additional fixes based upon the comments by rmeggins(a)redhat.com (Thank you, Rich!!). https://fedorahosted.org/389/ticket/48188?replyto=24#comment:24 1. Implemented the case 2) If the plugin changes the SLAPI_BIND_TARGET_SDN *value*, we need to select a different backend. It is possible (but not very useful) for the plugin to change the pointer, but use the same value. 2. Added an api slapi_be_select_exact which returns NULL if no matching backend. On 09/18/2015 11:48 AM, 389 Project wrote: > #48188: segfault in ns-slapd due to accessing Slapi_DN freed in pre bind plug-in > -------------------------------------------------+------------------------- > Reporter: wetpaste | Owner: nhosoi > Type: defect | Status: > Priority: major | accepted > Component: Directory Server | Milestone: 1.3.4.5 > Resolution: | Version: 1.3.3 > Blocked By: | Keywords: > Review: review? | segfault crash > Red Hat Bugzilla: | Blocking: > [https://bugzilla.redhat.com/show_bug.cgi?id=1264224| Ticket origin: > 1264224] | Community > -------------------------------------------------+------------------------- > > Comment (by rmeggins): > > There are two issues > > 1) If the plugin changes the SLAPI_BIND_TARGET_SDN *pointer*, we need to > use it instead of the current `sdn` and `dn`. For this, it is sufficient > to do `pb_sdn != sdn`. > > 2) If the plugin changes the SLAPI_BIND_TARGET_SDN *value*, we need to > select a different backend. It is possible (but not very useful) for the > plugin to change the pointer, but use the same value. > > I'm also not sure if it is sufficient to call `be = > slapi_be_select(sdn);`. The bind code sets the be like this: > {{{ > /* We could be serving multiple database backends. Select the > appropriate one */ > if (slapi_mapping_tree_select(pb, &be, &referral, errorbuf) != > LDAP_SUCCESS) { > send_nobackend_ldap_result( pb ); > be = NULL; > goto free_and_return; > } > }}} > Do we need to have similar logic in order to change the backend? What if > the plugin selects a non-existent backend that causes `be == > defbackend_get_backend()`? > > We also need to set the new backend in the pblock: `slapi_pblock_set( pb, > SLAPI_BACKEND, be );` >

1 0

Please review (take 2): [389 Project] #48188: segfault in ns-slapd due to accessing Slapi_DN freed in pre bind plug-in
by Noriko Hosoi 18 Sep '15

18 Sep '15

https://fedorahosted.org/389/ticket/48188 https://fedorahosted.org/389/attachment/ticket/48188/0001-Ticket-48188-segf… This patch is based upon the patch provided by Simo Sorce <simo(a)redhat.com> for Ticket #48272 - Allow PRE_BIND plugins to mangle DNs Description: Allow a pre_bind plugin to map a DN to another This is useful for plugins that deal with virtual trees or non-standard clients binding with values that are not proper DNs and similar situations. Contributed by: Simo Sorce <simo(a)redhat.com> 2 changes are made to the original patch: 1. removed "slapi_sdn_free(&sdn)" with this comment: * It is a plug-in's responsibility to free the original Slapi_DN. Note: slapi-nis already freed the original sdn. 2. reset dn from the new sdn. dn = slapi_sdn_get_dn(sdn);

1 0

Build failed in Jenkins: 389-ds-base #785
by jenkins＠fedoraproject.org 18 Sep '15

18 Sep '15

See <http://jenkins.fedorainfracloud.org/job/389-ds-base/785/changes> Changes: [thierry bordaz] Ticket 48266: Fractional replication evaluates several times the same ------------------------------------------ Started by an SCM change Building remotely on F22 (Fedora22 fedora Fedora fedora22) in workspace <http://jenkins.fedorainfracloud.org/job/389-ds-base/ws/> Wiping out workspace first. Cloning the remote Git repository Cloning repository git://git.fedorahosted.org/git/389/ds.git > git init <http://jenkins.fedorainfracloud.org/job/389-ds-base/ws/> # timeout=10 Fetching upstream changes from git://git.fedorahosted.org/git/389/ds.git > git --version # timeout=10 > git -c core.askpass=true fetch --tags --progress git://git.fedorahosted.org/git/389/ds.git +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url git://git.fedorahosted.org/git/389/ds.git # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url git://git.fedorahosted.org/git/389/ds.git # timeout=10 Fetching upstream changes from git://git.fedorahosted.org/git/389/ds.git > git -c core.askpass=true fetch --tags --progress git://git.fedorahosted.org/git/389/ds.git +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10 Checking out Revision 1a58bf85389fc4373af2bf07e96eeb4618cee2b7 (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f 1a58bf85389fc4373af2bf07e96eeb4618cee2b7 > git rev-list a35ef5563eb4da913476513a14643d2f8b1c1cf8 # timeout=10 [389-ds-base] $ /bin/sh -e /tmp/hudson9200914399771747370.sh Running configure... CFLAGS= -Wall CXXFLAGS= -Wall ./configure --with-tmpfiles-d=/etc/tmpfiles.d --with-openldap --enable-autobind --with-selinux --with-systemdsystemunitdir=/lib/systemd/system --with-systemdsystemconfdir=/etc/systemd/system --enable-debug Build log is http://jenkins.fedorainfracloud.org/job/389-ds-base/ws/build.785.txt Running make... Build log is http://jenkins.fedorainfracloud.org/job/389-ds-base/ws/build.785.txt Checking for warnings... Build http://jenkins.fedorainfracloud.org/job/389-ds-base/785/ failed There are build warnings Warning log is http://jenkins.fedorainfracloud.org/job/389-ds-base/ws/build-warns.785.txt Last 100 lines of warning log: ------------------------------------------------------------ ldap/servers/plugins/replication/repl5_inc_protocol.c:1675:10: warning: unused variable 'subentry_update_sent' [-Wunused-variable] ------------------------------------------------------------ Build step 'Execute shell' marked build as failure

1 1

please review: Ticket 48217 - fix regression with cleanAllRUV and shutdowns
by Mark Reynolds 18 Sep '15

18 Sep '15

https://fedorahosted.org/389/ticket/48217 https://fedorahosted.org/389/attachment/ticket/48217/0001-Ticket-48217-clea…

1 0

please review: Ticket 48264 - Ticket 47553 tests refactoring
by Simon Pichugin 18 Sep '15

18 Sep '15

Hi team, please review my refactoring patch. There is not much PEP8 refactor, mostly I just refactored it to the pytest structure. Some testcases were united into one, because they contained obvious big repetitions. https://fedorahosted.org/389/ticket/48264 https://fedorahosted.org/389/attachment/ticket/48264/0001-Ticket-48264-Tick…

1 0

Please review ticket 48266 (4th): Fractional replication evaluates several times the same CSN
by thierry bordaz 17 Sep '15

17 Sep '15

Thanks to Noriko who ran coverity tests the previous fix was invalid. Changing the call slapi_ch_free into slapi_ch_free_string. https://fedorahosted.org/389/attachment/ticket/48266/0001-Ticket-48266-4-Fr…

1 0

Please review ticket 48266 (3rd): Fractional replication evaluates several times the same CSN
by thierry bordaz 17 Sep '15

17 Sep '15

Thank you Noriko and Simon for your careful reviews. I modified the fix: * create the subentry with 'cn' value 'repl keep alive <rid>' * slapi_ch_free without cast * do the keep alive entry with '(&(objectclass=ldapsubentry)(cn=%s %d))', in previous fix I forgot '%d' I modified the test case following the recommended modifications https://fedorahosted.org/389/ticket/48266 https://fedorahosted.org/389/attachment/ticket/48266/0001-Ticket-48266-3-Fr… https://fedorahosted.org/389/attachment/ticket/48266/0001-Ticket-48266-2-te…

1 0

Please review (take 2): [389 Project] #48277: Assorted build fixes and make rpms target
by Noriko Hosoi 16 Sep '15

16 Sep '15

https://fedorahosted.org/389/ticket/48277 https://fedorahosted.org/389/ticket/48277#comment:4 Special thanks to Simo for his contribution and understanding our needs. I reviewed and tested the patches in #comment:4. I'd like to have another (or more) pair of eyes. Thanks, --noriko

1 0

Please review: [389 Project] #48226: In MMR, double free coould occur under some special condition
by Noriko Hosoi 16 Sep '15

16 Sep '15

https://fedorahosted.org/389/ticket/48226 https://fedorahosted.org/389/attachment/ticket/48226/0001-Ticket-48226-In-M… git patch file (master) -- additinal fix for the memory leak (regression by the previous patch) Thanks to Mark Reynolds for the CI test valgrind improvement. This leak was found by his work.

1 0

please review: Ticket 48273 - lib389 - improve valgrind functions
by Mark Reynolds 15 Sep '15

15 Sep '15

https://fedorahosted.org/389/attachment/ticket/48273/0001-Ticket-48273-Impr… lib389 update https://fedorahosted.org/389/attachment/ticket/48273/0001-Ticket-48273-Impr… 389-ds update to test scripts https://fedorahosted.org/389/attachment/ticket/48273/0001-Ticket-48273-Upda…

1 0

Please review: Ticket #48277 - Assorted build fixes and make rpms target
by Simo Sorce 15 Sep '15

15 Sep '15

https://fedorahosted.org/389/ticket/48277 There are 5 patches attached to it. Please keep me in CC if you want feedback as I am not subscribed to the list. HTH, Simo. -- Simo Sorce * Red Hat, Inc * New York

1 0

Please review ticket 48266: Fractional replication evaluates several times the same CSN
by thierry bordaz 15 Sep '15

15 Sep '15

Thank you so much Rich and Noriko for your feedbacks. I was late to take them into account and I am sorry for that delay. Here is the last patch and the associated test case. https://fedorahosted.org/389/ticket/48266 https://fedorahosted.org/389/attachment/ticket/48266/0001-Ticket-48266-2-Fr… https://fedorahosted.org/389/attachment/ticket/48266/0001-Ticket-48266-test…

1 0

please review: Ticket 47957 - Add replication test suite for a wait async feature
by Simon Pichugin 15 Sep '15

15 Sep '15

Hi team, please, review my patch that contains new test suite for the nsDS5ReplicaWaitForAsyncResults feature. https://fedorahosted.org/389/ticket/47957 https://fedorahosted.org/389/attachment/ticket/47957/0001-Ticket-47957-Add-…

1 0

please review: Ticket #47553 - Automated the verification procedure
by Simon Pichugin 15 Sep '15

15 Sep '15

https://fedorahosted.org/389/ticket/47553 https://fedorahosted.org/389/attachment/ticket/47553/0001-Ticket-47553-Auto…

1 1

please review: Ticket #47761 - Added a few testcases to the basic testsuite
by Simon Pichugin 15 Sep '15

15 Sep '15

https://fedorahosted.org/389/ticket/47761 https://fedorahosted.org/389/attachment/ticket/47761/0001-Ticket-47761-Adde…

1 2

Please review (memory leak): [389 Project] #48252: db2index creates index entry from deleted records
by Noriko Hosoi 15 Sep '15

15 Sep '15

https://fedorahosted.org/389/ticket/48252 https://fedorahosted.org/389/attachment/ticket/48252/0001-Ticket-48252-db2i… Description: Commit ca4d38dff3bd820af2bf60c9bcc82fd64aac2556 fixing ticket #48252 introduced memory leaks. . nstombstone_vals needs to be allocated just once and freed at the end. . when skipping to index an entry for being a tombstone, the entry needs to be freed.

2 1

please review: Ticket 48276 - initialize free_flags integer in reslimit_update_from_entry()
by Mark Reynolds 14 Sep '15

14 Sep '15

https://fedorahosted.org/389/ticket/48276 https://fedorahosted.org/389/attachment/ticket/48276/0001-Ticket-48276-init…

1 0

please review - lib389 fix for DS allocation failing when SER_DEPLOYED_DIR is none
by William Brown 05 Sep '15

05 Sep '15

https://fedorahosted.org/389/ticket/48271 https://fedorahosted.org/389/attachment/ticket/48271/0001-Ticket-48271-Fix-… elf.prefix-being-none-when-SER.patch -- William Brown <william(a)blackhats.net.au>

1 0

Please review: Ticket #48255 - total update request must not be lost
by Ludwig Krispenz 04 Sep '15

04 Sep '15

https://fedorahosted.org/389/ticket/48255 https://fedorahosted.org/389/attachment/ticket/48255/0001-Ticket-48255-tota…

1 0

Build failed in Jenkins: 389-ds-base #774
by jenkins＠fedoraproject.org 04 Sep '15

04 Sep '15

See <http://jenkins.fedorainfracloud.org/job/389-ds-base/774/changes> Changes: [Ludwig Krispenz] Ticket 48263 - allow plugins to detect tombstone operations ------------------------------------------ Started by an SCM change Building remotely on F22 (Fedora22 fedora Fedora fedora22) in workspace <http://jenkins.fedorainfracloud.org/job/389-ds-base/ws/> Wiping out workspace first. Cloning the remote Git repository Cloning repository git://git.fedorahosted.org/git/389/ds.git > git init <http://jenkins.fedorainfracloud.org/job/389-ds-base/ws/> # timeout=10 Fetching upstream changes from git://git.fedorahosted.org/git/389/ds.git > git --version # timeout=10 > git -c core.askpass=true fetch --tags --progress git://git.fedorahosted.org/git/389/ds.git +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url git://git.fedorahosted.org/git/389/ds.git # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url git://git.fedorahosted.org/git/389/ds.git # timeout=10 Fetching upstream changes from git://git.fedorahosted.org/git/389/ds.git > git -c core.askpass=true fetch --tags --progress git://git.fedorahosted.org/git/389/ds.git +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10 Checking out Revision d2b3236ecf2ad2e2f6733e1f7a066a2cd17aed07 (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f d2b3236ecf2ad2e2f6733e1f7a066a2cd17aed07 > git rev-list bb596ce2170ca956f9cb80e7727f6ebbd46d4834 # timeout=10 [389-ds-base] $ /bin/sh -e /tmp/hudson4652176886172060548.sh Running configure... CFLAGS= -Wall CXXFLAGS= -Wall ./configure --with-tmpfiles-d=/etc/tmpfiles.d --with-openldap --enable-autobind --with-selinux --with-systemdsystemunitdir=/lib/systemd/system --with-systemdsystemconfdir=/etc/systemd/system --enable-debug Build log is http://jenkins.fedorainfracloud.org/job/389-ds-base/ws/build.774.txt Running make... Build log is http://jenkins.fedorainfracloud.org/job/389-ds-base/ws/build.774.txt Checking for warnings... Build http://jenkins.fedorainfracloud.org/job/389-ds-base/774/ failed There are build warnings Warning log is http://jenkins.fedorainfracloud.org/job/389-ds-base/ws/build-warns.774.txt Last 100 lines of warning log: ------------------------------------------------------------ In file included from ldap/servers/plugins/acctpolicy/acct_config.c:24:0: ldap/servers/plugins/acctpolicy/acctpolicy.h:24:0: warning: "SLAPI_OP_FLAG_BYPASS_REFERRALS" redefined In file included from ldap/servers/plugins/acctpolicy/acct_config.c:23:0: ./ldap/servers/slapd/slapi-plugin.h:199:0: note: this is the location of the previous definition In file included from ldap/servers/plugins/acctpolicy/acct_init.c:48:0: ldap/servers/plugins/acctpolicy/acctpolicy.h:24:0: warning: "SLAPI_OP_FLAG_BYPASS_REFERRALS" redefined In file included from ldap/servers/plugins/acctpolicy/acct_init.c:47:0: ./ldap/servers/slapd/slapi-plugin.h:199:0: note: this is the location of the previous definition In file included from ldap/servers/plugins/acctpolicy/acct_plugin.c:28:0: ldap/servers/plugins/acctpolicy/acctpolicy.h:24:0: warning: "SLAPI_OP_FLAG_BYPASS_REFERRALS" redefined In file included from ldap/servers/plugins/acctpolicy/acct_plugin.c:27:0: ./ldap/servers/slapd/slapi-plugin.h:199:0: note: this is the location of the previous definition In file included from ldap/servers/plugins/acctpolicy/acct_util.c:27:0: ldap/servers/plugins/acctpolicy/acctpolicy.h:24:0: warning: "SLAPI_OP_FLAG_BYPASS_REFERRALS" redefined In file included from ldap/servers/plugins/acctpolicy/acct_util.c:26:0: ./ldap/servers/slapd/slapi-plugin.h:199:0: note: this is the location of the previous definition ------------------------------------------------------------ Build step 'Execute shell' marked build as failure

1 1

Please review: [389 Project] #48265: Complex filter in a search request doen't work as expected. (regression)
by Noriko Hosoi 04 Sep '15

04 Sep '15

https://fedorahosted.org/389/ticket/48265 https://fedorahosted.org/389/attachment/ticket/48265/0001-Ticket-48265-Comp… git patch file (master) https://fedorahosted.org/389/attachment/ticket/48265/0002-Ticket-48265-CI-t… git patch file (master) -- CI test

2 1

[lib389] Deref control advice needed
by William Brown 02 Sep '15

02 Sep '15

Hi, In relation to ticket 47757, I have started work on a deref control for Noriko. The idea is to get it working in lib389, then get it upstreamed into pyldap. At this point it's all done, except that the actual request control doesn't appear to work. Could one of the lib389 / ldap python experts cast their eye over this and let me know where I've gone wrong? For one, I don't think that the DerferenceControl decodeControlValue function is ever called, as I'm never seeing the encodedControlValue printed in my logs. Second, the results I get from result3 are: [('cn=testgroup,dc=example,dc=com', {'objectClass': ['top', 'extensibleobject'], 'uniqueMember': ['uid=test,dc=example,dc=com'], 'cn': ['testgroup']})] [] Which again, doesn't seem correct, as there should be a result from the control. Additionally, any tips on how to make the code nicer would be appreciated. I've attached the complete patch, with a unit test to trigger the search, but the request control looks like: """ controlValue ::= SEQUENCE OF derefSpec DerefSpec DerefSpec ::= SEQUENCE { derefAttr attributeDescription, ; with DN syntax attributes AttributeList } AttributeList ::= SEQUENCE OF attr AttributeDescription """ class AttributeList(univ.SequenceOf): componentType = AttributeDescription() class DerefSpec(univ.Sequence): componentType = namedtype.NamedTypes( namedtype.NamedType('derefAttr', AttributeDescription()), namedtype.NamedType('attributes', AttributeList()), ) class ControlValue(univ.SequenceOf): componentType = DerefSpec() class DereferenceControl(LDAPControl): """ Dereference Control """ def __init__(self, criticality, deref): LDAPControl.__init__(self, CONTROL_DEREF, criticality) self.deref = deref def encodeControlValue(self): # How does -E ask for many values? derefAttr, attributes = self.deref.split(':') attributes = attributes.split(',') al = AttributeList() i = 0 while len(attributes) > 0: al.setComponentByPosition(i, attributes.pop()) i += 1 ds = DerefSpec() ds.setComponentByName('derefAttr', derefAttr) ds.setComponentByName('attributes', al) cv = ControlValue() cv.setComponentByPosition(0, ds) print(cv.prettyPrint()) return encoder.encode(cv) def decodeControlValue(self,encodedControlValue): print(encodedControlValue)

3 6

please review: Ticket 48204 - support python3 in the DS scripts
by Mark Reynolds 02 Sep '15

02 Sep '15

https://fedorahosted.org/389/ticket/48204 https://fedorahosted.org/389/attachment/ticket/48204/0001-Ticket-48204-Conv…

1 0

please review: Ticket 48267 - Add optional config setting to MO Plugin to add required objectclass for "memberOf" attribute
by Mark Reynolds 02 Sep '15

02 Sep '15

https://fedorahosted.org/389/ticket/48267 https://fedorahosted.org/389/attachment/ticket/48267/0001-Ticket-48267-Add-…

1 0

Please review: Ticket #48263: allow plugins to detect tombstone operations
by Ludwig Krispenz 02 Sep '15

02 Sep '15

https://fedorahosted.org/389/ticket/48263 https://fedorahosted.org/389/attachment/ticket/48263/0001-Ticket-48263-allo…

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

389-devel September 2015