Ticket #47384 (plugin library path validation) and out-of-tree modules
by Nalin Dahyabhai
Hi, everyone.
I was recently adding a couple of changes to slapi-nis, and when I went
to run its self-tests, some of the tests that modify the plugin entry
started failing with LDAP_UNWILLING_TO_PERFORM. I tracked the denial
down to validation code that was added as part of ticket #47384.
While the tests don't modify the nsslapd-pluginPath attribute (the
entry's added to dse.ldif before the server starts up), some make other
changes to the plugin entry, and when they attempt that,
check_plugin_path() rejects the modify request.
The checks that were added, which ensure that plugins are only loaded
from the server's plugin directory, make it kind of difficult to run
tests using the copies of plugins in my build tree.
The language in the ticket description's pretty firm that this isn't
going to be changed, and while I can _probably_ work around it on my
end, I figured I'd ask here before going down that route: is there room
to expand this check to a whitelist, a search path, or some other method
that could be used to provide for my use case?
Thanks,
Nalin
10 years, 4 months
Please review ticket 47590 (take #4): add/split functions around replication
by thierry bordaz
This review takes into account the recommendations of last review:
* It creates a checkProperties function
This function take properties from a dict. It checks and set the
properties into the LDAP entry of the replication agreement.
It can checks the coherency of the properties as well as sets
default values.
This function translates what will be CLI properties into
replication agreement parameters.
In addition to recommendations of previous reviews
* Create a Agreement class in brooker
* mv init/status/schedule/create in that new class
* mv createDefaultReplMgr into the brooker replica class with the
function create_repl_manager()
* Handling of error condition with exceptions
What is not implemented in that review, that will be implemented with
https://fedorahosted.org/389/ticket/47600:
* Cleanup of createAgreement (use of exception). This function will
likely be replace by agreement.create().
* Cleanup of enableReplication (use of exception, move under
replica.create())
https://fedorahosted.org/389/attachment/ticket/47590/0004-Ticket-47590-CI...
10 years, 4 months