This is an automated email from the git hooks/post-receive script.
spichugi pushed a commit to branch 389-ds-base-1.4.3
in repository 389-ds-base.
The following commit(s) were added to refs/heads/389-ds-base-1.4.3 by this push:
new 7624c59 Issue 51059 - If dbhome directory is set online backup fails
7624c59 is described below
commit 7624c59bcf88d36b5c5e2d2e383631488a931441
Author: Simon Pichugin <spichugi(a)redhat.com>
AuthorDate: Wed Jul 15 21:38:19 2020 +0200
Issue 51059 - If dbhome directory is set online backup fails
Bug Description: If the dbhome directory is set, eg to /dev/shm/instance
then an online backup fails because it looks for the log.000000x file
in the wring diretcory.
This is hidden because the return code is overwritten before checking.
Fix Description: If dblayer_backup function fails - go to error processing
section.
https://pagure.io/389-ds-base/issue/51059
Reviewed by: mreynolds (Thanks!)
---
ldap/servers/slapd/back-ldbm/archive.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/ldap/servers/slapd/back-ldbm/archive.c
b/ldap/servers/slapd/back-ldbm/archive.c
index 4eb0eb5..6047e78 100644
--- a/ldap/servers/slapd/back-ldbm/archive.c
+++ b/ldap/servers/slapd/back-ldbm/archive.c
@@ -427,6 +427,11 @@ ldbm_back_ldbm2archive(Slapi_PBlock *pb)
/* tell it to archive */
return_value = dblayer_backup(li, directory, task);
+ if (return_value) {
+ slapi_log_err(SLAPI_LOG_BACKLDBM,
+ "ldbm_back_ldbm2archive", "dblayer_backup failed
(%d).\n", return_value);
+ goto err;
+ }
return_value = plugin_call_plugins(pb, SLAPI_PLUGIN_BE_POST_BACKUP_FN);
if (return_value) {
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.