This is an automated email from the git hooks/post-receive script.
firstyear pushed a change to branch master in repository lib389.
from cc6e810 Ticket 19 - Missing file and improve make new 08e96b1 Ticket 20 - Use the DN_DM constant instead of hard coding its value new b9d2a14 Ticket 19 - missing readme.md in python3
The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference.
Summary of changes: cli/dsconf | 4 ++-- cli/dsidm | 3 ++- python-lib389.spec | 4 ++-- 3 files changed, 6 insertions(+), 5 deletions(-)
This is an automated email from the git hooks/post-receive script.
firstyear pushed a commit to branch master in repository lib389.
commit 08e96b1a1b36c8e3af83652619cc064acba8e381 Author: Ilias Stamatis stamatis.iliass@gmail.com Date: Mon Apr 10 04:09:33 2017 +0300
Ticket 20 - Use the DN_DM constant instead of hard coding its value
Bug Description: We have defined the DN_DM string constant but we hard code its value in a few places instead of using it.
Fix Description: Replace the hard coded occurrences with the DN_DM constant.
https://pagure.io/lib389/issue/20
Author: Ilias95
Review by: wibrown (Thanks for your patch!) --- cli/dsconf | 4 ++-- cli/dsidm | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/cli/dsconf b/cli/dsconf index 36834fa..7b60a10 100755 --- a/cli/dsconf +++ b/cli/dsconf @@ -17,7 +17,7 @@ import sys logging.basicConfig(format='%(message)s')
from lib389 import DirSrv -from lib389._constants import DN_CONFIG +from lib389._constants import DN_CONFIG, DN_DM from lib389.cli_conf import backend as cli_backend from lib389.cli_conf import plugin as cli_plugin from lib389.cli_conf import schema as cli_schema @@ -44,7 +44,7 @@ if __name__ == '__main__': ) parser.add_argument('-D', '--binddn', help="The account to bind as for executing operations", - default='cn=Directory Manager', + default=DN_DM, ) parser.add_argument('-Z', '--starttls', help="Connect with StartTLS", diff --git a/cli/dsidm b/cli/dsidm index c615415..e253b4d 100755 --- a/cli/dsidm +++ b/cli/dsidm @@ -16,6 +16,7 @@ import logging # This has to happen before we import DirSrv else it tramples our config ... :( logging.basicConfig(format='%(message)s')
+from lib389._constants import DN_DM from lib389.cli_idm import initialise as cli_init from lib389.cli_idm import organisationalunit as cli_ou from lib389.cli_idm import group as cli_group @@ -46,7 +47,7 @@ if __name__ == '__main__': ) parser.add_argument('-D', '--binddn', help="The account to bind as for executing operations", - default='cn=Directory Manager', + default=DN_DM, ) parser.add_argument('-Z', '--starttls', help="Connect with StartTLS",
This is an automated email from the git hooks/post-receive script.
firstyear pushed a commit to branch master in repository lib389.
commit b9d2a140f14a70c58a225e5f91fe055c3eaaa79d Author: William Brown firstyear@redhat.com Date: Mon Apr 10 11:22:00 2017 +1000
Ticket 19 - missing readme.md in python3
Bug Description: rpm build breaks on fedora
Fix Description: missing readme.md on python 3
https://pagure.io/lib389/issue/19
Author: wibrown
Review by: one line fix, identical to python 2 fix. --- python-lib389.spec | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/python-lib389.spec b/python-lib389.spec index 68394ad..60dbb82 100644 --- a/python-lib389.spec +++ b/python-lib389.spec @@ -6,7 +6,7 @@ Name: python-%{srcname} Summary:%{sum} Version: %{vers} # RESET THIS TO 0 ON VERSION CHANGE -Release: 3%{?dist} +Release: 4%{?dist} %global tarver %{version}-1 Source0: http://www.port389.org/binaries/%%7Bname%7D-%%7Btarver%7D.tar.bz2 License: GPLv3+ @@ -104,7 +104,7 @@ and configuring the 389 Directory Server. %if 0%{?rhel} >= 8 || 0%{?fedora} %files -n python%{python3_pkgversion}-%{srcname} %license LICENSE -%doc README +%doc README.md %{python3_sitelib}/* %{_sbindir}/* %endif
389-commits@lists.fedoraproject.org
-
git repository hosting