This is an automated email from the git hooks/post-receive script.
mreynolds pushed a commit to branch 389-ds-base-1.4.2 in repository 389-ds-base.
The following commit(s) were added to refs/heads/389-ds-base-1.4.2 by this push: new 59a8111 Issue 51233 - ds-replcheck crashes in offline mode 59a8111 is described below
commit 59a811178ac203ddb5699a3dc3dfb138f317308f Author: Mark Reynolds mreynolds@redhat.com AuthorDate: Thu Aug 6 14:50:19 2020 -0400
Issue 51233 - ds-replcheck crashes in offline mode
Bug Description: When processing all the DN's found in the Master LDIF it is possible that the LDIF is not in the expected order and ldifsearch fails (crashing the tool).
Fix Description: If ldifsearch does not find an entry, start from the beginning of the LDIF and try again.
relates: https://pagure.io/389-ds-base/issue/51233
Reviewed by: spichugi(Thanks!) --- ldap/admin/src/scripts/ds-replcheck | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/ldap/admin/src/scripts/ds-replcheck b/ldap/admin/src/scripts/ds-replcheck index 5bb7dfc..1c133f4 100755 --- a/ldap/admin/src/scripts/ds-replcheck +++ b/ldap/admin/src/scripts/ds-replcheck @@ -725,6 +725,10 @@ def do_offline_report(opts, output_file=None): missing = False for dn in master_dns: mresult = ldif_search(MLDIF, dn) + if mresult['entry'] is None and mresult['conflict'] is None and not mresult['tombstone']: + # Try from the beginning + MLDIF.seek(0) + mresult = ldif_search(MLDIF, dn) rresult = ldif_search(RLDIF, dn)
if dn in replica_dns:
389-commits@lists.fedoraproject.org