This is an automated email from the git hooks/post-receive script.
firstyear pushed a commit to branch master
in repository lib389.
commit 2814d118b46cd7bd70ca9c9818f88e4398fdfa44
Author: William Brown <firstyear(a)redhat.com>
Date: Thu Apr 13 14:03:04 2017 +1000
Ticket 21 - Missing serverid in dirsrv_test due to incorrect allocation
Bug Description: The dirsrv_test attempts to build and destroy instances,
but it's fixture didn't allocate the instance. Due to changes in lib389
this caused exceptions.
Fix Description: Move the allocation to the fixture, and remove the init
to allocated state test.
https://pagure.io/lib389/issue/21
Author: wibrown
Review by: ilias95, mreynolds (Thanks!)
---
lib389/tests/dirsrv_test.py | 14 +++++---------
1 file changed, 5 insertions(+), 9 deletions(-)
diff --git a/lib389/tests/dirsrv_test.py b/lib389/tests/dirsrv_test.py
index 62058a5..f118369 100644
--- a/lib389/tests/dirsrv_test.py
+++ b/lib389/tests/dirsrv_test.py
@@ -32,6 +32,11 @@ class TopologyInstance(object):
def topology(request):
instance = DirSrv(verbose=False)
+ args = {SER_HOST: LOCALHOST,
+ SER_PORT: INSTANCE_PORT,
+ SER_SERVERID_PROP: INSTANCE_SERVERID}
+ instance.allocate(args)
+
if instance.exists():
instance.delete()
@@ -62,15 +67,6 @@ def test_allocate(topology):
for correct state and arguments
"""
- log.info('Check instance state is initial')
- assert topology.instance.state == DIRSRV_STATE_INIT
-
- log.info('Allocate the instance')
- args = {SER_HOST: LOCALHOST,
- SER_PORT: INSTANCE_PORT,
- SER_SERVERID_PROP: INSTANCE_SERVERID}
- topology.instance.allocate(args)
-
log.info('Check instance state is allocated')
assert topology.instance.state == DIRSRV_STATE_ALLOCATED
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.