Author: rmeggins
Update of /cvs/dirsec/ldapserver/ldap/servers/slapd
In directory cvs-int.fedora.redhat.com:/tmp/cvs-serv7325
Modified Files:
pw.c
Log Message:
Bug(s) fixed: 179723
Bug Description: crash after succesful pwdchange via ldappasswd
Reviewed by: Pete, Nathan (Thanks!)
Fix Description: The passwd_extop code does an internal operation to
change the password. Some of this code is only intended to be called
for external operations where you have a conn structure. The one place
in particular which caused this bug is in update_pw_info, where it is
only triggered if you must change the password or password expiration is
in effect. The fix is to just check to see if the pb_conn is not null.
Platforms tested: Fedora Core 4
Flag Day: no
Doc impact: no
Index: pw.c
===================================================================
RCS file: /cvs/dirsec/ldapserver/ldap/servers/slapd/pw.c,v
retrieving revision 1.9
retrieving revision 1.10
diff -u -r1.9 -r1.10
--- pw.c 25 Jan 2006 16:51:39 -0000 1.9
+++ pw.c 6 Mar 2006 20:00:47 -0000 1.10
@@ -647,8 +647,10 @@
pw_apply_mods(dn, &smods);
slapi_mods_done(&smods);
- /* reset c_needpw to 0 */
- pb->pb_conn->c_needpw = 0;
+ if (pb->pb_conn) { /* no conn for internal op */
+ /* reset c_needpw to 0 */
+ pb->pb_conn->c_needpw = 0;
+ }
return 0;
}
Show replies by thread