ldap/servers/slapd/back-ldbm/ldbm_config.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
New commits:
commit 7045c2e855cf53b3c27b5458fb9f3eb2c9a9c06f
Author: Mark Reynolds <mreynolds(a)redhat.com>
Date: Mon Oct 14 11:28:26 2013 -0400
Coverity Issue 12033
CID 12033 (#1 of 1): Unsigned compared against 0 (NO_EFFECT)unsigned_compare: This
less-than-zero comparison of an unsigned value is never true. "val < 0UL".
Removed unneccesary comparision introduced by ticket:
https://fedorahosted.org/389/ticket/47499
Reviewed by: richm(Thanks!)
diff --git a/ldap/servers/slapd/back-ldbm/ldbm_config.c
b/ldap/servers/slapd/back-ldbm/ldbm_config.c
index 3bb0371..ef5cdce 100644
--- a/ldap/servers/slapd/back-ldbm/ldbm_config.c
+++ b/ldap/servers/slapd/back-ldbm/ldbm_config.c
@@ -500,10 +500,6 @@ static int ldbm_config_dbncache_set(void *arg, void *value, char
*errorbuf, int
size_t val = (size_t) ((uintptr_t)value);
if (apply) {
- if (val < 0) {
- LDAPDebug( LDAP_DEBUG_ANY,"WARNING: ncache will not take negative
value\n", 0, 0, 0);
- val = 0;
- }
if (!dblayer_is_cachesize_sane(&val)){
PR_snprintf(errorbuf, SLAPI_DSE_RETURNTEXT_SIZE,
"Error: dbncache size value is too large.");
@@ -521,7 +517,7 @@ static int ldbm_config_dbncache_set(void *arg, void *value, char
*errorbuf, int
}
}
-
+
return retval;
}