Author: rmeggins
Update of /cvs/dirsec/ldapserver/ldap/servers/slapd
In directory cvs-int.fedora.redhat.com:/tmp/cvs-serv1711/ldapserver/ldap/servers/slapd
Modified Files:
backend_manager.c task.c
Log Message:
Resolves: bug 235743
Bug Description: small memory leaks in task code
Reviewed by: nkinder, nhosoi (Thanks!)
Fix Description: There were a few places that were using slapi_get_first/next_backend
without freeing the iterator cookie.
Platforms tested: RHEL4
Flag Day: no
Doc impact: no
Index: backend_manager.c
===================================================================
RCS file: /cvs/dirsec/ldapserver/ldap/servers/slapd/backend_manager.c,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -r1.8 -r1.9
--- backend_manager.c 15 Mar 2007 18:21:37 -0000 1.8
+++ backend_manager.c 9 Apr 2007 23:02:41 -0000 1.9
@@ -496,6 +496,7 @@
PR_Unlock(be->be_suffixlock);
be = (backend *)slapi_get_next_backend (cookie);
}
+ slapi_ch_free((void **)&cookie);
return rval;
}
Index: task.c
===================================================================
RCS file: /cvs/dirsec/ldapserver/ldap/servers/slapd/task.c,v
retrieving revision 1.10
retrieving revision 1.11
diff -u -r1.10 -r1.11
--- task.c 14 Dec 2006 23:16:54 -0000 1.10
+++ task.c 9 Apr 2007 23:02:41 -0000 1.11
@@ -1028,6 +1028,7 @@
be = (backend *)slapi_get_next_backend (cookie);
}
+ slapi_ch_free((void **)&cookie);
if (NULL == be || NULL == be->be_database->plg_db2archive) {
LDAPDebug(LDAP_DEBUG_ANY,
"ERROR: no db2archive function defined.\n", 0, 0, 0);
@@ -1174,6 +1175,7 @@
be = (backend *)slapi_get_next_backend (cookie);
}
+ slapi_ch_free((void **)&cookie);
if (NULL == be || NULL == be->be_database->plg_archive2db) {
LDAPDebug(LDAP_DEBUG_ANY,
"ERROR: no db2archive function defined.\n", 0, 0, 0);
@@ -1443,6 +1445,7 @@
be = (backend *)slapi_get_next_backend (cookie);
}
+ slapi_ch_free((void **)&cookie);
if (NULL == be || NULL == be->be_database->plg_upgradedb ||
strcasecmp(database_type, be->be_database->plg_name)) {
LDAPDebug(LDAP_DEBUG_ANY,
Show replies by date