Author: rmeggins
Update of /cvs/dirsec/directoryconsole/src/com/netscape/admin/dirserv
In directory
cvs1.fedora.phx.redhat.com:/tmp/cvs-serv18920/directoryconsole/src/com/netscape/admin/dirserv
Modified Files:
CloneServer.java
Log Message:
Resolves: bug 487831
Bug Description: Tabbed Panel display throws NullPointerException
Reviewed by: nkinder (Thanks!)
Fix Description: A couple of panels were defining an isValid method to use for clean/dirty
validation. However, the Component class which these panels inherit from also defines the
isValid method for a different purpose. Our code must not use the isValid method, so I
renamed those methods to something more meaningful in their context. I also found another
problem with a null pointer access in some schema code.
Platforms tested: RHEL5 - with Sun JRE 1.6 and OpenJDK 1.6
Flag Day: no
Doc impact: no
Index: CloneServer.java
===================================================================
RCS file: /cvs/dirsec/directoryconsole/src/com/netscape/admin/dirserv/CloneServer.java,v
retrieving revision 1.1.1.1
retrieving revision 1.2
diff -u -r1.1.1.1 -r1.2
--- CloneServer.java 18 Jul 2005 00:55:32 -0000 1.1.1.1
+++ CloneServer.java 2 Mar 2009 16:28:33 -0000 1.2
@@ -508,7 +508,7 @@
}
if ((lms == null || lms.size() == 0) &&
- (ocList == null && ocList.size() == 0)) {
+ ((ocList == null) || (ocList.size() == 0))) {
Debug.println("CloneServer.cloneSchema(): source and dest are" +
" identical, nothing to modify");
return true;
Show replies by date