VERSION.sh | 2 +- ldap/servers/slapd/pw.c | 8 +++++++- 2 files changed, 8 insertions(+), 2 deletions(-)
New commits: commit d8da32fc252bfb515c16c1436332a3f918242b99 Author: Noriko Hosoi nhosoi@totoro.usersys.redhat.com Date: Wed Feb 13 15:27:53 2013 -0800
bump version to 1.3.0.3
diff --git a/VERSION.sh b/VERSION.sh index 852013d..6391f34 100644 --- a/VERSION.sh +++ b/VERSION.sh @@ -10,7 +10,7 @@ vendor="389 Project" # PACKAGE_VERSION is constructed from these VERSION_MAJOR=1 VERSION_MINOR=3 -VERSION_MAINT=0.2 +VERSION_MAINT=0.3 # if this is a PRERELEASE, set VERSION_PREREL # otherwise, comment it out # be sure to include the dot prefix in the prerel
commit 4dcf155d2b25c15d52a6336790f2e82acb37228e Author: Noriko Hosoi nhosoi@totoro.usersys.redhat.com Date: Wed Feb 13 14:13:56 2013 -0800
Ticket #584 - Existence of an entry is not checked when its password is to be deleted
Bug description: When attempting to delete a password from an entry, a password syntax checking api check_pw_syntax_ext missed a check if the target entry exists or not. Note: add and replace checks it and handles the case correctly.
Fix description: In this patch the check is added to the delete case, as well.
Reviewed by Rich (Thank you!!) (cherry picked from commit d559d4665b18702b51161a25737b62799d8ef430)
diff --git a/ldap/servers/slapd/pw.c b/ldap/servers/slapd/pw.c index 9135a52..b01fb2b 100644 --- a/ldap/servers/slapd/pw.c +++ b/ldap/servers/slapd/pw.c @@ -777,7 +777,7 @@ int check_pw_syntax_ext ( Slapi_PBlock *pb, const Slapi_DN *sdn, Slapi_Value **vals, char **old_pw, Slapi_Entry *e, int mod_op, Slapi_Mods *smods) { - Slapi_Attr *attr; + Slapi_Attr *attr; int i, pwresponse_req = 0; int is_replication = 0; int internal_op = 0; @@ -794,6 +794,12 @@ check_pw_syntax_ext ( Slapi_PBlock *pb, const Slapi_DN *sdn, Slapi_Value **vals, * PASS == 0. */ if (LDAP_MOD_DELETE == (mod_op & LDAP_MOD_OP)) { + /* check if the entry exists or not */ + e = get_entry(pb, dn); + if (e == NULL) { + return -1; + } + slapi_entry_free(e); return 0; } if (NULL == vals) {