[SSSD] [PATCH] Incorrect *.py[co] files placement

Stephen Gallagher sgallagh at redhat.com
Mon Mar 25 12:04:24 UTC 2013


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Mon 25 Mar 2013 06:42:46 AM EDT, Jakub Hrozek wrote:
> On Mon, Mar 25, 2013 at 08:49:17AM +0100, Lukas Slebodnik wrote:
>> On (22/03/13 15:01), Jakub Hrozek wrote:
>>> On Wed, Mar 20, 2013 at 07:05:49PM +0100, Lukas Slebodnik 
>>> wrote:
>>>> Package sssd contains python files. Python files which are 
>>>> not packaged in noarch package must be installed in 
>>>> ${python_sitearch} directory and not in ${python_sitelib} 
>>>> directory
>>>> 
>>>> Autoconf detected variable $(pyexecdir) is equivalent of 
>>>> specfile ${python_sitearch}
>>>> 
>>>> https://fedorahosted.org/sssd/ticket/1839
>>>> 
>>>> LS
>>> 
>>>> -		cd $(builddir)/src/config; $(PYTHON) setup.py build 
>>>> --build-base $(abs_builddir)/src/config install 
>>>> $(DISTSETUPOPTS) --prefix=$(PYTHON_PREFIX) 
>>>> --record=$(abs_builddir)/src/config/.files; \ +		cd 
>>>> $(builddir)/src/config; $(PYTHON) setup.py build
>>>> --build-base $(abs_builddir)/src/config install
>>>> $(DISTSETUPOPTS) --prefix=$(PYTHON_PREFIX) 
>>>> --record=$(abs_builddir)/src/config/.filesi
>>> ^^^^^^^^^^^ "filesi" sounds like a typo to me
>>>> --install-purelib=$(pyexecdir); \
>> typo fixed. And I also reformat those lines to become more 
>> readable.
>> 
>> LS
> 
> Ack, RPM build and upgrade went fine. I could also import 
> SSSDConfig with the patch.


Nack.

This patch misses the point of the original bug. Rel-eng was
complaining that we had python modules contained in an arch-specific
package that were being put on disk in a noarch location. Rel-eng made
the incorrect assumption that this meant that the modules were
actually arch-specific, which they are not; SSSDConfig is pure-python
and safely noarch.

The correct solution to this is for us to add a python-sssdconfig
noarch subpackage and Requires: it from the 'sssd' package (for
backwards compatibility).
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.13 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlFQPUgACgkQeiVVYja6o6OCJQCdF/n4M4imh0/oVi7NxG2RyH5L
m/gAnjkFgyLkZdMfnRrf4VvhYNvX993e
=SePF
-----END PGP SIGNATURE-----



More information about the sssd-devel mailing list