[SSSD] SSSD Test Suite Coverage

Stephen Gallagher sgallagh at redhat.com
Fri Mar 22 18:37:34 UTC 2013


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 03/22/2013 02:33 PM, Abhishek Singh wrote:
> New tests added to success tests. Please review it.
> 

Almost :)

You can't just test for integer equivalence, because it's conceivable
that there may be other flags returned beyond just the FD_CLOEXEC flag.

You need to do:
assert_true(ret_flag & FD_CLOEXEC)

The bitwise comparison will ensure that it's non-zero if the
FD_CLOEXEC flag is set.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.13 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlFMpO4ACgkQeiVVYja6o6OJsQCfeifrXZefJL2CfKR5qFl267XG
LzwAn2AzSlodw/YfT1phEHOFuk6fTXSs
=EyN7
-----END PGP SIGNATURE-----



More information about the sssd-devel mailing list