[SSSD] [PATCH] tests: Print warning if LDB_MODULES_PATH is not set

Jakub Hrozek jhrozek at redhat.com
Wed Mar 20 12:29:11 UTC 2013


On Wed, Mar 20, 2013 at 01:17:27PM +0100, Jakub Hrozek wrote:
> On Wed, Mar 20, 2013 at 12:26:34PM +0100, Michal Židek wrote:
> > On 03/20/2013 12:14 PM, Jakub Hrozek wrote:
> > >On Mon, Mar 18, 2013 at 01:06:42PM +0100, Michal Židek wrote:
> > >>"make check" sets the LDB_MODULES_PATH automatically, but if run as
> > >>individual tests, the environment variable must be set manually,
> > >>otherwise the system memberof.so is used. This patch adds warning if
> > >>the default system memberof.so is used in sysdb-tests and
> > >>sysdb_ssh-tests.
> > >>
> > >>Patch attached.
> > >>
> > >>Michal
> > >
> > >I agree that the warning is enough. Most of the time the tests are run
> > >as part of make check and if that usecase uses the system memberof, we're
> > >fine. If you are developing the memberof plugin and want to use the in-tree
> > >memberof.so you can always set the variable yourself.
> > >
> > >Just please change the warning a little to say "Warning: LDB_MODULES_PATH
> > >is not set, will use the LDB plugins installed in system paths" or something
> > >along those lines. Currently the warning is not completely clear to me.
> > 
> > Ok. New patch attached.
> > 
> > Thanks
> > Michal
> 
> Ack

Pushed to master.



More information about the sssd-devel mailing list