[SSSD] [PATCH] Convert ldap_auth to new error codes

Jakub Hrozek jhrozek at redhat.com
Tue Mar 19 13:13:37 UTC 2013


On Tue, Mar 19, 2013 at 12:47:43PM +0100, Jakub Hrozek wrote:
> On Sat, Mar 09, 2013 at 06:15:48PM -0500, Simo Sorce wrote:
> > On Tue, 2013-03-05 at 18:57 +0100, Jakub Hrozek wrote:
> > > On Tue, Mar 05, 2013 at 06:46:00PM +0100, Jakub Hrozek wrote:
> > > > It seems that at least some error codes are mishandled. When I attempt
> > > > to auth with a bad password, SSSD returns System Error. This is not what
> > > > we want, for some display managers (xdm and I thin even kdm) the System
> > > > Error retval would mean a popup is displayed to the user.
> > > > 
> > > > Auth, GSSAPI auth and offline auth works fine, though.
> > > 
> > > btw I'm still seeing these errors even with the patch to fix masking the
> > > new error codes.
> > 
> > I fixed a couple of places where the errors were improperly translated
> > or set.
> > Now ldap auth returns the proper pam error (7, Authentication Failure)
> > with a wrong password.
> 
> Thank you, ack!

Pushed to master.



More information about the sssd-devel mailing list