[SSSD] [PATCH] Removing unused declaration of functions and variable.

Lukas Slebodnik lslebodn at redhat.com
Tue Mar 19 09:47:46 UTC 2013


On (18/03/13 10:38), Jakub Hrozek wrote:
>On Wed, Mar 13, 2013 at 01:59:05PM +0100, Lukas Slebodnik wrote:
>> Hello,
>>
>> everything important is in subject.
>>
>> LS
>
>>  extern struct dp_option default_krb5_opts[];
>>  extern struct sss_krb5_cc_be file_cc;
>> -extern struct sss_krb5_cc_be dir_cc;
>
>You can also remove file_cc here.
Declaration of file_cc removed from krb5_child-test.c.

Variables dir_cc and file_cc are used in three
modules: krb5_common.c, krb5_utils.c, krb5_child-test.c, therefore should be
declared with extern in krb5_utils.h.

Patch attached.

LS
-------------- next part --------------
>From 5295514c2cb5e23f43c9c32bc7904f1d395e9545 Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik <lslebodn at redhat.com>
Date: Wed, 13 Mar 2013 13:34:40 +0100
Subject: [PATCH] Removing unused declaration of functions and variable.

Variables dir_cc and file_cc are used in three
modules: krb5_common.c, krb5_utils.c, krb5_child-test.c, therefore should be
declared with extern in krb5_utils.h.
---
 src/providers/krb5/krb5_utils.h            |  4 ++--
 src/providers/ldap/sdap_async_initgroups.c | 10 ----------
 src/responder/nss/nsssrv_cmd.c             |  1 -
 src/tests/krb5_child-test.c                |  2 --
 4 files changed, 2 insertions(+), 15 deletions(-)

diff --git a/src/providers/krb5/krb5_utils.h b/src/providers/krb5/krb5_utils.h
index a123a795dcb251fa65ee3f538c80882cd48c5379..aad2770d4d3beb28c3ccb06278ee4cfc88562c85 100644
--- a/src/providers/krb5/krb5_utils.h
+++ b/src/providers/krb5/krb5_utils.h
@@ -64,7 +64,7 @@ struct sss_krb5_cc_be {
     cc_be_remove remove;
 };
 
-struct sss_krb5_cc_be file_cc;
+extern struct sss_krb5_cc_be file_cc;
 
 errno_t create_ccache_dir(const char *dirname, pcre *illegal_re,
                           uid_t uid, gid_t gid, bool private_path);
@@ -86,7 +86,7 @@ errno_t get_ccache_file_data(const char *ccache_file, const char *client_name,
 
 #ifdef HAVE_KRB5_DIRCACHE
 
-struct sss_krb5_cc_be dir_cc;
+extern struct sss_krb5_cc_be dir_cc;
 
 errno_t cc_dir_create(const char *location, pcre *illegal_re,
                       uid_t uid, gid_t gid, bool private_path);
diff --git a/src/providers/ldap/sdap_async_initgroups.c b/src/providers/ldap/sdap_async_initgroups.c
index a79ceb59d2417594f2233ff6022b1adc47d7bedd..a4310b4635d343aa98e192075555716a1ed08e75 100644
--- a/src/providers/ldap/sdap_async_initgroups.c
+++ b/src/providers/ldap/sdap_async_initgroups.c
@@ -2621,15 +2621,6 @@ static errno_t sdap_get_initgr_next_base(struct tevent_req *req)
     return EOK;
 }
 
-static struct tevent_req *sdap_initgr_rfc2307bis_send(
-        TALLOC_CTX *memctx,
-        struct tevent_context *ev,
-        struct sdap_options *opts,
-        struct sysdb_ctx *sysdb,
-        struct sss_domain_info *dom,
-        struct sdap_handle *sh,
-        const char *name,
-        const char *orig_dn);
 static void sdap_get_initgr_user(struct tevent_req *subreq)
 {
     struct tevent_req *req = tevent_req_callback_data(subreq,
@@ -2802,7 +2793,6 @@ fail:
     tevent_req_error(req, ret);
 }
 
-static int sdap_initgr_rfc2307bis_recv(struct tevent_req *req);
 static void sdap_get_initgr_pgid(struct tevent_req *req);
 static void sdap_get_initgr_done(struct tevent_req *subreq)
 {
diff --git a/src/responder/nss/nsssrv_cmd.c b/src/responder/nss/nsssrv_cmd.c
index b427ed9d98f229e0c4d1a06d75da75b5c92561d7..c391ed532d326cd66584164e515fe89ed8d172e5 100644
--- a/src/responder/nss/nsssrv_cmd.c
+++ b/src/responder/nss/nsssrv_cmd.c
@@ -3328,7 +3328,6 @@ static int nss_cmd_getgrent(struct cli_ctx *cctx)
     return nss_cmd_getgrent_immediate(cmdctx);
 }
 
-static errno_t nss_cmd_setgrent_recv(struct tevent_req *req);
 static void nss_cmd_implicit_setgrent_done(struct tevent_req *req)
 {
     errno_t ret;
diff --git a/src/tests/krb5_child-test.c b/src/tests/krb5_child-test.c
index a72a3519985292456db6b9bbf9bccdcf678068a6..f6ddcaad2c2506e372152c33b5d4f470f4ad489b 100644
--- a/src/tests/krb5_child-test.c
+++ b/src/tests/krb5_child-test.c
@@ -39,8 +39,6 @@
 #include "providers/krb5/krb5_utils.h"
 
 extern struct dp_option default_krb5_opts[];
-extern struct sss_krb5_cc_be file_cc;
-extern struct sss_krb5_cc_be dir_cc;
 
 static krb5_context krb5_error_ctx;
 #define KRB5_CHILD_TEST_DEBUG(level, error) KRB5_DEBUG(level, krb5_error_ctx, error)
-- 
1.8.1.4



More information about the sssd-devel mailing list