[SSSD] [PATCH] Fix broken client in master

Simo Sorce simo at redhat.com
Sat Mar 16 19:41:55 UTC 2013


On Sat, 2013-03-16 at 14:38 +0100, Lukas Slebodnik wrote:
> On (15/03/13 21:35), Simo Sorce wrote:
> >Fixes https://fedorahosted.org/sssd/ticket/1838
> >
> >Simo.
> >
> >-- 
> >Simo Sorce * Red Hat, Inc * New York
> 
> I tried to grep sources in src/sss_client directory
> (with reverted commit 22d381367c27910fe82f476a76b9f4ede555e35a)
> 
> $ grep -Rn '#include "util/util.h"'
> sudo/sss_sudo.c:28:#include "util/util.h"
> ssh/sss_ssh_knownhostsproxy.c:33:#include "util/util.h"
> ssh/sss_ssh_client.c:33:#include "util/util.h"
> ssh/sss_ssh_authorizedkeys.c:25:#include "util/util.h"
> autofs/sss_autofs_private.h:22:#include "util/util.h"
> autofs/autofs_test_client.c:31:#include "util/util.h"
> 
> Is the difference among pam, nss and others clients?

Yes, libnss and pam libraries are loaded in random programs, so we want
to keep their dependencies very strict because all the code linked into
these libraries ends up running in other applications.

So the aim is to avoid dragging into other applications any more
dependencies than necessary, and no external libraries and keep the code
as simple as possible so that it is easy to audit and not so easy to
introduce bugs. Any segfault in this code would kill the user
application, that is bad (think of a database).

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York




More information about the sssd-devel mailing list