[SSSD] [PATCH] Fix broken client in master

Lukas Slebodnik lslebodn at redhat.com
Sat Mar 16 14:40:47 UTC 2013


On (16/03/13 14:38), Lukas Slebodnik wrote:
>On (15/03/13 21:35), Simo Sorce wrote:
>>Fixes https://fedorahosted.org/sssd/ticket/1838
>>
>>Simo.
>>
>>-- 
>>Simo Sorce * Red Hat, Inc * New York
>
>I tried to grep sources in src/sss_client directory
>(with reverted commit 22d381367c27910fe82f476a76b9f4ede555e35a)
>
>$ grep -Rn '#include "util/util.h"'
>sudo/sss_sudo.c:28:#include "util/util.h"
>ssh/sss_ssh_knownhostsproxy.c:33:#include "util/util.h"
>ssh/sss_ssh_client.c:33:#include "util/util.h"
>ssh/sss_ssh_authorizedkeys.c:25:#include "util/util.h"
>autofs/sss_autofs_private.h:22:#include "util/util.h"
>autofs/autofs_test_client.c:31:#include "util/util.h"
>
>Is the difference among pam, nss and others clients?
>
>LS

Oh,
I see the problem. But wouldn't be better solution to add another
dependency (src/util/io.c) for libnss_sss instead of code duplication
Because there is also another dependency to file src/util/murmurhash3.c,
which is outside src/sss_client. Patch attached.

LS
-------------- next part --------------
>From 1a727bca09a71376de958040105e22e797c9adaa Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik <lslebodn at redhat.com>
Date: Sat, 16 Mar 2013 15:11:10 +0100
Subject: [PATCH] Fix sss_client breakage.

Adding missing dependencies for linker. Missing dependency was
introduced by commit 22d381367c27910fe82f476a76b9f4ede555e35a
in changed file src/sss_client/nss_mc_common.c

https://fedorahosted.org/sssd/ticket/1838
---
 Makefile.am | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Makefile.am b/Makefile.am
index 4cb8b64364fb8e6b8e5f1bebc4a420e7f8573126..7ebace5e39ecefed5c5f931bf6fe7600f31aabb9 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -1234,6 +1234,7 @@ libnss_sss_la_SOURCES = \
     src/sss_client/sss_cli.h \
     src/sss_client/nss_compat.h \
     src/sss_client/nss_mc_common.c \
+    src/util/io.c \
     src/util/murmurhash3.c \
     src/sss_client/nss_mc_passwd.c \
     src/sss_client/nss_mc_group.c \
-- 
1.8.1.4



More information about the sssd-devel mailing list