[SSSD] [PATCH 2/2] Making the authtok structure really opaque.
Ondrej Kos
okos at redhat.com
Fri Mar 15 08:13:56 UTC 2013
On 03/14/2013 12:58 PM, Lukas Slebodnik wrote:
> @@ -151,8 +167,10 @@ void pam_print_data(int l, struct pam_data *pd)
> DEBUG(l, ("tty: %s\n", PAM_SAFE_ITEM(pd->tty)));
> DEBUG(l, ("ruser: %s\n", PAM_SAFE_ITEM(pd->ruser)));
> DEBUG(l, ("rhost: %s\n", PAM_SAFE_ITEM(pd->rhost)));
> - DEBUG(l, ("authtok type: %d\n", sss_authtok_get_type(&pd->authtok)));
> - DEBUG(l, ("newauthtok type: %d\n", sss_authtok_get_type(&pd->newauthtok)));
> + DEBUG(SSSDBG_CRIT_FAILURE,
> + ("authtok type: %d\n", sss_authtok_get_type(pd->authtok)));
> + DEBUG(SSSDBG_CRIT_FAILURE,
> + ("newauthtok type: %d\n", sss_authtok_get_type(pd->newauthtok)));
> DEBUG(l, ("priv: %d\n", pd->priv));
> DEBUG(l, ("cli_pid: %d\n", pd->cli_pid));
> }
The patches look good to me, just please use the debug level variable
here, not hardcoded level.
--
Ondrej Kos
Associate Software Engineer
Identity Management
Red Hat Czech
phone: +420-532-294-558
cell: +420-736-417-909
ext: 82-62558
loc: 1013 Brno 1 office
irc: okos @ #sssd #brno
More information about the sssd-devel
mailing list